Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 12 Apr 2011, at 19:23, Vish <740...@bugs.launchpad.net> wrote: > ** Changed in: hundredpapercuts >   Status: Triaged => Fix Committed > > ** Changed in: hundredpapercuts > Assignee: Papercuts Ninja (papercuts-ninja) => James Schriver > (dashua)

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 21 Apr 2011, at 08:12, Launchpad Bug Tracker <740...@bugs.launchpad.net > wrote: > ** Branch linked: lp:ubuntu/light-themes > > -- > You received this bug notification because you are a member of > Papercutters, which is subscribed to One Hundred Pape

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 21 Apr 2011, at 07:44, Launchpad Bug Tracker <740...@bugs.launchpad.net > wrote: > This bug was fixed in the package light-themes - 0.1.8.13 > > --- > light-themes (0.1.8.13) natty; urgency=low > >  [James Schriver] >  * Ambiance/Radiance/a

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 22 Apr 2011, at 07:16, Vish <740...@bugs.launchpad.net> wrote: > Oh and gedit looks really good with : > widget_class "*Gedit*." style "thin" > That removes an ugly border and might work better with the overlay > scrollbars > > -- >

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 22 Apr 2011, at 10:12, Vish <740...@bugs.launchpad.net> wrote: > We could try fixing this by editing : > /usr/share/gtksourceview-2.0/styles/classic.xml , thats the theme > gedit uses by default > We have > >     > > Maybe we need a new

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 22 Apr 2011, at 06:49, Vish <740...@bugs.launchpad.net> wrote: > Werent the other matches requested by the design team as per Bug > #767531 > ? "Recommended main changes to thin out the scrollbar" > > @James, base[ACTIVE] = shade (0.9, @selected_bg_col

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 22 Apr 2011, at 10:47, Vish <740...@bugs.launchpad.net> wrote: > Yup, not an immediate concern > > ** Changed in: light-themes (Ubuntu) >   Status: Fix Released => Triaged > > ** Also affects: gedit (Ubuntu) >   Importance: Undecided >   Status:

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 28 Apr 2011, at 12:10, David Henningsson <740...@bugs.launchpad.net> wrote: > @mpt, I'm attaching a screenshot. There are four moo:s in the text, > three are yellow and one is #e5e3e1. The yellow ones stand out much > more > clearly than the light gr

Re: [Bug 740864] Re: Find result is too light gray

2011-07-26 Thread Marcus Haslam
I'm out of the office until 1st August. On 28 Apr 2011, at 12:10, David Henningsson <740...@bugs.launchpad.net> wrote: > ** Attachment added: "moo.png" >   https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/740864/+attachment/2092774/+files/moo.png > > -- > You received this bug notif

[Bug 740864] Re: Find result is too light gray

2011-04-29 Thread Paul Sladen
irclogs. appears to have dropped at the crucial period so I can't link to it, but: chaotic: all these regressions must be fixed Cimi: yes, I could see that on those two sshots you did chaotic: a way to properly fix the bug is by patching gedit Cimi: I would say your fix is the best for

[Bug 740864] Re: Find result is too light gray

2011-04-28 Thread David Henningsson
** Attachment added: "moo.png" https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/740864/+attachment/2092774/+files/moo.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: F

[Bug 740864] Re: Find result is too light gray

2011-04-28 Thread David Henningsson
@mpt, I'm attaching a screenshot. There are four moo:s in the text, three are yellow and one is #e5e3e1. The yellow ones stand out much more clearly than the light gray. It should be the other way around. Also, I don't find #e5e3e1 giving enough contrast to #ff, at least not on my screen - and

[Bug 740864] Re: Find result is too light gray

2011-04-28 Thread Matthew Paul Thomas
Sorry, I don't understand the problem. For me the unfocused selection color in gedit is #e5e3e1, which is exactly the same as other native text fields, and very different from the #ff used for the rest of the document. I don't know why there are five different colors used for the unfocused sel

[Bug 740864] Re: Find result is too light gray

2011-04-27 Thread David Barth
** Tags removed: 0day-sru -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.co

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Paul Sladen
Proposed (minimal) change to achieve the partial revert (missing corresponding debian/changelog entries): bzr diff -r86..87 lp:light-themes SRU process: https://wiki.ubuntu.com/StableReleaseUpdates -- You received this bug notification because you are a member of Ubuntu Bugs, which is subs

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread David Barth
Let me try to clarify and help find the right plan of action: 1. the release is closed now 2. it can't go as a 0day-sru, because we would have to have a clear definition of what to put in, and a clear test plan, and do that for the next week before the release; i don't see that happen right now 3

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Paul Sladen
There are at this stage three main options: a. Leave as-is (0.1.8.13): Selected text looks better during search- replace, but black-on-orange highlighted when another application is open. The borders are thinner and there the 'pixmap' theme engine is also loaded. (There is no risk of a crash).

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Vish
Yup, not an immediate concern ** Changed in: light-themes (Ubuntu) Status: Fix Released => Triaged ** Also affects: gedit (Ubuntu) Importance: Undecided Status: New ** Changed in: gedit (Ubuntu) Importance: Undecided => Low ** Changed in: gedit (Ubuntu) Status: New =>

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
@vish, maybe... will discuss at UDS. Though this is not something we can do in time for Natty, release if few days, we are in hard freeze now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Tit

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
** Attachment added: "screenshot of light-themes 0.9.12" https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/740864/+attachment/2081922/+files/Screenshot-6.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.la

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
** Attachment added: "regression introduced with the first branch merged (so 0.9.13)" https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/740864/+attachment/2081921/+files/Screenshot-5.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscri

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Paul Sladen
Otto: Cimi suggested that you might have some input on what to do about this too. Would you be able to fire up Gedit as it is now and select/search/replace some text to look at the behaviour and to the extent that it is inconsistent with other applications when the main window is focused/defocused

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Vish
We could try fixing this by editing : /usr/share/gtksourceview-2.0/styles/classic.xml , thats the theme gedit uses by default We have Maybe we need a new

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
exactly. and this is not fixable through the theme... so "won't fix" for natty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Paul Sladen
mpt: could you give some input on this (see comment #12). The problem is to do with the search+replace box over gedit stealing focus from Gedit itself and therefore making Gedit appear in-active. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed t

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
I've dived into this a little bit more, and it's not fixable without touching gedit's C code. The bugreport is reproducible only if you keep the window focus on the find/find-replace window while selecting the items, in that way, main gedit window is then using ACTIVE colors, as it should do. If y

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread David Barth
** Tags added: 0day-sru -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/

[Bug 740864] Re: Find result is too light gray

2011-04-22 Thread Andrea Cimitan
I don't want to remove the frame, the frame is everywhere, and without the frame there's 1 pixel gap with the overlay scrollbar, which is even less nice... So please, just fix this bug adding the lines I suggested, other changes to gedit will be taken into account in a SRU and discussed in front

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread Vish
Oh and gedit looks really good with : widget_class "*Gedit*." style "thin" That removes an ugly border and might work better with the overlay scrollbars -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchp

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread Vish
Werent the other matches requested by the design team as per Bug #767531 ? "Recommended main changes to thin out the scrollbar" @James, base[ACTIVE] = shade (0.9, @selected_bg_color) is better than base[ACTIVE] = @selected_bg_color , because if the active and selected are the same color we would n

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread James Schriver
Try this one. ** Branch linked: lp:~dashua/light-themes/gedit.shrinkage -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubunt

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread Paul Sladen
James: Vish: per Cimi's concerns, would you be able to whip a patch that removes the Pixmap dependency (dropping the border change if required to do so) and which tries to reduce the patch down to the minimal size suggested in comment #7. -- You received this bug notification because you are a me

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread Andrea Cimitan
I don't like this branch for a couple of reasons: 1) technically we are linking gedit to the pixmap theming engine just to hide the frame 2) removing the frame is inconsistent with the rest of our light-themes, where frames are always drawn around the scrolled window (there's in fact a frame, wi

[Bug 740864] Re: Find result is too light gray

2011-04-21 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/light-themes -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://

[Bug 740864] Re: Find result is too light gray

2011-04-20 Thread Launchpad Bug Tracker
This bug was fixed in the package light-themes - 0.1.8.13 --- light-themes (0.1.8.13) natty; urgency=low [James Schriver] * Ambiance/Radiance/apps/gedit.rc - Add gedit specific theming bits fixes (LP: #740864) - Minor gedit specific theming tweaks * Ambiance/gtk-2.0/gtkr

[Bug 740864] Re: Find result is too light gray

2011-04-12 Thread Vish
** Changed in: hundredpapercuts Status: Triaged => Fix Committed ** Changed in: hundredpapercuts Assignee: Papercuts Ninja (papercuts-ninja) => James Schriver (dashua) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https:

[Bug 740864] Re: Find result is too light gray

2011-04-12 Thread Paul Sladen
** Changed in: light-themes (Ubuntu) Milestone: None => ubuntu-11.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubunt

[Bug 740864] Re: Find result is too light gray

2011-04-12 Thread James Schriver
You should see a dark selected_bg_color now. ** Attachment added: "gedit.fix" https://bugs.launchpad.net/ubuntu/+source/light-themes/+bug/740864/+attachment/2024042/+files/Screenshot-1.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to U

[Bug 740864] Re: Find result is too light gray

2011-04-11 Thread James Schriver
Should be fixed now. ** Branch linked: lp:~dashua/light-themes/fix.lp.740864 ** Changed in: light-themes (Ubuntu) Assignee: (unassigned) => James Schriver (dashua) ** Changed in: light-themes (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because yo

[Bug 740864] Re: Find result is too light gray

2011-03-24 Thread Vish
Yup, thats a theme bug. ** Package changed: gedit (Ubuntu) => light-themes (Ubuntu) ** Changed in: light-themes (Ubuntu) Status: New => Triaged ** Changed in: hundredpapercuts Importance: Undecided => Low ** Changed in: hundredpapercuts Status: New => Triaged ** Changed in: h

[Bug 740864] Re: Find result is too light gray

2011-03-23 Thread Sebastien Bacher
** Changed in: gedit (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list ubuntu-bugs@list

[Bug 740864] Re: Find result is too light gray

2011-03-23 Thread David Henningsson
** Also affects: hundredpapercuts Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/740864 Title: Find result is too light gray -- ubuntu-bugs mailing list