[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-06-13 Thread Florian Boucault
** Changed in: unity-2d Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on PowerPC To manage notifications

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-06-13 Thread Florian Boucault
** Changed in: unity-2d Milestone: 3.10 => 3.8.6 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on PowerPC To manage notifications about this bug g

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-26 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/unity-2d -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on PowerPC -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.co

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-26 Thread Launchpad Bug Tracker
This bug was fixed in the package unity-2d - 3.8.6-0ubuntu1 --- unity-2d (3.8.6-0ubuntu1) oneiric; urgency=low * New upstream release: - [launcher] Support static shortcuts in the quicklists. (LP: #669923) - [launcher] Make sure the whole area of the item tile handle mouse e

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-18 Thread Olivier Tilloy
** Changed in: unity-2d Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on PowerPC -- ubuntu-bugs mailing l

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-07 Thread pauljwells
That's great news Olivier! I'm very pleased to have been able to give something back to Ubuntu, not to mention quite proud! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wron

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-07 Thread Olivier Tilloy
Thanks for testing Paul, that’s good news, I’m going to submit a merge request so we can merge this code in the trunk. And thanks for your thorough investigation and for the original solution! For information, the version I wrote is largely inspired by the code of QImage::rgbSwapped(), I didn’t re

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread pauljwells
@Olivier: I built your code and I can confirm it works properly on my ppc G5. Interesting to see how you directly manipulate the pixels using pointers; I have a lot to learn! This line: QRgb* end = p + image.width(); struck me as particularly clever... -- You received this bug notification be

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread Olivier Tilloy
@Paul: I reworked a bit your code, it should hopefully be more efficient now for the same end result, you can check it out at lp:~osomon/unity- 2d/bigendian. Testing and feedback welcome! ** Changed in: unity-2d Status: New => In Progress ** Changed in: unity-2d Milestone: None => 3.10

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread pauljwells
Looking at scanLine I wonder if we can't do something even lower-level. We don't actually need to use the QRgb, qRed, qBlue etc values - all we need to do is take each block of four bytes from the address given by scanLine and reverse their order. That should be the fastest way I would think? I've

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread Launchpad Bug Tracker
** Branch linked: lp:~osomon/unity-2d/bigendian -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on PowerPC -- ubuntu-bugs mailing list ubuntu-bugs@list

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread pauljwells
I'm not surprised to hear that my code is inefficient, I was just pleased to get the byte-order correct and to prove the concept so at least that doesn't have to done again. I work in Python mostly and picked the most 'Pythonesque-looking' methods! Thanks for the info on the preprocessor directive

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-06 Thread Olivier Tilloy
Great work Paul! As I mentioned earlier, I don’t have the hardware to test, but your patch looks sane to me. I have a couple of remarks: 1) To make this architecture-dependent, enclose your kludge in the following preprocessor directives: #if Q_BYTE_ORDER == Q_BIG_ENDIAN … #endif 2)

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-05 Thread pauljwells
Aha! Ignore #19. I just did a proper installation (creating debs rather than just running cmake directly) and the dash icons all work properly too! I now have a beautiful unity-2d interface on my G5 and am very happy. The underlying bug is really in Qt4, but I guess that's not going to get fixed.

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-05 Thread pauljwells
Well, I have one right here ;-) My code isn't pretty, but it works (I don't write a lot of C) Like I posted, the dash and lenses still need the fix, but I'm hoping the same code could be slotted in, once I find where that is! If I can do any testing let me know -- You received this bug notific

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-05 Thread Olivier Tilloy
Awesome Paul, that looks very promising! I will for sure have a look at your code, even though I don’t have PowerPC at hand to test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unit

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-04 Thread pauljwells
My kludge doesn't seem to fix the icons in the dash (I think it's called) and I can't see where in the code the manipulation of these images takes place. Help!? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-04 Thread pauljwells
Here's the kludged code - it's my first ever attempt at a patch I'm now really hoping that a proper dev can do something with this. (I'm hinting at Olivier Tilloy here...) ** Attachment added: "iconimageprovider.cpp" https://bugs.launchpad.net/ubuntu/+source/unity-2d/+bug/758782/+attachment/

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-04 Thread pauljwells
I've written a kludge that gives me the right colours! :-) It needs to be wrapped in something to test for powerpc architecture, which I haven't yet learned how to do and to be packaged as a deb, likewise... I'm pleased to have sorted out the logic though ** Attachment added: "Screenshot.png"

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-03 Thread pauljwells
http://www.archivum.info/qt-inter...@trolltech.com/2010-04/00352/Re -%28Qt-interest%29-Quicktime-C--gt-QImage.html looks like it has the logic needed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-03 Thread pauljwells
Further digging reveals it might still be fixable within Unity-2D Maybe in iconimageprovider.cpp ?? It looks like for powerpc architecture there needs to be a kludge to fix the QT behaviour/Apple behaviour mismatch to manually swap the byte order of the colours. Fixing this is, frankly, beyond m

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-05-01 Thread pauljwells
Actually, I think there are two bugs here... It looks like QT has an endian problem (used in unity-2d) and nouveau has one (used in 3d - although I can only use software dri on my machine) @Rogerio, very interesting work on grub! If I can be of any help with this or other issues I am keen to get m

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-30 Thread Rogério Theodoro de Brito
Hi, Paul. Well, quite probably. It seems that the new gallium 3d drivers may have endianness issues at the moment. At least they seem to do with the ATI drivers. I do plan on getting involved in the release of the next versions of Ubuntu for powerpc, now that the dust settles. In particular, I wo

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-29 Thread pauljwells
Ah, big/little endian problem :-( So it's not a Unity bug at all - is it a driver bug? Nouveau driver? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/758782 Title: Unity 2D Wrong Colours for icons on

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-29 Thread Rogério Theodoro de Brito
Just for the record, these kind of problems with colors "changed" are usually the sign of wrong endianness (i386 and amd64 are little-endian, while powerpc is big-endian). Regards, Rogério Brito. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-28 Thread pauljwells
More guesswork... This may not be a bug in unity-2d at all. I noticed that when running the 'matrix' screensaver on the ppc, the characters appear purple, rather than green like on my PC. I suspect that there is something more fundamental with the way colours are mapped for accelerated displays (?

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-20 Thread pauljwells
Icons using the default background colour look better than ones using the calculated colour - see screenshot. Is there a way of disabling the background colour? I saw in the qml files that there was a bool value to set this, but I could not find where the setting actually gets done. Any help much a

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-19 Thread pauljwells
I tried the nv driver, it gave me no display at all! Had to chroot to reinstall nouveau. Also tried the libgl1-mesa-dri-experimental driver, no change Tried different theme, the icons change but the colours remain 'weird' I'm not familiar with the code for unity - if anyone who is could suggest s

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-15 Thread pauljwells
>From my limited previous experience on vaguely similar problems, I think this is a problem with the colour depth of the icons vs the capability of the video driver. I have an nvidea geforce 6600LE and the driver is nouveau. Since ubuntu ditched the xorg.conf file I don't know how to play with any

Re: [Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-15 Thread pauljwells
It is very cool :-) On 15/04/11 09:37, Olivier Tilloy wrote: >> I attached a couple of screenshots to the bug report > Thanks for the screenshots Paul! That looks rather bad indeed… yet it > runs on PowerPC, and that is cool :) > -- You received this bug notification because you are a member of

[Bug 758782] Re: Unity 2D Wrong Colours for icons on PowerPC

2011-04-15 Thread Olivier Tilloy
> I attached a couple of screenshots to the bug report Thanks for the screenshots Paul! That looks rather bad indeed… yet it runs on PowerPC, and that is cool :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.n