** Changed in: globalmenu-extension/trunk
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window
Asked pitti to copy from natty-security to oneiric
** Changed in: firefox (Ubuntu Oneiric)
Status: Fix Committed = Fix Released
** Changed in: thunderbird (Ubuntu Oneiric)
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of
** Branch linked: lp:ubuntu/thunderbird
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing list
Note that this is causing bug 777619 and all sorts of other weirdness
with thunderbird (I've not figured out why yet)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu
Huh:
I get document.getElemenyById is not a function in maybeMoveSpinner().
And, sure enough, the document object doesn't have this function defined
(pretty much every single function is listed as undefined according to
chromebug).
--
You received this bug notification because you are a member
Ignore my last comment, I think chromebug was lying.
Basically what is happening is that the observer in thunderbirdMenu.js
never fires when the menu service comes online, so the code which moves
the spinner from the menubar to the toolbar is never called
--
You received this bug notification
Ah, thanks to Mike Conley who spotted that we are registering 2 load
handlers, and 1 of them is meant to be an unload handler :)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
This bug was fixed in the package thunderbird - 3.1.10+build1+nobinonly-
0ubuntu0.11.04.1
---
thunderbird (3.1.10+build1+nobinonly-0ubuntu0.11.04.1) natty-security;
urgency=low
* New upstream release v3.1.10 (THUNDERBIRD_3_1_10_BUILD1)
- see USN-1122-2
* Fix LP: #767966 -
** Branch linked: lp:ubuntu/natty-security/thunderbird
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs
** Branch linked: lp:ubuntu/natty-security/firefox
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing
This bug was fixed in the package firefox - 4.0.1+build1+nobinonly-
0ubuntu0.11.04.1
---
firefox (4.0.1+build1+nobinonly-0ubuntu0.11.04.1) natty-security; urgency=low
* New upstream release v4.0.1 (FIREFOX_4_0_1_BUILD1)
- see USN-1121-1
* Fix LP: #767966 - globalmenu
Good catch, thanks!
I've not had time to review it properly yet, but just at first glance,
this looks wrong to me:
--- extensions/globalmenu/chrome/content/firefoxOverlay.xul 2011-04-16
19:37:53 +
+++ extensions/globalmenu/chrome/content/firefoxOverlay.xul 2011-04-21
02:18:45 +
** Changed in: globalmenu-extension
Importance: Undecided = High
** Changed in: globalmenu-extension
Status: New = Triaged
** Package changed: firefox (Ubuntu) = ubuntu
** Also affects: Ubuntu Natty
Importance: Undecided
Status: New
** Changed in: Ubuntu Natty
** Also affects: globalmenu-extension/1.0
Importance: Undecided
Status: New
** Also affects: globalmenu-extension/trunk
Importance: High
Status: Triaged
** Changed in: globalmenu-extension/1.0
Importance: Undecided = High
** Changed in: globalmenu-extension/1.0
Yeah, I unfortunately didn't get that this was an deliberate onpopupshowing
override.
I pushed a fix that uses another approach to the same branch: Just override the
original object ctor, and try to be nice when doing so.
--
You received this bug notification because you are a member of Ubuntu
Excellent, thanks. It seems to work ok so I'll merge that in to trunk
now
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
** Changed in: globalmenu-extension/trunk
Status: Triaged = Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript
** Branch linked: lp:globalmenu-extension
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing list
** Branch linked: lp:globalmenu-extension/1.0
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing list
** Changed in: globalmenu-extension/1.0
Status: Triaged = Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
** Changed in: globalmenu-extension/1.0
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript
** Branch linked: lp:firefox/4.0
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing list
** Changed in: firefox (Ubuntu Oneiric)
Status: Triaged = Fix Committed
** Changed in: firefox (Ubuntu Natty)
Status: Triaged = Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Branch linked: lp:~mozillateam/firefox/firefox-4.0.natty
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs
** Branch linked: lp:thunderbird/3.1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
ubuntu-bugs mailing list
** Changed in: thunderbird (Ubuntu Oneiric)
Status: Triaged = Fix Committed
** Changed in: thunderbird (Ubuntu Natty)
Status: Triaged = Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Branch linked: lp:~mozillateam/thunderbird/thunderbird.natty
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
** Description changed:
+ REASON FOR SRU:
+ Polluting the global namespace isn't friendly and will break either the
globalmenu extension or other extensions that people install.
+
+ --
+
Binary package hint: firefox
The globalmenu
Per micahg's request I took a close look at this specific change:
http://bazaar.launchpad.net/~mozillateam/firefox/firefox-4.0.natty/revision/843
For its SRU worthiness. I think it should be fine. There is an
infinitesimal risk of regression if some user actually tries to depend
on the bits of
** Branch linked: lp:~testnutzer123/globalmenu-extension/js-scope-fixes
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main window javascript scope
--
Ok, some code for you...
This is my first real launchpad and bzr attempt, so please bear with me ;)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/767966
Title:
globalmenu extension pollutes main
31 matches
Mail list logo
