[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-08-21 Thread Dmitrijs Ledkovs
The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression u

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-27 Thread Dmitrijs Ledkovs
Hello Steve, or anyone else affected, Accepted mdadm into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/mdadm/3.2.5-1ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-05 Thread Sebastien Bacher
Dmitrij plans to do a mdadm SRU soon and says that this fix will be included in the upload, unsubscribing sponsors and assigning to him ** Changed in: mdadm (Ubuntu Precise) Assignee: (unassigned) => Dmitrijs Ledkovs (dmitrij.ledkov) -- You received this bug notification because you are a m

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-05 Thread Robie Basak
I understand that it's not perfect, but this is the fix that is upstream and in Quantal. If we wanted to fix the problem differently from upstream, we'd need to also do it in Quantal and carry a delta as a minimum, and ideally forward the patch to upstream as well. The format string is 39 bytes lo

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Tim Frost
80 bytes may not be enough on a server running in 64-bit mode with a large disk/array, given that the format string is 41 bytes lonmg - including 2 '%d' variables . How many digits could there be in the longest possible number of mis-matches on a system that has a raid partition of maximum support

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Robie Basak
Debdiff attached, which backports the upstream fix. Note that the return value of snprintf isn't being checked, which ideally it should be to code this defensively. But that's what upstream have done, and with 32-bit integers an 80-byte buffer will always be big enough in this case, so I think it i

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Robie Basak
** Description changed: + SRU Justification + + [Impact] + + If mdadm --monitor is being used to monitor RAID (very common), then if + a RAID reconstruction completes but with mismatches detected by the + kernel, and the number of mismatches is more than 99, then mdadm crashes + due to a buffer

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Robie Basak
Marking as Importance: High. The chances of this happening is fairly low, but if it does then mdadm will crash and administrators will lose RAID monitoring, quite possibly without noticing. ** Changed in: mdadm (Ubuntu Precise) Status: New => Triaged ** Changed in: mdadm (Ubuntu Precise)

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Jean-Baptiste Lallement
** Also affects: mdadm (Ubuntu Precise) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/946758 Title: Format string overflow in Monitor.c:check_array To ma

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Robie Basak
>From the stack trace the culprit is: char cnt[40]; sprintf(cnt, " mismatches found: %d (on raid level %d)", sra->mismatch_cnt, array.level); alert("RebuildFinished", dev, cnt, ainfo); If misma

[Bug 946758] Re: Format string overflow in Monitor.c:check_array

2012-07-04 Thread Robie Basak
** Summary changed: - mdadm crashed with SIGABRT in __libc_message() + Format string overflow in Monitor.c:check_array -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/946758 Title: Format string over