Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-04-30 Thread Daniel van Vugt
I guess there are probably conflicts here now. Although LP isn't saying so. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into

Re: [Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-04-30 Thread Daniel van Vugt
Review: Approve Looks reasonable. Only one note: (1) The change to clutter/clutter/clutter-device-manager.c is out of date already (missing https://gitlab.gnome.org/GNOME/mutter/merge_requests/552). So there is a slight risk without that second part. --

[Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-30 Thread Treviño
Marco Trevisan (Treviño) has proposed merging ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) Related bugs: Bug #1822846 in gnome-shell (Ubuntu): "Icon disappears from favorites

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-04-30 Thread Daniel van Vugt
Conflict fixed. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. --

Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic

2019-04-30 Thread Iain Lane
Review: Approve thanks! -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365984 Your team Ubuntu Desktop is subscribed to branch ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic. -- ubuntu-desktop mailing list

Re: [Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master

2019-04-30 Thread Iain Lane
Review: Approve OK, thanks, it looks good and seems to work fine. I've added a debug so you can see on the console what locale is being set in accountsservice. -- https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/365920 Your team Ubuntu

[Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-04-30 Thread Treviño
Marco Trevisan (Treviño) has proposed merging ~3v1n0/ubuntu/+source/mutter:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic. Requested reviews: Ubuntu Desktop (ubuntu-desktop) Related bugs: Bug #1772811 in gnome-shell (Ubuntu): "[SRU] different behaviors for switch

[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master

2019-04-30 Thread noreply
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix-2 into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master has been updated. Status: Needs review => Merged For more details, see:

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-30 Thread Daniel van Vugt
Review: Approve I'm not directly familiar with recent changes to gnome-shell 3.32.1. It looks reasonable, except: (1) Again I recommend not including the large section in changelog entries detailing what hasn't changed ("remaining changes:") because it is misleading to document in detail

[Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-04-30 Thread Treviño
Marco Trevisan (Treviño) has proposed merging ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) Related bugs: Bug #1826176 in gnome-shell (Ubuntu): "Applications do not receive focus in

[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic

2019-04-30 Thread Iain Lane
The proposal to merge ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix_bionic into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/bionic has been updated. Status: Needs review => Merged For more details, see:

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2019-04-30 Thread Daniel van Vugt
Status should be "Merged" now. It looks like it's already merged. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/362055 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic into