Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Daniel van Vugt
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Treviño
See the inline diff for the added-symbol. I'd like to have a SRU upload without it since we don't need to use anywhere else Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Treviño
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/bionic

2019-05-03 Thread Daniel van Vugt
Review: Approve OK then. I can confirm that last commit 78e6f42 looks correct and is what I expected. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/362055 Your team Ubuntu Desktop is requested to review the proposed merge of

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Daniel van Vugt
Sorry I keep forgetting to save my inline comments. This is from a few hours ago... Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Daniel van Vugt
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base

[Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon

2019-05-03 Thread Sebastien Bacher
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/libnm-port/+merge/366761 -- Your team Unity

Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon

2019-05-03 Thread Sebastien Bacher
Review: Approve Thanks for the work, I don't think it makes sense to review the code there since it's a lot of change and basically a backport from upstream code already used in GNOME, let's rather go through functional testing. Landing the change (especially early in the cycle) is +1 from me,

Re: [Merge] lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center

2019-05-03 Thread Sebastien Bacher
Review: Approve Thanks for the work, I don't think it makes sense to review the code there since it's a lot of change and basically a backport from upstream code already used in GNOME, let's rather go through functional testing. Landing the change (especially early in the cycle) is +1 from me,

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

2019-05-03 Thread Daniel van Vugt
Diff comments: > diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols > index 1489074..89b3d01 100644 > --- a/debian/libmutter-2-0.symbols > +++ b/debian/libmutter-2-0.symbols > @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER# > meta_gpu_kms_error_quark@Base

[Merge] lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center

2019-05-03 Thread Sebastien Bacher
The proposal to merge lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-control-center/libnm-port/+merge/366762 -- Your team Unity Control