Review: Approve
>From IRC:
Trevinho:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/353828/comments/921762
as well
Trevinho: have you just repushed another commit with the initial date staying
the same? (hard to kn
I didn't see any repush? or any MP fixing those?
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/353828
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/master.
--
ubuntu-desktop mailing lis
The proposal to merge
~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/gnome-calculator:ubuntu/master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gn
Review: Needs Fixing
So I have some requested changes and questions, but the code itself seems
mostly OK. Note that I'm not a vala expert and would appreciate, even if the
upstream patches are going to land in 3.32 (as per upstream MR comment) that
you request still a quick review in your last
It looks rebasing with ubuntu/master created some troubles here (as I fixed in
another branch and I didn't use it when creating the MP :)), anyway let me
repush it with some other changes too.
While I've asked upstream about a first quick view.
Diff comments:
> diff --git
> a/debian/patches/s
