Review: Approve
Just a nitpick on wrong alignement, but otherwise, looks good :)
Diff comments:
> diff --git
> a/debian/patches/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch
>
> b/debian/patches/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch
>
The proposal to merge
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-sh
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master with
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master-3.29.92 as a prerequisite.
Requested reviews:
Didier Roche
The proposal to merge
~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-sh
Review: Needs Information
Ok, this looks good to me, see some of my questions.
I saw that you made some changes on the MR after Florian's comment on your
patches. Is there anything you can borrow and refresh here?
See as well my 2 questions/comments
Diff comments:
> diff --git
>
For the variable, it's really up to you and what is the most readable in your
eyes. I just wanted to trigger that question so that you can think about it,
but I have no strong opinion :)
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/353825
Your team
> I saw that you made some changes on the MR after Florian's comment on your
> patches. Is there anything you can borrow and refresh here?
Yes, I wanted to refresh in case a review (like in this case) was coming in
time, so nothing functional has been changed there, but I can refresh it on
Diff comments:
> diff --git
> a/debian/patches/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch
>
> b/debian/patches/ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch
> new file mode 100644
> index 000..f601fd2
> --- /dev/null
> +++
>
Diff comments:
> diff --git
> a/debian/patches/ubuntu/search-call-Cancel-method-on-providers-when-no-data-is-ne.patch
>
> b/debian/patches/ubuntu/search-call-Cancel-method-on-providers-when-no-data-is-ne.patch
> new file mode 100644
> index 000..de98f8e
> --- /dev/null
> +++
>
