The proposal to merge
~3v1n0/ubuntu/+source/nautilus:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+
The proposal to merge
~3v1n0/ubuntu/+source/nautilus:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nauti
FYI I've submitted also part of this upstream (as it will be needed anyway for
future developments): https://gitlab.gnome.org/GNOME/nautilus/merge_requests/303
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nautilus/+merge/353826
Your team Ubuntu Desktop is subscribed to branch
Review: Approve
LGTM, thanks for addressing the issues and answering my questions :)
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/nautilus/+git/nautilus/+merge/353826
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/master.
--
ubuntu-deskto
> * You didn't metnion at all about the ignore_partial_results. [...]
> I think that ought some mention in the patch description.
Done
> * I'm unsure to understand what the meta_requests are and why they are
> treated differently (and unconditionnally).
> Is it a queue before them becoming the c
Review: Needs Information
This looks mostly good, I have some nitpicks and some questions (see below and
inline diff):
* You didn't metnion at all about the ignore_partial_results which leads to 2
different conditions (we want to ignore them or not). I think that ought some
mention in the patch
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/nautilus:ubuntu/master-xubuntu-cancel-search into
~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1756826 in nautilus (Ubuntu): "hangs when remote
