Re: Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-21 Thread Matthew Ruffell
Hi All, Thank you for your reviews and recommendations. We will go with option (3). Launchpad bug: https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1961542 Debdiff: https://launchpadlibrarian.net/587119305/lp1961542_jammy.debdiff mwh has helped sponsor the upload to jammy-proposed,

Re: Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-20 Thread Michael Hudson-Doyle
I too vote for (3). I think (2) would be the next least-bad option but given the fundamental-ness of util-linux I think it's better to be safe. Cheers, mwh On Sat, 19 Feb 2022 at 02:43, Paride Legovini wrote: > Bryce Harrington wrote on 18/02/2022: > > On Thu, Feb 17, 2022 at 01:00:07PM +1300,

Re: Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-18 Thread Paride Legovini
Bryce Harrington wrote on 18/02/2022: > On Thu, Feb 17, 2022 at 01:00:07PM +1300, Matthew Ruffell wrote: >> Hi all, >> >> I'm looking for a bit of advice about landing a new feature in util-linux, as >> things have gotten a little complicated, and with feature freeze looming, a >> second opinion

Re: Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-18 Thread Andreas Hasenack
Hi, On Fri, Feb 18, 2022 at 2:18 AM Bryce Harrington wrote: > > On Thu, Feb 17, 2022 at 01:00:07PM +1300, Matthew Ruffell wrote: > > 3) Revert the single patch which caused all of this, > > 58b510e580 libsmartcols: sanitize variable names on export output > > which is a tidier and well tested

Re: Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-17 Thread Bryce Harrington
On Thu, Feb 17, 2022 at 01:00:07PM +1300, Matthew Ruffell wrote: > Hi all, > > I'm looking for a bit of advice about landing a new feature in util-linux, as > things have gotten a little complicated, and with feature freeze looming, a > second opinion would be much appreciated. > > e.g. lsblk -P

Should we change the behaviour of -P for lsblk in util-linux for Jammy?

2022-02-17 Thread Matthew Ruffell
Hi all, I'm looking for a bit of advice about landing a new feature in util-linux, as things have gotten a little complicated, and with feature freeze looming, a second opinion would be much appreciated. util-linux 2.37.2 in Jammy has introduced some new behaviour for lsblk and similar tools