Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early

2023-04-03 Thread Mathias Nyman
On 28.3.2023 1.25, Mirsad Goran Todorovac wrote: On 27. 03. 2023. 11:50, Mathias Nyman wrote: The command allocated to set exit latency LPM values need to be freed in case the command is never queued. This would be the case if there is no change in exit latency values, or device is missing

Re: BUG: drivers/usb/host/xhci: memleak in alloc from xhci_disable_usb3_lpm_timeout()

2023-04-03 Thread Mathias Nyman
On 25.3.2023 13.33, Mirsad Goran Todorovac wrote: On 25. 03. 2023. 12:27, Mirsad Goran Todorovac wrote: Hi all! Here are again the good news and the bad news: BAD: another kernel memory leak detected (one more to hunt down and fix) GOOD: another kernel memory leak detected (one less

Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early

2023-04-03 Thread Mathias Nyman
On 27.3.2023 14.51, Greg KH wrote: On Mon, Mar 27, 2023 at 12:50:19PM +0300, Mathias Nyman wrote: The command allocated to set exit latency LPM values need to be freed in case the command is never queued. This would be the case if there is no change in exit latency values, or device is missing

[PATCH] xhci: Free the command allocated for setting LPM if we return early

2023-04-03 Thread Mathias Nyman
") Cc: Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index bdb6dd819a3b..6307bae9cddf 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -4442,6 +4442,7 @@