[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-07 Thread Martin Pitt
Thanks, looks good now! I uploaded this with dropping the subversion build dependency again, as it's only needed for get-orig-source, not the actual build. ** Changed in: golang (Ubuntu) Status: In Progress => Fix Committed ** Package changed: golang (Ubuntu) => golang-race-detector-runtim

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-07 Thread Michael Hudson-Doyle
Uploaded a new version to http://people.canonical.com/~mwh/go-race- detector-runtime/ with the following changes: 1) Applied your debdiff 2) Changed the package name to golang-race-detector-runtime for consistency with, well, golang 3) Changed the upstream version number to 0.0+svn229396 4) Added

Re: [Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-07 Thread Michael Hudson-Doyle
On 6 October 2015 at 22:34, Martin Pitt wrote: > debian/control was a bit messed up -- the Source: stanza can't have a > "Description:" field. Also, short description shouldn't end with a dot. > It should also add the LP bug ref to debian/changelog. Attaching a > debdiff for this, please apply. W

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-06 Thread Martin Pitt
Oh, if this is a non-monotonous git hash, please rather use time based versions, or a combination like 20151006+git123ABC -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487010 Title:

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-06 Thread Martin Pitt
debian/control was a bit messed up -- the Source: stanza can't have a "Description:" field. Also, short description shouldn't end with a dot. It should also add the LP bug ref to debian/changelog. Attaching a debdiff for this, please apply. However these are blockers: - an upstream version of "2

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-10-06 Thread Martin Pitt
Sorry, I mean 0.20151006+git123ABC, so that you can effortlessly go to "real" version numbers if upstream ever switches to those. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487010

Re: [Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-09-20 Thread Michael Hudson-Doyle
Thanks for the review! Part of the reason that this package is a bit confusing is that it is only building a small part of the source it includes. I added a debian/README.Debian file explaining what is going on: == Runtime support for Go's race d

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-09-18 Thread Martin Pitt
Please re-subscribe ~ubuntu-sponsors once you have a fixed package. Thanks! -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487010 Title: please upload new package to reenable go's r

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-09-17 Thread Martin Pitt
Packaging review: - Please use 3.0 (quilt) source format for clean and standard patch management. - Disabling "make check" (override_dh_auto_test) is a bit sad -- when running "make check" it fails with "unable to infer compiler target triple for clang". Is there any way to run the tests with gc

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-09-17 Thread Michael Hudson-Doyle
And another one fixed to avoid stripping the syso (which stops it working!) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487010 Title: please upload new package to reenable go's r

[Bug 1487010] Re: please upload new package to reenable go's race detector on wily

2015-09-17 Thread Michael Hudson-Doyle
I've just uploaded a fix that means the package now builds in a clean environment. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to golang in Ubuntu. https://bugs.launchpad.net/bugs/1487010 Title: please upload new package to reenable