[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-24 Thread Nigel Jones
I've had another look at this bug, reproducing etc, this time through GDB, with the output from valgrind the debug output in my last two posts, here is what I believe is happening: 1. multipath -v4 gets called (or other appropriate trigger) - multipath detects a device that it believes is new,

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-24 Thread Nigel Jones
Okay, I've created a patch that should fix the issue in two ways, first as observed in my previous comment I suspected that adding a virNodeDeviceDefFree(def) to udevAddOneDevice() would solve the issue, it for the most part did but still left approximately an 8k RES memory leak. Looking at the

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-24 Thread Dustin Kirkland
** Changed in: libvirt (Ubuntu Lucid) Status: New = In Progress ** Changed in: libvirt (Ubuntu Lucid) Importance: Undecided = Medium ** Changed in: libvirt (Ubuntu Lucid) Assignee: (unassigned) = Dustin Kirkland (kirkland) ** Changed in: libvirt (Ubuntu) Status: Confirmed

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-20 Thread ariel
Same memory leak here, running kvm+libvirtd+multipath-tools on nodes with SAN access over QLogic cards However i noticed something which i guess is highly related: udev is constantly discovering the 4 multipath devices (sdb/sdc/sdd/sde) and causing a high CPU load of around 3 (8 CPU system). ps

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-20 Thread ariel
** Attachment added: udevadm monitor -e output http://launchpadlibrarian.net/48809497/udev-events.txt.gz -- multipath + libvirtd eats away more memory over time https://bugs.launchpad.net/bugs/571093 You received this bug notification because you are a member of Ubuntu Server Team, which is

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-20 Thread ariel
I performed some additional observations, I agree Nigel's statements in #13: disabling the change ACTION in /lib/udev/rules.d/95-multipath.rules is just a bandaid, the memory leak is there anyways, just that it takes wy longer to fill in the memory. The problem solved by disabling the

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-20 Thread Niall O'Reilly
At least part of this problem seems to be independent of multipath. I'm seeing libvirtd steadily eating more memory even though I have currently no virtual machines even defined, much less active, and have not had occasion to install multipath. -- multipath + libvirtd eats away more memory over

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-20 Thread Nigel Jones
Some more investigation: --technical bits-- (non tech lower down) libvirtd debug logging (attached) shows running multipath -F/multipath -v4 does the following: 14:02:28.570: debug : udevEventHandleCallback:1363 : udev action: 'add' 14:02:28.570: info : udevGetDeviceProperty:111 : udev reports

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-19 Thread Nigel Jones
I've done a bit of an experiment and this is what I've found: Running valgrind on libvirtd -v ($ sudo valgrind -v --leak-check=full --show-reachable=yes /usr/sbin/libvirtd -v) produced the output in lp571093-libvirt-val-run1 A quick summary: ==15520== 78,696 (18,048 direct, 60,648 indirect)

[Bug 571093] Re: multipath + libvirtd eats away more memory over time

2010-05-16 Thread Dustin Kirkland
I've updated the title and marked the bug against the multipath-tools package as well. I'm a little skeptical about that though... The multipath-tools package has only had two minor changes since 10 Mar 2009. Unless something new in libvirt is only now exposing this issue... ** Summary