Review: Approve continuous-integration
PASSED: Continuous integration, rev:13
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/32/
Executed test runs:
SUCCESS:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/2
SUCCESS:
http://91.189.93.70:8080/job/ubuntu-w
The proposal to merge lp:~ahayzen/ubuntu-weather-app/reboot-add-location into
lp:ubuntu-weather-app/reboot has been updated.
Description changed to:
* Implement Add Location page
Currently the locations are retrieved in the order inwhich they were added, I
wonder if this should be by name inst
Blueprint changed by Andrew Hayzen:
Work items changed:
Work items:
[popey] ping mail out to arrange next meeting time/day (wed evening?): TODO
[nik90] Move all the design documents to one common google drive folder: DONE
[popey] Create new blueprint and add work items / milestones: TODO
Andrew Hayzen has proposed merging
lp:~ahayzen/ubuntu-weather-app/reboot-add-location into
lp:ubuntu-weather-app/reboot.
Commit message:
* Implement Add Location page
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~ahayzen/
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/73/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2208
deb:
http://
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/72/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2207
deb:
http://
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
Review: Approve continuous-integration
PASSED: Continuous integration, rev:115
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/113/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2206
deb:
http://91.189.93.70:8080/job/generic-mediumte
Blueprint changed by Andrew Hayzen:
Work items changed:
Work items:
[popey] ping mail out to arrange next meeting time/day (wed evening?): TODO
[nik90] Move all the design documents to one common google drive folder: DONE
[popey] Create new blueprint and add work items / milestones: TODO
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/71/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2205
deb:
http://
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-f
Review: Approve
Thanks, perfect :-)
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-favourites-for-history/+merge/251162
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~ubu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:387
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/462/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2204
deb:
http://91.189.93.70:8080/job/generic-mediumtests-ut
Carla Sella has proposed merging
lp:~carla-sella/ubuntu-filemanager-app/just-for-test into
lp:ubuntu-filemanager-app.
Commit message:
Just for test
Requested reviews:
Ubuntu File Manager Developers (ubuntu-filemanager-dev)
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu
test
--
https://code.launchpad.net/~carla-sella/ubuntu-filemanager-app/just-for-test/+merge/251519
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~carla-sella/ubuntu-filemanager-app/just-for-test into
lp:ubuntu-filemanager-app.
--
Mailing list: https:/
Review: Approve continuous-integration
PASSED: Continuous integration, rev:114
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/112/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2203
deb:
http://91.189.93.70:8080/job/generic-mediumte
> Sorry if I reply to the inline comments here, but it's for my brain sanity
> when I will fix them. :-)
I completely understand :D
> >Line 3783: not sure which line do you mean?
> >> If (import "../upstreamComponents”)
> The EmptyState item lives in ../upstreamComponents
Oh, right, my fault her
Riccardo, there's also the “debug” policy issue that you spotted this morning.
Dunno why it's there, but I shall fix it before the branch is merged.
Sorry if I reply to the inline comments here, but it's for my brain sanity when
I will fix them. :-)
> Line 734: QString filenameWithoutSuffix = fi
Mhh, I tried to launch it on vivid desktop 64bit.
It compiles like a charm, but then the app doesn't start, both via CLI and via
QtCreator.
It is stucked on
./src/app/ubuntu-docviewer-app
APP_ID isn't set, the handler can not be registered
I have all packages reported by the README.
What am
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/fix-infloop-ap-trunk into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/fix-infloop-ap-trunk/+merge/251122
--
Your team Ubuntu Cal
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/472/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2202
deb:
http://91.189.9
Review: Needs Fixing code
Last 2403 lines of diff (rev 90).
Unfortunately they aren't here on Launchpad. So I locally merged this branch in
the trunk, then I used qdiff, I report here interesting pieces:
src/app/qml/pdfView/PdfViewGotoDialog.qml
+Button {
+objectName:"GOButton"
+
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/fix-infloop-ap-trunk into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/fix-infloop-ap-trunk/+merge/251122
--
Your team Ubuntu Cal
There is a problem with file importing.
You do a check to check if already exists a file with the same name. If there
is, then you import the file adding a numb at the end of the name.
if(QFile::exists(destination))
But I think you should add another check: if the new file it's the same you
al
The proposal to merge lp:~acerisara/ubuntu-calculator-app/sin_cos_factorial
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~acerisara/ubuntu-calculator-app/sin_cos_factorial/+merge/250554
--
Your team Ubunt
Review: Approve continuous-integration
--
https://code.launchpad.net/~acerisara/ubuntu-calculator-app/sin_cos_factorial/+merge/250554
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-r
The proposal to merge lp:~acerisara/ubuntu-calculator-app/sin_cos_factorial
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~acerisara/ubuntu-calculator-app/sin_cos_factorial/+merge/250554
--
Your team
Review: Approve continuous-integration
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-decimal-separator-fix/+merge/249267
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-decimal-separator-fix
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-decimal-
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/mathjs140 into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs140/+merge/251419
--
Your team Ubuntu Calculator Dev
Review: Needs Information
Diff comments:
> === modified file 'app/engine/CalculationHistory.qml'
> --- app/engine/CalculationHistory.qml 2015-01-28 21:25:16 +
> +++ app/engine/CalculationHistory.qml 2015-02-27 17:16:53 +
> @@ -148,6 +148,21 @@
> );
> }
>
> +function
Try to merge from trunk, I fixed tests
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-decimal-separator-fix/+merge/249267
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~ub
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-decimal-separator-fix
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-de
Review: Approve
It works perfectly for me
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs140/+merge/251419
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewe
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/mathjs140 into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs140/+merge/251419
--
Your team Ubuntu Calculat
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/fixedTests into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixedTests/+merge/251418
--
Your team Ubuntu Calculator D
Review: Approve continuous-integration
PASSED: Continuous integration, rev:116
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/111/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2197
deb:
http://91.189.93.70:8080/job/generic-mediumte
Review: Approve
LGTM
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixedTests/+merge/251418
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubu
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/fixedTests into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixedTests/+merge/251418
--
Your team Ubuntu Calcul
Review: Approve continuous-integration
PASSED: Continuous integration, rev:116
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/110/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2196
deb:
http://91.189.93.70:8080/job/generic-mediumte
Review: Disapprove
I updated to 1.4.0 here:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs140/+merge/251419
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs130/+merge/251139
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calcula
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/mathjs130 into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/mathjs130/+merge/251139
--
Your team Ubuntu Calculat
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/fixedTests into
lp:ubuntu-calculator-app/reboot.
Commit message:
Fixed broken tests
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
https://code.launchpad.net/~rpadovani/
Review: Needs Fixing
Now looks fancy, thanks!
I left some comments inline about minor issues, could you please take a look?
Diff comments:
> === modified file 'app/engine/CalculationHistory.qml'
> --- app/engine/CalculationHistory.qml 2015-01-28 21:25:16 +
> +++ app/engine/CalculationHistor
48 matches
Mail list logo
