Review: Approve continuous-integration
PASSED: Continuous integration, rev:846
http://91.189.93.70:8080/job/music-app-ci/1281/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2269
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2269/ar
Review: Approve continuous-integration
PASSED: Continuous integration, rev:843
http://91.189.93.70:8080/job/music-app-refactor-ci/46/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2268
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Review: Approve continuous-integration
PASSED: Continuous integration, rev:843
http://91.189.93.70:8080/job/music-app-refactor-ci/45/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2267
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Victor Thompson has proposed merging
lp:~vthompson/music-app/refactor-fix-1428913 into lp:music-app/refactor.
Commit message:
Trigger list reset animation when the index did not change.
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1428913 in Ubuntu Music App: "R
Review: Approve continuous-integration
PASSED: Continuous integration, rev:845
http://91.189.93.70:8080/job/music-app-ci/1280/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2266
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2266/ar
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1428913 into
lp:music-app.
Commit message:
Trigger list reset animation when the index did not change.
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1428913 in Ubuntu Music App: "Reordering the last
The proposal to merge
lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into
lp:music-app/refactor has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze/+merge/252051
--
Review: Approve continuous-integration
PASSED: Continuous integration, rev:203
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/623/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2264
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2
Review: Approve continuous-integration
PASSED: Continuous integration, rev:378
http://91.189.93.70:8080/job/reminders-app-ci/701/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2263
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2263
Review: Approve continuous-integration
PASSED: Continuous integration, rev:842
http://91.189.93.70:8080/job/music-app-refactor-ci/44/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2262
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Review: Approve
lgtm! :)
--
https://code.launchpad.net/~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze/+merge/252051
Your team Music App Developers is subscribed to branch lp:music-app/refactor.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge
lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into
lp:music-app/refactor has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze/+merge/25205
Review: Approve continuous-integration
PASSED: Continuous integration, rev:376
http://91.189.93.70:8080/job/reminders-app-ci/700/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2261
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2261
I agree, ensuring that the other CheckBox components are not checked is no
longer necessary.
--
https://code.launchpad.net/~vthompson/ubuntu-clock-app/sound-and-repeat-on-click/+merge/250546
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://
Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into
lp:music-app/refactor.
Commit message:
* Destroy dialog before popping page
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1428450 in Ubuntu Music App: "[ref
Review: Approve continuous-integration
PASSED: Continuous integration, rev:375
http://91.189.93.70:8080/job/reminders-app-ci/699/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2260
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2260
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/cleanup-debug
into lp:reminders-app.
Commit message:
clean up debug prints
Requested reviews:
Ubuntu Reminders app developers (reminders-app-dev)
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/cleanup-d
Review: Approve continuous-integration
PASSED: Continuous integration, rev:843
http://91.189.93.70:8080/job/music-app-refactor-ci/43/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2259
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Blueprint changed by Andrew Hayzen:
Work items changed:
Work items:
[popey] ping mail out to arrange next meeting time/day (wed evening?): TODO
[nik90] Move all the design documents to one common google drive folder: DONE
[popey] Create new blueprint and add work items / milestones: TODO
Review: Approve
It is working perfectly for me.
I think we should create bug report for math.js about that.
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixComplexStorage150131/+merge/248182
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-ap
Review: Approve continuous-integration
PASSED: Continuous integration, rev:601
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1105/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2258
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:600
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1104/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2257/console
FAILURE:
http://91.189.93.70:8080/job/ubuntu-cal
This mp should be complete now.
--
https://code.launchpad.net/~carla-sella/ubuntu-calendar-app/current-day-month-year-selected/+merge/251387
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-review
Review: Approve continuous-integration
PASSED: Continuous integration, rev:374
http://91.189.93.70:8080/job/reminders-app-ci/698/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2256
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2256
Michael Zanetti has proposed merging
lp:~mzanetti/reminders-app/fix-image-widths into lp:reminders-app.
Commit message:
Always override image's widths to make it look good on our screen
Requested reviews:
Ubuntu Reminders app developers (reminders-app-dev)
For more details, see:
https://code.
Review: Approve
LGTM
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/bug_1413462/+merge/251922
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touc
The proposal to merge lp:~mzanetti/reminders-app/disable-push-notifications
into lp:reminders-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985
--
Your team Ubuntu Reminders app
Review: Approve continuous-integration
--
https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Pos
Review: Approve
LGTM
--
https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-t
The proposal to merge lp:~mzanetti/reminders-app/disable-push-notifications
into lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985
--
Your team Ubuntu Reminde
Michael Zanetti has proposed merging
lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app.
Commit message:
disable push notifications for now
We haven't had a chance to properly test and don't want users to run into
issues when it gets enabled on the server side.
Request
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into
lp:ubuntu-clock-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924
--
Your team Ubuntu Clock Developers is su
Thanks again. :)
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-rev
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924
--
Your team Ubuntu Clock Developers
Yeah sure go ahead ;)
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapp
Review: Approve continuous-integration
PASSED: Continuous integration, rev:209
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/622/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2253
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2
Review: Needs Fixing
Looks fine to me. I just have one suggestion which I've added to the diff.
That being said, I'll happily approve this if you apply that small change. :)
Diff comments:
> === modified file 'app/alarm/AlarmPage.qml'
> --- app/alarm/AlarmPage.qml 2014-10-28 10:54:45 +
> +
Review: Approve
You never know what us translators come up with. :D
But thank you for fixing that now. Shall I do a top-level approve as well?
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924
Your team Ubuntu Clock Developers is subscribed to branch lp:ubu
> Looks fine to me. I just have one suggestion which I've added to the diff.
> That being said, I'll happily approve this if you apply that small change. :)
Thanks for the review. Originally I chose not to put wrapMode for title since
it is supposed to be short and discourage 3rd party devs from
Review: Approve code review
Code wise patch seems good
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-core
Review: Approve continuous-integration
PASSED: Continuous integration, rev:208
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/621/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2252
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2
Review: Approve continuous-integration
PASSED: Continuous integration, rev:600
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1103/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2251
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
** Changed in: ubuntu-docviewer-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail, Ubuntu RSS Reader Bu
The proposal to merge
lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/LiveEventModification/+merge/247711
--
Your team U
The proposal to merge
lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/LiveEventModification/+merge/247711
--
Your
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app.
Commit message:
Fixed the empty state message not wrapping correctly.
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1428165 in Ubuntu Clock
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/bug_1413462 into lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1413462
Resetting seconds to 0 before setting the date
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
htt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:580
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1102/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2249
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
The proposal to merge
lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into
lp:ubuntu-clock-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
--
Your
Ack. Thnx for the review dpm, mzanetti.
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Review: Approve
I believe we don't need GETTEXT_LOCALEDIR unless we're explicitly using it
somewhere.
IIRC we use LOCALEDIR to install the .mo files in the right locations in clock,
which is probably defined here:
http://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/h
The proposal to merge
lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
--
Richard Somlói has proposed merging
lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into
lp:ubuntu-calendar-app.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1428501 in Ubuntu Calendar App: "Translatable string change suggestion"
https://bu
53 matches
Mail list logo
