Review: Approve
Makes sense, thanks for the fix :-)
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/reboot-validation-string-contains-operator-and-number/+merge/254311
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list:
Hi.
Checking formFactor is wrong idea.
We should check if OSK is enabled there:
1. If OSK is enabled, then do not display favourite's confirmation button,
2. If OSK is disabled, then display favourite's confirmation button
For now let's just delete confirmaation button. We will reintroduce it
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-validation-string-contains-operator-and-number
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
Seems I had some crap on my device. It's working fine now!
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/improveFavouriteTextfield/+merge/254001
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-validation-string-contains-operator-and-number
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved = Needs review
For more details, see:
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/87/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2453
deb:
Review: Approve
lgtm
--
https://code.launchpad.net/~mzanetti/reminders-app/align-section-headers/+merge/253293
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~mzanetti/reminders-app/align-section-headers into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/align-section-headers/+merge/253293
--
Your team Ubuntu Reminders app
The proposal to merge lp:~mzanetti/reminders-app/align-section-headers into
lp:reminders-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/align-section-headers/+merge/253293
--
Your team Ubuntu Reminders app
Review: Approve continuous-integration
PASSED: Continuous integration, rev:143
http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/134/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2458
deb:
Daniel Holbach has proposed merging lp:~dholbach/help-app/new-try-1432710 into
lp:help-app.
Commit message:
Replace !!T and !!I with !!QA - use new markup
Requested reviews:
Ubuntu Help app developers (help-app-dev)
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-validation-string-contains-operator-and-number
into lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved = Needs review
For more details, see:
The proposal to merge
lp:~rpadovani/ubuntu-calculator-app/improveFavouriteTextfield into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~rpadovani/ubuntu-calculator-app/improveFavouriteTextfield into
lp:ubuntu-calculator-app/reboot has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/improveFavouriteTextfield/+merge/254001
--
Review: Approve continuous-integration
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/reboot-validation-string-contains-operator-and-number/+merge/254311
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list:
Review: Approve
It is working correctly for me. Thanks.
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/improveFavouriteTextfield/+merge/254001
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app/reboot.
--
Mailing list:
Review: Approve
Sweet :) LGTM
--
https://code.launchpad.net/~vthompson/music-app/refactor-fix-1436771/+merge/254522
Your team Music App Developers is subscribed to branch lp:music-app/refactor.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~vthompson/music-app/refactor-fix-1436771 into
lp:music-app/refactor has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~vthompson/music-app/refactor-fix-1436771/+merge/254522
--
Your team Music App Developers is
Review: Approve continuous-integration
PASSED: Continuous integration, rev:129
http://91.189.93.70:8080/job/help-app-ci/21/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/21
SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/23
Click here to
In the end we solved it differently.
--
https://code.launchpad.net/~dholbach/help-app/1432710/+merge/254278
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
What a nice improvement :-)
Cool, congrats!
The only problem I found (but if you want we can fix in a later branch) is in
the bottom edge: it's reported as notebook a random notebook, and not the one
in which the note will be create.
Just let me know if you want to fix later (and so I
Review: Approve continuous-integration
PASSED: Continuous integration, rev:388
http://91.189.93.70:8080/job/reminders-app-ci/731/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2463
deb:
I've been using the app a bit and watching out for issues with this: One of
them is that the OAuth plugin requests the user to grant access to the
Reminders app. Unfortunately, that string is located on the Evernote end and
we can't change that ourselved.
Also I'm still really not sure if it's
Review: Approve continuous-integration
PASSED: Continuous integration, rev:851
http://91.189.93.70:8080/job/music-app-refactor-ci/55/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2462
deb:
Review: Approve
LGTM
--
https://code.launchpad.net/~dholbach/help-app/new-try-1432710/+merge/254581
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~dholbach/help-app/new-try-1432710 into lp:help-app
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~dholbach/help-app/new-try-1432710/+merge/254581
--
Your team Ubuntu Help app developers is subscribed to branch
26 matches
Mail list logo
