Review: Approve continuous-integration
PASSED: Continuous integration, rev:864
http://91.189.93.70:8080/job/music-app-ci/1300/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2703
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2703/ar
Review: Approve continuous-integration
PASSED: Continuous integration, rev:856
http://91.189.93.70:8080/job/music-app-refactor-ci/70/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2702
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Victor Thompson has proposed merging
lp:~vthompson/music-app/refactor-prevent-click-build-warnings into
lp:music-app/refactor.
Commit message:
Prevent click build warnings for unterminated string literals
Requested reviews:
Music App Developers (music-app-dev)
For more details, see:
https://
Victor Thompson has proposed merging
lp:~vthompson/music-app/prevent-click-build-warnings into lp:music-app.
Commit message:
Prevent click build warnings for unterminated string literals
Requested reviews:
Music App Developers (music-app-dev)
For more details, see:
https://code.launchpad.net/
The proposal to merge
lp:~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support into
lp:music-app/refactor has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support/+merge/2
Review: Approve
lgtm!
--
https://code.launchpad.net/~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support/+merge/258104
Your team Music App Developers is subscribed to branch lp:music-app/refactor.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge
lp:~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support into
lp:music-app/refactor has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support/+m
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:142
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/212/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2700
deb:
http://91.189.93.70:8080/job/generic-mediumtest
Review: Approve continuous-integration
PASSED: Continuous integration, rev:855
http://91.189.93.70:8080/job/music-app-refactor-ci/69/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2699
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/
Hello Stefano,
I tried to fix the bottom edge issue adding this line:
action_item.stretched.wait_for(True)
(action_item is the bottomEdgeTip.
If you can test this on you PC to see if it still fails.
I have found another issue though: the test fails when trying to click on the
"Chapter 3. Packa
Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/refactor-columnflow-fixes-and-preloading-support into
lp:music-app/refactor.
Commit message:
* Fixes and add preloading compatibility to ColumnFlow.qml.
Requested reviews:
Music App Developers (music-app-dev)
For more details, see:
htt
The proposal to merge
lp:~ahayzen/music-app/columnflow-fixes-and-preloading-support into lp:music-app
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/columnflow-fixes-and-preloading-support/+merge/258103
--
Your team Music A
The proposal to merge lp:~ahayzen/music-app/async-loader-pages into
lp:music-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/async-loader-pages/+merge/248809
--
Your team Music App Developers is subscribed t
For the time being we'll put the async portion of this on hold. One thing to
note is that a work around to wait a certain number of seconds before loading
the other tabs could be implemented, so loading them does not affect the
current page/tab. But that would not be ideal.
--
https://code.laun
Review: Approve
lgtm!
--
https://code.launchpad.net/~ahayzen/music-app/columnflow-fixes-and-preloading-support/+merge/258103
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-co
The proposal to merge
lp:~ahayzen/music-app/columnflow-fixes-and-preloading-support into lp:music-app
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/columnflow-fixes-and-preloading-support/+merge/258103
--
Your team M
Review: Approve continuous-integration
PASSED: Continuous integration, rev:863
http://91.189.93.70:8080/job/music-app-ci/1299/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2697
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2697/ar
Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/columnflow-fixes-and-preloading-support into lp:music-app.
Commit message:
* Fixes and add preloading compatibility to ColumnFlow.qml
Requested reviews:
Music App Developers (music-app-dev)
For more details, see:
https://code.launchpad.
Here's the log: http://paste.ubuntu.com/10971013/
I think I found out the issue.
When you run the test, where is the DocViewer window on the screen?
If the window is anchored on the bottom-right corner, the suite runs well with
no failure, but if the window is floating in the middle of the scree
Review: Approve continuous-integration
PASSED: Continuous integration, rev:839
http://91.189.93.70:8080/job/music-app-ci/1298/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2696
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2696/ar
Review: Approve continuous-integration
PASSED: Continuous integration, rev:141
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/211/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2695
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
Another thing, you are using "autopilot3 run -vv test-name" to launch the
tests, right?
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://l
By the way, Stefano, can you send me the error output you get on your computer
as this does not occur on my Desktop. The strange thing for me is that
"self.bottomEdgePageLoaded.wait_for(True)" (line 112 of __init__.py) should
work but looks like it's not for you.
Diff comments:
> === modified
Hi Stefano,
I left replies to your comments.
I will find a fix for your problem and let you know so you can test it.
Diff comments:
> === modified file 'po/com.ubuntu.docviewer.pot'
> --- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
> +++ po/com.ubuntu.docviewer.pot 2015-05-0
Review: Needs Fixing
Hi Carla,
thanks for the MP!
There is an issue that makes tests fail on my PC.
I've added two in-line comment (at lines 56 and 168).
Diff comments:
> === modified file 'po/com.ubuntu.docviewer.pot'
> --- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
> +++ po/c
\o/ passed :).
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-c
Review: Approve continuous-integration
PASSED: Continuous integration, rev:140
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/210/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2694
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:139
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/209/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2693
deb:
http://91.189.93.70:8080/job/generic-mediumtest
Ok test completed. Should be ok for rewiew now :).
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-re
Carla Sella has proposed merging lp:~carla-sella/ubuntu-docviewer-app/test-toc
into lp:ubuntu-docviewer-app.
Commit message:
First test for testing Docviewer app TOC.
Requested reviews:
Nicholas Skaggs (nskaggs)
Stefano Verzegnassi (verzegnassi-stefano)
Related bugs:
Bug #1418652 in Ubuntu
30 matches
Mail list logo
