[Ubuntu-touch-coreapps-reviewers] [Bug 1386254] Re: Move unlock button to a header action

2015-05-05 Thread nico73
Hi everyone, I'd like to share my experience : I've just received my Aquaris. There are very few tutorials when we have a bug. There is a bug with Dekko and OVH. Today we can fix it but I simply need to "unlock full access". As all the users I start with askubuntu where you can find this http://as

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app

2015-05-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/196/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2714/console FAILURE: http

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app

2015-05-05 Thread Ubuntu Phone Apps Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07/+merge/252976 -- Yo

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07/+merge/252976 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final/+merge/253131 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final/+merge/253131

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13/+merge/253130 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13/+merge/253130 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-12 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-12 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-12/+merge/253129 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-12 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve Reviewing tests is not that practical, so I'll just approve and am grateful there are tests! -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-12/+merge/253129 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanag

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Some comments: 107 + shares = smb.lisShares(); listShares() ? 138 +m_thread->wait(); This could block forever. Should a reasonable timeout instead be used? 151 +emit working(true); 152 +m_sharesList = smb.lisShares(); 153 +emit working(false); I don't

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10/+merge/252981 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10/+merge/252981 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09/+merge/252979 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09/+merge/252979 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-08 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-08 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-08/+merge/252977 -- Yo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-08 into lp:ubuntu-filemanager-app

2015-05-05 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-08/+merge/252977 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app

2015-05-05 Thread Nicholas Skaggs
Review: Needs Fixing Some comments :-) Diff comments: > === modified file 'po/com.ubuntu.docviewer.pot' > --- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 + > +++ po/com.ubuntu.docviewer.pot 2015-05-04 20:16:06 + > @@ -8,7 +8,7 @@ > msgstr "" > "Project-Id-Version: \n" >

[Ubuntu-touch-coreapps-reviewers] funtion repeat one

2015-05-05 Thread claudio
Hi all, Can you please implement the functionality in our Music App, "repeat one" Song in the playlist modus , at moment seems that is only possible to repeat a whole playlist. BR CLaudio -- This message was sent from Launchpad by claudio (https://launchpad.net/~claudio2) using the "Contact thi

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app

2015-05-05 Thread Carla Sella
I am not sure if Nicholas has to approve it too, maybe just ask him :), I usually always ask him to reiview,but maybe it is not necessary. -- Carla Sella email: carla.se...@gmail.com http://about.me/carla.sella On Tue, May 5, 2015 at 3:02 PM, Stefano Verzegnassi wrote: > Forgot to ask: should

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app

2015-05-05 Thread Stefano Verzegnassi
Forgot to ask: should I wait for balloons' review, before top-approve it? -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-docviewer-app/test-toc into lp:ubuntu-docviewer-app

2015-05-05 Thread Stefano Verzegnassi
Review: Approve Heh, if I had to write this test suite, I'd be still trying to understand where to start. :-) Anyway, it LGTM now! Thanks Carla! P.S. No problem for having sent the comment several times! -- https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082 Your