Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:149 http://91.189.93.70:8080/job/help-app-ci/37/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/37 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/39 Click here to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:388 http://91.189.93.70:8080/job/reminders-app-ci/750/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2830 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/WeekViewHighlight into lp:ubuntu-calendar-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:646 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1175/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2832 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread Michael Zanetti
Review: Approve yeehaa! I propose following plan: a) Build a package with the 3 critical fixes, the rename and the icon b) Distribute it for testing to some known users c) Contact Evernote to update the key's name from Reminders to Notes --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/fix-1434500 into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1434500/+merge/253651 -- Your team Ubuntu Reminders app developers is subscribed to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread noreply
The proposal to merge lp:~popey/reminders-app/fix-1434500 into lp:reminders-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1434500/+merge/253651 -- Your team Ubuntu Reminders app developers is subscribed to branch

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into lp:ubuntu-calendar-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:625 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1176/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2833 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/SettingToAccountSetup into lp:ubuntu-calendar-app

2015-05-28 Thread Kunal Parmar
Could you try to make the list item at least the same size as the others account items. And the google icon the same size as the calendar color rectangle. Hi, I tried to address your comment, can you have another look --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/SettingToAccountSetup into lp:ubuntu-calendar-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:619 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1177/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2835/console FAILURE:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into lp:ubuntu-calendar-app

2015-05-28 Thread Kunal Parmar
Hi Andrea, Your comment was very helpful. Now I modified the code, can you have a another look. Thanks -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234 Your team Ubuntu Calendar Developers is requested to review the proposed merge of

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-28 Thread Daniel Holbach
Review: Needs Fixing In the HACKING doc, the cd / command isn't quite right, ie remove the leading '/'. Also: http://pastebin.ubuntu.com/11413858/ Would this also work with launching the 'web' version? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206