Review: Needs Fixing
Not added in your mp but in app/components/Helpers/UriHandlerHelper.qml we
double decode the URI could you remove the instance on line 71. Otherwise this
mp looks good :-)
app/components/Helpers/UriHandlerHelper.qml:71:uri =
decodeURIComponent(uri);
Review: Approve continuous-integration
PASSED: Continuous integration, rev:865
http://91.189.93.70:8080/job/music-app-ci/1307/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2883
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:272
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/657/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2884/console
Click here to trigger a rebuild:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:449
http://91.189.93.70:8080/job/reminders-app-ci/752/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2881
deb:
Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/capture-errors-for-currentMeta into lp:music-app.
Commit message:
* Safeguard against all errors when reading the ms2 lookup and setting into our
currentMeta*
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug
Think we need to investigate page head sections vs head actions as well.
Otherwise looks interesting, I wonder what other sorting methods we should
have, these should be explored when doing convergence.
--
https://code.launchpad.net/~vthompson/music-app/sort-songs-tab-by-date/+merge/260906
Your
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:273
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/658/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2885/console
Click here to trigger a rebuild:
Review: Needs Information
I have just one inline question/comment. Otherwise this looks good. I still can
get the lookup failures when the source is set. However, that might be an issue
with lp:1449296.
Diff comments:
=== modified file 'app/components/Player.qml'
---
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/3.5-finish-alarm-migration into lp:ubuntu-clock-app
with lp:~nik90/ubuntu-clock-app/3-migrate-alarm-listitems as a prerequisite.
Commit message:
Finishes alarm lists migrations
Requested reviews:
Ubuntu Clock Developers
Review: Approve
LGTM, thanks for the extra remove :-)
--
https://code.launchpad.net/~vthompson/music-app/decode-before-ms2-lookup/+merge/260891
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge lp:~vthompson/music-app/decode-before-ms2-lookup into
lp:music-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~vthompson/music-app/decode-before-ms2-lookup/+merge/260891
--
Your team Music App Developers is
Review: Approve
lgtm! Will top approve once the paired mp lands.
--
https://code.launchpad.net/~ahayzen/music-app/capture-errors-for-currentMeta/+merge/261012
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:864
http://91.189.93.70:8080/job/music-app-ci/1308/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2888
deb:
The proposal to merge lp:~nskaggs/help-app/functional-test-template into
lp:help-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206
--
Your team Ubuntu Help app developers is subscribed
Review: Approve continuous-integration
PASSED: Continuous integration, rev:146
http://91.189.93.70:8080/job/help-app-ci/38/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/38
SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/40
Click here to
In en_GB this is pretty tight on a low resolution display like the bq e4.5.
Here's the current calendar app:-
http://people.canonical.com/~alan/screenshots/device-2015-06-02-120425.png
This is what it looks like with your change:-
Review: Approve
kalikiana dholbach: looking very good now!
--
https://code.launchpad.net/~dholbach/help-app/1456929/+merge/260920
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~vthompson/ubuntu-weather-app/weather-updated-icon
into lp:ubuntu-weather-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/weather-updated-icon/+merge/259762
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-weather-app-autolanding/169/
Executed test runs:
None: http://91.189.93.70:8080/job/generic-land-weather-app/72/console
FAILURE:
The proposal to merge lp:~vthompson/ubuntu-weather-app/weather-updated-icon
into lp:ubuntu-weather-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/weather-updated-icon/+merge/259762
--
Your team Ubuntu
The proposal to merge lp:~vthompson/ubuntu-weather-app/weather-updated-icon
into lp:ubuntu-weather-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/weather-updated-icon/+merge/259762
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-weather-app-autolanding/168/
Executed test runs:
None: http://91.189.93.70:8080/job/generic-land-weather-app/71/console
FAILURE:
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09/+merge/252979
--
Your
I had a look on this, and there are a few components that steals the focus.
When loading a PDF file, you'll see that the bottom edge tip is visible (that
means that has the active focus)
The first time the go to page dialog is opened, the virtual keyboard flicks
and then disappears.
Tap on the
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/1-migrate-add-city-listitems into
lp:ubuntu-clock-app with lp:~nik90/ubuntu-clock-app/migrate-to-15.04-framework
as a prerequisite.
Commit message:
Migrate World City page listitems to the new 15.04 listitems.
Requested
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:271
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/654/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2878/console
Click here to trigger a rebuild:
Review: Needs Fixing
#blocked
This MP is blocked until,
- Jenkins moves to Vivid since we need QtQuick 2.4 and Ubuntu.Components 1.2
which is not available in utopic.
- AP tests needs to be updated similar to what has been done here [1]. However
I am unable to figure out how to fix it after
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11/+merge/252982
--
The proposal to merge lp:~dholbach/help-app/1456929 into lp:help-app has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~dholbach/help-app/1456929/+merge/260920
--
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.
--
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/202/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2876/console
FAILURE:
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10/+merge/252981
--
Your
The proposal to merge lp:~vthompson/music-app/now-playing-sections-toggle into
lp:music-app has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~vthompson/music-app/now-playing-sections-toggle/+merge/260948
--
Your team Music App
The proposal to merge lp:~popey/ubuntu-terminal-app/fix-1459437 into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/fix-1459437/+merge/260808
--
Your team Ubuntu Terminal Developers is
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/2-migrate-settings-page-listitems into
lp:ubuntu-clock-app with
lp:~nik90/ubuntu-clock-app/1-migrate-add-city-listitems as a prerequisite.
Commit message:
Migrated settings page listitems to the new 15.04 list items
The proposal to merge
lp:~nik90/ubuntu-clock-app/2-migrate-settings-page-listitems into
lp:ubuntu-clock-app has been updated.
Description changed to:
This MP implements the following,
- Migrate SubtitledListItem, Settings Page listitems to the new 15.04 ones
Note: No Visual Change
For more
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:272
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/655/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2880/console
Click here to trigger a rebuild:
The proposal to merge lp:~popey/ubuntu-terminal-app/fix-1459437 into
lp:ubuntu-terminal-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/fix-1459437/+merge/260808
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~ahayzen/music-app/capture-errors-for-currentMeta into
lp:music-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/capture-errors-for-currentMeta/+merge/261012
--
Your team Music App Developers
The proposal to merge lp:~ahayzen/music-app/capture-errors-for-currentMeta into
lp:music-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/capture-errors-for-currentMeta/+merge/261012
--
Your team Music App Developers is
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/3-migrate-alarm-listitems into lp:ubuntu-clock-app
with lp:~nik90/ubuntu-clock-app/2-migrate-settings-page-listitems as a
prerequisite.
Commit message:
- Transitions AlarmDelegate, AlarmList to using the new 15.04 ListItems
Michael Zanetti has proposed merging
lp:~mzanetti/reminders-app/store-local-resources-in-infofile into
lp:reminders-app.
Commit message:
Store locally attached resources into the info file
Requested reviews:
Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
Bug #1461622 in
41 matches
Mail list logo
