[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
The proposal to merge lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20 -- Your

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into lp:ubuntu-calendar-app

2015-08-02 Thread Gary.Wang
Done. Please review the latest MP. Thanks. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
I just wondering where is Jenkins :-) -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-revie

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
Review: Abstain -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
Review: Needs Fixing Great work. Let's wait with this feature push for UX comment. I think it will be good to discuss about possible solutions. -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
No problem. ;) -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
Thanks for approving. Can we merge it? :) -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-re

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
Review: Approve Works perfectly for me. Thanks. -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-core

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
The proposal to merge lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into lp:ubuntu-calculator-app has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621 -- Your team Ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Bartosz Kosiorek
Review: Disapprove Thanks for splitting this branch to two separate. I'm closing this branch, to not confuse developers. -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calcu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width into lp:ubuntu-terminal-app. Commit message: Allow triggering the layout enabled switch by clicking anywhere on the ListItem Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) For more

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app. Commit message: Update to the new UI Toolkit Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) Related bugs: Bug #1474114 in Ubuntu Terminal App: "Upgrade the Ubuntu C

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
Should be ready for merging now. :) -- https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app. -- Mailing list: http

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25 -- Your team Ubuntu Terminal Develo

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app has been updated. Description changed to: Update to the new UI Toolkit I decided not to switch to the new ListItem component this time as it does not seem to be ready yet. (Check out this thread: http

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app

2015-08-02 Thread Niklas Wenzel
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app. Commit message: Update to the new UI Toolkit Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) Related bugs: Bug #1474114 in Ubuntu Terminal App: "Upgrade the Ubuntu C

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
Hi, I'm sorry for the late reply. Thanks a lot for reviewing this. :) I have now split the MP as requested: 1) https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20 2) https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merg

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
The proposal to merge lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app has been updated. Description changed to: Fix physical delete and backspace keys, implement proper copy support for the desktop (This is one of two MPs resulting from splitting http

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app with lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix as a prerequisite. Commit message: Add proper paste support on the desktop Requested reviews: Ubuntu Calcula

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app

2015-08-02 Thread Niklas Wenzel
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into lp:ubuntu-calculator-app. Commit message: Fix physical delete and backspace keys, implement proper copy support for the desktop Requested reviews: Ubuntu Calculator Developers (ubuntu-calculato

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2015-08-02 Thread Mihir Soni
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990 -- Your team Ubuntu Calendar

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2015-08-02 Thread Mihir Soni
Review: Approve Looks good to me. Thanks Kunal. -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewer