Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:695
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1223/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/220/console
Click here to trigger a rebuild:
http://91.18
Got feedback from UX-design team that
"
This solution works nicely and I think we should proceed with it.
...
"
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-08 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-08/+merge/265199
--
Your
Review: Approve
Some comments to consider for fixing, but approving:
39: Spelling mistake: indexOfColonAndSlashe -> indexOfColonAndSlashes
42: Instead of hardcoding the location of startOf "://" in DiskRootUrl here
with midRef(0,5) it would be better to use a constant defined in LocationUrl,
o
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07/+merge/265198
--
Your
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07/+merge/265198
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Information
Comment on line 35.
Diff comments:
> === modified file 'src/plugin/folderlistmodel/filesystemaction.cpp'
> --- src/plugin/folderlistmodel/filesystemaction.cpp 2015-07-18 21:50:43
> +
> +++ src/plugin/folderlistmodel/filesystemaction.cpp 2015-07-18 21:50:44
> +
Blueprint changed by Andrew Hayzen:
Work items changed:
Work items:
[vthompson] Create bugs for #needs-autopilot-tests: DONE
[ahayzen] create initial AP framework: DONE
[vthompson] Look at clock app's location detection and start enabling in
weather: DONE
[vthompson] Create list of miss
The proposal to merge lp:~vthompson/music-app/fix-ap-instructions into
lp:music-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-ap-instructions/+merge/265218
--
Your team Music App Developers is subscribed to branch
Review: Approve
LGTM :-)
--
https://code.launchpad.net/~vthompson/music-app/fix-ap-instructions/+merge/265218
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewer
The proposal to merge lp:~vthompson/music-app/fix-ap-instructions into
lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-ap-instructions/+merge/265218
--
Your team Music App Developers is subscribed to
The proposal to merge lp:~vthompson/music-app/prototype-page-head-sections-3
into lp:music-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~vthompson/music-app/prototype-page-head-sections-3/+merge/266827
--
Your team Music Ap
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05/+merge/265196
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04/+merge/265195
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03/+merge/265194
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-02 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-02/+merge/265193
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05/+merge/265196
--
Your
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-05/+merge/265196
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04/+merge/265195
--
Your
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-04/+merge/265195
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03/+merge/265194
--
Your
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01/+merge/265192
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01/+merge/265192
--
Your
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-01/+merge/265192
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve continuous-integration
PASSED: Continuous integration, rev:347
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/721/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/66
Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubunt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:345
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/720/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/65
Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubunt
> I'm not sure if everyone will be on board with my latest small change. I made
> it so if the timer hasn't counted any time, that the clear/lap button isn't
> shown and only the Start button is shown. This is how my Android stopwatch
> (Google Clock) behaves. Please feel free to revert r342 if any
> Some more remarks:
> 1. With current implementation page swiping is not working any more.
Yes, that's intentional since the swipe-to-delete world city gesture is
conflicting with the page swiping gesture. I talked to Unity developers like
Michael Zanetti and agree that disabling that is the be
@Bartosz I addressed the inline comments in the latest commit. Fixed many of
them and explained the reasoning for the rest.
Diff comments:
>
> === added file 'app/MainPage.qml'
> --- app/MainPage.qml 1970-01-01 00:00:00 +
> +++ app/MainPage.qml 2015-08-06 00:59:41 +
> @@ -0,0 +1,82 @@
29 matches
Mail list logo
