Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/fix-1452499 into lp:ubuntu-weather-app/reboot.
Commit message:
* Create autopilot test which removes a single location
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
Bug #1452499 in Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:85
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/180/
Executed test runs:
SUCCESS:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/150
SUCCESS:
We should disable the utopic jenkins builder. It's causing this to fail
incorrectly.
--
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list:
The proposal to merge lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app
has been updated.
Status: Merged = Needs review
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
--
Your team Ubuntu Notes app developers is subscribed to branch
The proposal to merge lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
--
Your team Ubuntu Notes app developers is subscribed to branch
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-07/+merge/265198
--
Your team
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1460433_new into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1460433_new/+merge/262357
--
Your team Ubuntu
Review: Approve
Looks good!
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
--
Your team Ubuntu Calendar
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into
lp:ubuntu-calendar-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
--
Your team Ubuntu Calendar Developers
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09/+merge/265200
--
Your team
Review: Approve continuous-integration
PASSED: Continuous integration, rev:85
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/179/
Executed test runs:
SUCCESS:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/149
SUCCESS:
One thing to note is that when I make the following change, any value from the
slider results in VOLUME: 0
=== modified file 'app/alarm/AlarmSettingsPage.qml'
--- app/alarm/AlarmSettingsPage.qml 2015-07-29 19:35:00 +
+++ app/alarm/AlarmSettingsPage.qml 2015-08-07 22:35:02 +
@@
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/fix-1452498 into lp:ubuntu-weather-app/reboot.
Commit message:
* Create autopilot test which cancels adding a location
* Make the tests grab the top of the minimized tooltip to avoid resizing the app
Requested reviews:
Got feedback from UX-design team that
This solution works nicely and I think we should proceed with it.
...
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:695
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1223/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/220/console
Click here to trigger a rebuild:
** Changed in: ubuntu-themes
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1457424
The proposal to merge lp:~popey/ubuntu-terminal-app/add-authors into
lp:ubuntu-terminal-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-authors/+merge/263926
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~popey/ubuntu-terminal-app/add-authors into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-authors/+merge/263926
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
--
Your team Ubuntu Notes app developers is subscribed to
Blueprint changed by David Planella:
Work items changed:
Work items for 2015-07-02:
[bjoern-michaelsen] Investigate how the LOK-based gnome docviewer detects
page breaks: DONE
[bjoern-michaelsen] Study the API and report on capabilities that would be
applicable to the LO viewer:
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/457/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3151
deb:
The proposal to merge lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/uitk-1.3/+merge/265886
--
Your team Ubuntu Notes app developers is subscribed to
Public bug reported:
Hello,
When I click to show hidden files, it not working. Option is 'ticked',
but don't showing hidden files.
** Affects: ubuntu-filemanager-app
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
File
Review: Approve continuous-integration
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1460433_new/+merge/262357
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
The proposal to merge lp:~mzanetti/reminders-app/fix-label-wrapping into
lp:reminders-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-label-wrapping/+merge/265887
--
Your team Ubuntu Notes app developers is
Review: Needs Fixing
Some more inline remarks.
Diff comments:
=== added file 'app/stopwatch/LapListView.qml'
--- app/stopwatch/LapListView.qml 1970-01-01 00:00:00 +
+++ app/stopwatch/LapListView.qml 2015-08-06 15:24:30 +
@@ -0,0 +1,113 @@
+/*
+ * Copyright (C) 2015
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10/+merge/265209
--
Your
Answer from comment on line 35:
Yes, we can compare instances here because there will be just one instance for
each type: one for DiskLocation, one for TrashLocation and another for
SmbLocation. Locations are created by LocationsFactory creator class. See
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09/+merge/265200
--
Your
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06/+merge/265197
--
Your team
I'll get to them. Thank you for reviewing this one as well. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layouts-click-full-width/+merge/27
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-09/+merge/265200
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve
Thanks for the explanation, now it makes sense. I guess some clarification
would be helpful there for people not so familiar with the details.
I have three suggestions and you can decide whether to do one of them:
- Add a comment to explain it
- Use the type()
- Create
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-06/+merge/265197
--
Your
The proposal to merge lp:~mzanetti/reminders-app/fix-label-wrapping into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-label-wrapping/+merge/265887
--
Your team Ubuntu Notes app developers is
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-08 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-08/+merge/265199
--
Your team
Hello Ubuntu Core Apps Reviewers,
Sujeevan Vijayakumaran (svij) has been added as a member of Ubuntu
Weather Developers (ubuntu-weather-dev) by Alan Pope (popey). Follow
the link below for more details.
https://launchpad.net/~ubuntu-weather-dev/+member/svij
--
You received this email
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-10/+merge/265209
--
Your team
Bartosz Kosiorek has proposed merging
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-warning-fix into
lp:ubuntu-clock-app.
Commit message:
Silent warning which is displayed during clock run.
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
For more details, see:
The proposal to merge lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width
into lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layouts-click-full-width/+merge/27
--
Your team
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~nikwen/ubuntu-terminal-app/layout-i18n into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~nikwen/ubuntu-terminal-app/layout-i18n into
lp:ubuntu-terminal-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
--
Your team Ubuntu Terminal Developers is
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
--
Your team Ubuntu Terminal Developers is
Review: Approve continuous-integration
PASSED: Continuous integration, rev:322
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/722/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/67
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-terminal-app-autolanding/96/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/3149/console
FAILURE:
Review: Approve
This is great, thanks Niklas!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layouts-click-full-width/+merge/27
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
50 matches
Mail list logo
