Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Nekhelesh Ramananthan
Review: Needs Fixing performance regression The following code changes are not necessary. Let me explain the reasoning why, These code changes would add additional roles to *every* world city delegate in the c++ side and cost us performance. Instead, let's stick with the original code that retu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Nekhelesh Ramananthan
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezon

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Nekhelesh Ramananthan
Review: Needs Fixing manual testing + preliminary code review A couples of fixed needed, 1. In the Settings Page, the time & date are shown as undefined. 2. The alarm function breaks (like in trunk) when editing alarms. But I guess we can tackle this in more detail in the next MP. So that's fin

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

2015-09-17 Thread Alberto Mardegan
Thanks Michael for creating the MP. I didn't create it myself because this is still in a very early stage. However, I'm happy to have some feedback on it, especially about the future of the .deb version. Do you intend to keep it? The reason why I'm asking this, is because with the new Online Acc

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:411 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/847/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/192 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:409 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/845/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/190 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

2015-09-17 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:496 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~mardy/rem

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:410 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/846/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/191 Click here to trigger a rebuild: http://91.189.93.70:8080/job/ubun

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

2015-09-17 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mardy/reminders-app/new-api into lp:reminders-app. Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505 -- Your team Ubuntu Notes app developers is r

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Bartosz Kosiorek
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app has been updated. Commit Message changed to: * Fix wrong date and time after changing timezone while clock running (LP: #1447441) For more details, see: https://code.launchpa

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Bartosz Kosiorek
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app has been updated. Description changed to: * Fix wrong date and time after changing timezone while clock running (LP: #1447441) TODO: Test manually Daylight saving time changi

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app

2015-09-17 Thread Bartosz Kosiorek
Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-mainclock-runtime-timezone-fix into lp:ubuntu-clock-app. Commit message: * Fix wrong date and time after changing timezone while clock running (LP: #1447441) Requested reviews: Nekhelesh Ramananthan (nik90): preli

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-use-device-dpis into lp:ubuntu-docviewer-app/reboot

2015-09-17 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:174 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/22/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/22 Click here to trigger a rebuild: http://91.18

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mode into lp:ubuntu-rssreader-app/reboot

2015-09-17 Thread Roman Shchekin
Merged manually) -- https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mode/+merge/271254 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mode into lp:ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mode into lp:ubuntu-rssreader-app/reboot

2015-09-17 Thread noreply
The proposal to merge lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mode into lp:ubuntu-rssreader-app/reboot has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-reboot-night-mo