Review: Approve continuous-integration
PASSED: Continuous integration, rev:902
http://91.189.93.70:8080/job/music-app-ci/1393/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/245
Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1393
I'll update the popups, but leave the list items to be updated.
--
https://code.launchpad.net/~vthompson/music-app/music-uc1.3/+merge/267889
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Abstain
I'm abstainig from this after all, see my reasoning on the counter-proposal:
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179/comments/695921
--
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177
Your team U
Review: Abstain
> It wouldn't be, they'd be the same. I just don't believe it should be the
> general video or music roles, which one of those will end up being the
> default role to be equivalent to the old multimedia role.
Well, so that's the thing - today the role is set to "alert". While I ag
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:322
https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/16/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/52/console
Click here to trigger a rebuild:
https://core-app
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:427
https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/15/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/51/console
Click here to trigger a rebuild:
https://core-app
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:478
https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/14/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/50/console
Click here to trigger a rebuild:
https://core-app
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:708
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/8/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/49/console
Click here to trigger a rebuild:
https://core-apps-je
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:194
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/6/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/48/console
Click here to trigger a rebuild:
https://core-apps-
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:210
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/5/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/46/console
Click here to trigger a rebuild:
https://core-apps-
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:707
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/7/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/47/console
Click here to trigger a rebuild:
https://core-apps-je
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:710
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/6/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/45/console
Click here to trigger a rebuild:
https://core-apps-je
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:712
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/5/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/43/console
Click here to trigger a rebuild:
https://core-apps-je
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:230
https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/4/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/44/console
Click here to trigger a rebuild:
https://core-apps-
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:719
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/4/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/42/console
Click here to trigger a rebuild:
https://core-apps-je
On Thu, Oct 22, 2015 at 4:12 PM, Michał Sawicz
wrote:
> W dniu 22.10.2015 o 21:37, Jim Hodapp pisze:
> > I agree, but we are discussing only the alarm preview in this MR. Unless
> the actual alarm uses the same audio role as the preview does?
>
> No, but why would this be alert role, while the re
** Changed in: music-app
Assignee: (unassigned) => Victor Thompson (vthompson)
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bu
W dniu 22.10.2015 o 21:37, Jim Hodapp pisze:
> I agree, but we are discussing only the alarm preview in this MR. Unless the
> actual alarm uses the same audio role as the preview does?
No, but why would this be alert role, while the real alarm would be
alarm role?
--
https://code.launchpad.net
** Also affects: ubuntu-rssreader-app
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs
> W dniu 22.10.2015 o 14:52, Jim Hodapp pisze:
> > Review: Needs Information
> >
> > I would like to better understand why you're dropping the role completely
> instead of moving to the NotificationRole? As it stands right now, it'll use
> the old MultimediaRole at the media-hub and PulseAudio laye
Number 2. sounds like a lower priority reminder than an alarm, and there's
other apps for that (Notes/Reminders, Calendar). Unless you want it to play
regardless of Silent mode? In any case, that's two, probably recurring daily,
alarms. You don't reset them multiple times a day, not even a week,
@Bartosz, Listitems are in a separate branch [0] which we will land at the same
time, same story for weather.
Also as a note I'm trying to sort out header.height issues in that branch as
well, so this should not land in trunk until the listitems one is ready.
0 -
https://code.launchpad.net/~ah
Review: Needs Fixing
Some inline comments
Diff comments:
>
> === modified file 'app/components/BlurredHeader.qml'
> --- app/components/BlurredHeader.qml 2015-05-03 16:22:31 +
> +++ app/components/BlurredHeader.qml 2015-10-21 00:09:41 +
> @@ -17,7 +17,7 @@
> */
>
> import QtQuick
We will need to bump to uc1.3 for this as well, I'll make a branch that this
can rebase onto.
--
https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration/+merge/266981
Your team Ubuntu Weather Developers is subscribed to branch
lp:~ubuntu-weather-dev/ubu
I have two types of alarms:
1. Wake up alarms - to wake up early morning
2. Daily Standup alarms - to remind me that I have an meeting every weekday.
--
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
Your team Ubuntu Clock Developers is subscribed to branch lp:u
Andrew Hayzen has proposed merging
lp:~ahayzen/ubuntu-weather-app/fix-link-windspeed-to-windunits-not-tempunits
into lp:ubuntu-weather-app/reboot.
Commit message:
* Fix to link the Wind Speed unit to the Wind Unit setting and not the
Temperature Unit setting
Requested reviews:
Ubuntu Weather
W dniu 22.10.2015 o 14:52, Jim Hodapp pisze:
> Review: Needs Information
>
> I would like to better understand why you're dropping the role completely
> instead of moving to the NotificationRole? As it stands right now, it'll use
> the old MultimediaRole at the media-hub and PulseAudio layer. So
Review: Needs Fixing
Diff comments:
>
> === added file 'app/components/AlarmAudio.qml'
> --- app/components/AlarmAudio.qml 1970-01-01 00:00:00 +
> +++ app/components/AlarmAudio.qml 2015-10-22 10:43:07 +
> @@ -0,0 +1,35 @@
> +import QtQuick 2.4
> +
> +Item {
> +id: root
> +
Review: Needs Information
For me it even better, to pause current music and play preview alarm. It will
let me, better adjust the volume of the alarm.
I would like to pause audiobook, when alarm starts ringing. I will not miss
anything from my audiobook. It will be annoying for me to rewind aud
Andrew Hayzen has proposed merging
lp:~ahayzen/ubuntu-weather-app/fix-ap-tests-001 into
lp:ubuntu-weather-app/reboot.
Commit message:
* Fix for autopilot tests not using custom back button
* Fix for possible flaky test due to expandHeight changing dynamically
* Fix for null errors as header is u
Review: Needs Information
I would like to better understand why you're dropping the role completely
instead of moving to the NotificationRole? As it stands right now, it'll use
the old MultimediaRole at the media-hub and PulseAudio layer. So if you have
music playing in music-app and then you g
Review: Disapprove
@Bartosz, it's likely related to bug #1485522, and also the fact that
indicator-datetime, AFAIK, sets the volume to the one set in the clock app when
playing an alarm sound.
In any case, I vote for the competing approach for now - until we clear the
whole volume situation up
Review: Approve
Yeah, agreed, we don't get much out of the competing solution.
--
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touc
The proposal to merge lp:~mzanetti/ubuntu-clock-app/drop-audioRole into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
drop alarm preview's audioRole
This doesn't really work as expected anyways and would cause issues
with an upcoming API change after upstreaming the roles pat
Thanks Bartosz. I've added a more explicit hint to Qt 5.5 to the commit message.
--
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-tou
Review: Approve
--
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-revie
Review: Needs Information
@Michael
I would like to clarify, that volume preview is working perfectly on Desktop,
unfortunately it is not working on Phone.
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
This is very strange issue. Unfortunately these
Review: Needs Information
I would vote for that solution, as it is simple and the results are the same as
with:
https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177
I would add comment that "audioRole" was removed to keep compatibility with Qt
5.5
--
https://
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:403
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/11/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/41/console
Click here to trigger a rebuild:
https://core-apps-jenk
fixed the inline comment.
For me, the volume controls during preview were working fine. Probably the
issue was because before it was using the "alert" role, which seems to be wrong
in any case.
As written in the description, I'm not really sure if we should merge this
branch, or instead just
Review: Needs Information
I tested it and it is working correctly for me on BQ E4.5 device.
It is nice improvement especially for QT 5.5 upgrade
One inline question below.
Do you think it could help in missing volume changes, during alarm preview?:
https://code.launchpad.net/~gang65/ubuntu-clock
41 matches
Mail list logo
