Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1236/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/233 Click here to trigger a rebuild: http://91.189.93.70:8080/j

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1235/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/232 Click here to trigger a rebuild: http://91.189.93.70:8080/j

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/12/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/71/console Click here to trigger a rebuild: https://core-apps-jenkin

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/11/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/70/console Click here to trigger a rebuild: https://core-apps-jenkin

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1234/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/231 Click here to trigger a rebuild: http://91.189.93.70:8080/j

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:718 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/10/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/69/console Click here to trigger a rebuild: https://core-apps-jenkin

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread noreply
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-use-sdk-listitems into lp:music-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:885 http://91.189.93.70:8080/job/music-app-ci/1400/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/252 Click here to trigger a rebuild: http://91.189.93.70:8080/job/music-app-ci/1400

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread noreply
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread noreply
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Nicholas Skaggs
I'll note, I only disabled the autolanding job, so it will still try and build. you can ignore any failures. Top approving will allow it to land. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File Manager Developers is su

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Nicholas Skaggs
Blast that libsmbclient . . . I'll keep working on it guys! In the interim, I've disabled builds so you can land using the old bot. hopefully tomorrow will find success. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/275164 Your team Ubuntu File

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Nicholas Skaggs
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/27516

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app

2015-10-27 Thread Nicholas Skaggs
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~mzanetti/ubuntu-clock-app/detect-qtmm-version/+merge/275177 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: http

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app

2015-10-27 Thread Nicholas Skaggs
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes/+merge/275625 Your team Ubuntu Shorts Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rs

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app

2015-10-27 Thread Nicholas Skaggs
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefView/+merge/274062 Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubunt

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app

2015-10-27 Thread Nicholas Skaggs
Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner. -- https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade/+merge/274958 Your team Ubuntu Calculator Developers is requested to review the proposed merg

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-10-27 Thread noreply
The proposal to merge lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 -- Your team Ubuntu Cal

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewe

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-10-27 Thread Bartosz Kosiorek
The proposal to merge lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 -- Your team Ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into lp:ubuntu-calculator-app

2015-10-27 Thread Bartosz Kosiorek
Review: Approve -- https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merge/22 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/2/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5/console -- https://code.lau

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/27516

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:411 https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/68/console Click here to trigger a rebuild: https://core-apps-jenkins.u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-rssreader-app/uitk13-few-fixes into lp:ubuntu-rssreader-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:411 https://core-apps-jenkins.ubuntu.com/job/shorts-app-ci/6/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/67/console Click here to trigger a rebuild: https://core-apps-jenkins.u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:404 https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/14/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/66/console Click here to trigger a rebuild: https://core-apps-jenkins.u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into lp:ubuntu-calculator-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:230 https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/65/console Click here to trigger a rebuild: https://core-apps-jenki

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Nicholas Skaggs
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/27516

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:719 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/9/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/64/console Click here to trigger a rebuild: https://core-apps-jenkins

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app

2015-10-27 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:403 https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/13/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/62/console Click here to trigger a rebuild: https://core-apps-jenkins.u

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app

2015-10-27 Thread Bartosz Kosiorek
Bartosz Kosiorek has proposed merging lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix into lp:ubuntu-clock-app. Commit message: Fix alarm difference time description, during DST change (LP: #1510694) Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/275832 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07/+merge/27583

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/27583

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
Review: Approve -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06/+merge/275831 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/1/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/4/console -- https://code.lau

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/27516

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05/+merge/27516

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-27 Thread Arto Jalkanen
Review: Approve getStat()'s return value is always casted to StatReturn, so it would seem to me that it'd be better to have getStat() rturn always StatReturn so that the casting would be in one place and not dispersed around code. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanag

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app

2015-10-27 Thread Andrew Hayzen
Andrew Hayzen has proposed merging lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app. Commit message: * Add support for media-hub background playlists Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1251624 in Ubuntu Music App: "back butto

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app

2015-10-27 Thread Andrew Hayzen
The proposal to merge lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912 -- Your team Mu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:196 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/53/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/53/console Click here to trigger a rebuild:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:195 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/52/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/52/console Click here to trigger a rebuild:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Stefano Verzegnassi
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refa

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Stefano Verzegnassi
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-cmake-refactor into lp:ubuntu-docviewer-app/reboot with lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps as a prerequisite. Commit message: * Changes to the project structure * Provide DocVie

[Ubuntu-touch-coreapps-reviewers] [Bug 1510211] Re: Phone app shows all number types under "recent" as "Mobile"

2015-10-27 Thread Claudia Wilhelmy
** Changed in: ubuntu-filemanager-app Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/15

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into lp:ubuntu-weather-app

2015-10-27 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:79 https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/7/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/61/console Click here to trigger a rebuild: https://core-apps-jenk

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Zsombor Egri
Victor, You are right, there is one header per application. Which means that all pages in an application use that header. However that would be broken when you'd use the AdaptivePageLayout, which has as many headers as columns. Therefore we are preparing to move the header in the page, so each pag

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:179 http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-ci/51/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-docviewer-app-reboot-vivid-amd64-ci/51 Click here to trigger a rebuild: http://91.18

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into lp:ubuntu-docviewer-app/reboot

2015-10-27 Thread Stefano Verzegnassi
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/get-click-deps into lp:ubuntu-docviewer-app/reboot. Commit message: Automatically fetch dependencies for LibreOffice viewer and put them inside the .click package. Requested reviews: Alan Pope  (popey) Fo

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Victor Thompson
Zsombor, Functionally, there already is a header, so why should a developer need to define one explicitly? Won't explicitly defining one override the already visible header? What I'm asking for is simply a means of ascertaining the current header's height. I believe the inability to do so, curren

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:480 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/565/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/187 Click here to trigger a rebuild: http://91.189.93.70:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:479 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/566/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/188 Click here to trigger a rebuild: http://91.189.93.70:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:480 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/18/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/58/console Click here to trigger a rebuild: https://core-app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 as a prerequisite. Commit message: improved SmbUtil::findSmBServer() Requested reviews:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:479 https://core-apps-jenkins.ubuntu.com/job/filemanager-app-ci/17/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/57/console Click here to trigger a rebuild: https://core-app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a prerequisite. Commit message: some cleanup in SmbItemInfo::setInfo(), work around fo

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Zsombor Egri
Victor and others, in order to get the header height you need to set the Page.header first. Page.header is null by default, so no wonder you cannot get the height. You can do something like Page { header: PageHeader { } } Then you will have the header set and you can use that to get the

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-system-settings - 0.3+16.04.20151023.1-0ubuntu1 --- ubuntu-system-settings (0.3+16.04.20151023.1-0ubuntu1) xenial; urgency=medium [ CI Train Bot ] * New rebuild forced. [ Ken VanDine ] * Bump Ubuntu.Components imports to 1.3 and fixed

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Andrea Bernabei
@Saviq: my question still stands :) -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UI