[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-11-23 Thread Alan Pope 
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 -- Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2015-11-23 Thread Alan Pope 
Review: Approve LGTM. Thanks Gary! -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread Alan Pope 
Review: Needs Fixing This is looking great. One thing I noticed though is the zoom dropdown is always fixed on "Automatic (Fit width)" even if you choose another zoom level, or zoom in or out with the buttons. This means if you change the zoom level, you can never re-choose "Fit Width)

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread Stefano Verzegnassi
> One thing I noticed though is the zoom dropdown is always fixed on "Automatic > (Fit width)" even if you choose another zoom level, or zoom in or out with the > buttons. This means if you change the zoom level, you can never re-choose "Fit > Width) because it thinks it's already ticked.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread Stefano Verzegnassi
Anyway, and that's for sure, the work on zooming is not completed by this MP. We still have three relevant things to do: 1) Add the double-tap-to-(un)zoom gesture. 2) Properly define the zoom behaviour (minimum zoom, maximum zoom, default value) for the following three form factors: -

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-11-23 Thread noreply
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 -- Your team Ubuntu Calendar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2015-11-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app with lp:~gary-wzl77/ubuntu-calendar-app/show-week-number as a prerequisite. Commit message: Add lunar calendar support Requested reviews: Yuan-Chen Cheng (ycheng-twn)

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app

2015-11-23 Thread Alan Pope 
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app

2015-11-23 Thread Alan Pope 
Review: Approve LGTM -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2/+merge/278260 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app

2015-11-23 Thread noreply
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-error-detection-pt2 into lp:ubuntu-docviewer-app has been updated. Status: Approved => Merged For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Jenkins Bot
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012 -- Your team Ubuntu Calculator

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/calculator-app-autolanding/89/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/407/console --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Bartosz Kosiorek
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012 -- Your team Ubuntu Calculator

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Bartosz Kosiorek
Review: Needs Fixing There are same conflicts. Please resolve them. After that just top approve that. -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread Stefano Verzegnassi
The proposal to merge lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread noreply
The proposal to merge lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final/+merge/278248 --

[Ubuntu-touch-coreapps-reviewers] [Bug 1519058] [NEW] See all kinds of files

2015-11-23 Thread Cesar
Public bug reported: You open the File Manager app and click on a file. What happens: If the File Manager doesn't know how to show you this file it says it can't use it. What should happen: It should let you to choose between every app that open this kind of file. ** Affects:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into lp:ubuntu-docviewer-app

2015-11-23 Thread Alan Pope 
Review: Approve Great! Looks good so far! -- https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final/+merge/278248 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Bartosz Kosiorek
Review: Approve Hello Riccardo. Could you please submit bug report for that issue? It will be great to resolve it upstream. -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012 Your team Ubuntu Calculator Developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Jenkins Bot
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012 -- Your team Ubuntu Calculator

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app

2015-11-23 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/calculator-app-autolanding/88/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/405/console --