Andrew Hayzen has proposed merging
lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into
lp:~music-app-dev/music-app/media-hub-bg-playlists-rework.
Commit message:
* Bump QtMultimedia import to 5.6 and remove unused ones
Requested reviews:
Jim Hodapp (jhodapp)
Music App Developers
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/add-non-google-support
into lp:ubuntu-rssreader-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/add-non-google-support/+merge/280614
--
Your team
The proposal to merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
--
Your team Ubuntu
The proposal to merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
--
Your team Ubuntu Document
Review: Approve continuous-integration
--
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
I didn't make any changes to the .db files. All I did was change the
schemaVersion in the .sql files to 10. I tried converting those .sql files
to .db files but I got some errors and when I told Nicholas he said that I
don't need to do that, and that I should leave the .db files as they are.
Review: Approve
LGTM. Good job, thanks!
--
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
Review: Approve continuous-integration
--
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
--
Your team Music App Developers is subscribed to branch
Review: Needs Fixing
Vamshi,
It seems that the test you added is failing: http://paste.ubuntu.com/14134202/
Should "get_LibraryEmptyState" actually be "get_library_empty_state_page" or
something else perhaps?
--
Girish has proposed merging lp:~emailgirishrawat/ubuntu-calculator-app/READMEs
into lp:ubuntu-calculator-app.
Commit message:
Updated and extended READMEs.
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
Review: Approve
LGTM! Thanks! Don't forget to add a commit message.
--
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
Review: Needs Fixing
LGTM, just one comment
1) Could you update the design doc link, as you did with weather?
Diff comments:
>
> === added file 'README.md'
> --- README.md 1970-01-01 00:00:00 +
> +++ README.md 2015-12-18 17:05:23 +
> @@ -0,0 +1,25 @@
> +ReadMe - Ubuntu Music App
>
Review: Approve
LGTM, thanks for the changes :-)
--
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app
has been updated.
Commit Message changed to:
Expanded and updated READMEs.
For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
--
Your team Music App Developers is
The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app
has been updated.
Commit Message changed to:
Updated design section in README.md
For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
--
Your team Music App Developers
leave a comment for Kunal's suggestion.
Diff comments:
>
> === modified file 'TimeLineBase.qml'
> --- TimeLineBase.qml 2015-08-20 12:27:59 +
> +++ TimeLineBase.qml 2015-11-27 01:49:25 +
> @@ -221,28 +221,27 @@
> if (event.endDateTime - day == 0)
> return;
>
>
The proposal to merge lp:~qqworini/ubuntu-rssreader-app/add-non-google-support
into lp:ubuntu-rssreader-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~qqworini/ubuntu-rssreader-app/add-non-google-support/+merge/280614
--
Your team Ubuntu
The proposal to merge lp:~emailgirishrawat/music-app/READMEs into lp:music-app
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
--
Your team Music App Developers is subscribed to branch
The proposal to merge lp:~vamrocks602/music-app/test-empty-library into
lp:music-app has been updated.
Commit Message changed to:
* Add test to make sure that the LibraryEmptyState page is visible when no
music is detected on the device.
For more details, see:
The error is "Could not initialise media store: Tried to open a db with schema
version 9, while supported version is 10."
bzr thinks that the mediastore.db has been modified, so what changes have been
made to that?
=== modified file
Fixed.
--
https://code.launchpad.net/~emailgirishrawat/ubuntu-docviewer-app/READMEs/+merge/281013
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Fixing
Hi,
Thanks for this big improvement!
I had a look at your MP and overall it looks very good.
However, some minor change is required in order to reflect the current status
of the project.
* Some of the Autopilot tests are currently broken.
It may be worth to point that
23 matches
Mail list logo
