Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2015-12-22 Thread Ethan Chang
Verified with com.ubuntu.calendar 0.4. The lunar calendar works well on Arale and also compared result with baidu lunar calendar. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 Your team Ubuntu Calendar Developers is subscribed to branch lp:u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Victor Thompson
Thanks Vamshi. We still need input/verification on the device tests. I won't have the time to help you with this in the near term. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Maili

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Vamshi Balanaga
I fixed the method name, and resolved the conflict. Vamshi Balanaga On Tue, Dec 22, 2015 at 8:09 PM, Victor Thompson wrote: > Review: Needs Fixing > > Lastly, when I run this on the device I get the "No music found" page > consistently. I imagine there might be something in the change to how we

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-filemanager-app/READMEs into lp:ubuntu-filemanager-app

2015-12-22 Thread Girish
Arto: Have added a commit message. CAn you approve this again? -- https://code.launchpad.net/~emailgirishrawat/ubuntu-filemanager-app/READMEs/+merge/281007 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Victor Thompson
Review: Needs Fixing Lastly, when I run this on the device I get the "No music found" page consistently. I imagine there might be something in the change to how we do mocking that might have caused it. ahazyen, balloons: Can you guys work with Vamshi to fix this issue? -- https://code.launchpa

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Victor Thompson
Also, you'll need to resolve the merge conflict in the debian/changelog file. We get such conflicts frequently as multiple people work to propose merges. To fix, do the following: $ bzr merge lp:music-app Then, fix the conflict in the debian/changelog and save it. Then run: $ bzr resolve debia

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Victor Thompson
Review: Needs Fixing Vamshi, The test still does not work. Here's the log output--I believe you need to ad "_page" to the method call. test-log: {{{ 18:34:56.811 INFO logging:45 - TestEmptyLibrary: launch_test_local. Arguments (). Keyword arguments: {}. 18:34:56.811 WARNING base:52 - This func

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread noreply
The proposal to merge lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174 -- Your team Ubuntu Calculator

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers P

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread Bartosz Kosiorek
The proposal to merge lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174 -- Your team Ubuntu Calcu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread Bartosz Kosiorek
Review: Approve -- https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-tou

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/media-hub-bg-playlists-rework-qt-56 into lp:~music-app-dev/music-app/media-hub-bg-playlists-rework

2015-12-22 Thread Jim Hodapp
Review: Approve code Looks good and functions well. Will top approve once Timo lands the changes exporting the Playlist and PlaylistItem stuff into the archive from silo 58. https://requests.ci-train.ubuntu.com/#/ticket/812 -- https://code.launchpad.net/~ahayzen/music-app/media-hub-bg-playlists

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app

2015-12-22 Thread Joey Chan
Review: Approve I'm OK with this MR -- https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Your team Ubuntu Shorts Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app

2015-12-22 Thread Joey Chan
The proposal to merge lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app has been updated. Commit Message changed to: Add readme's for Google Code In task. For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 -- Your tea

[Ubuntu-touch-coreapps-reviewers] [Bug 1528604] [NEW] Unable to select several files or folders

2015-12-22 Thread Alexandre Payet
Public bug reported: In file app it's not possible to select some files/folders in a folder. Example : If you want to move some pictures of a folder to an other one, you need to do the cut / paste file by file. The is no selection mode like in gallery or dekko app ** Affects: ubuntu-filemanager-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vamrocks602/music-app/test-empty-library into lp:music-app

2015-12-22 Thread Vamshi Balanaga
I apologize for that, I thought that I changed that. It's done now, just pushed. -- https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreap

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app

2015-12-22 Thread Aditya
Aditya has proposed merging lp:~dtrg21/ubuntu-rssreader-app/add-readmes into lp:ubuntu-rssreader-app. Requested reviews: Nicholas Skaggs (nskaggs): google code in For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-rssreader-app/add-readmes/+merge/281191 Add readme's for Google C

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread Girish
Bartosz Kosiorek : Fixed. :) -- https://code.launchpad.net/~emailgirishrawat/ubuntu-calculator-app/READMEs/+merge/281174 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time into lp:ubuntu-calculator-app

2015-12-22 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:255 https://core-apps-jenkins.ubuntu.com/job/calculator-app-ci/41/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/270/console Click here to trigger a rebuild: https://core-apps-jen

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time into lp:ubuntu-calculator-app

2015-12-22 Thread Bartosz Kosiorek
Bartosz Kosiorek has proposed merging lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-decrease-startup-time into lp:ubuntu-calculator-app. Commit message: Decrease Calculator's startup time (LP: #1520554) Requested reviews: Ubuntu Calculator Developers (ubuntu-calculator

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~emailgirishrawat/ubuntu-calculator-app/READMEs into lp:ubuntu-calculator-app

2015-12-22 Thread Bartosz Kosiorek
Review: Needs Fixing It is very nice improvement. I have added some small inline comments. Thanks! Diff comments: > > === added file 'README-Autopilot.md' > --- README-Autopilot.md 1970-01-01 00:00:00 + > +++ README-Autopilot.md 2015-12-22 06:35:00 + > @@ -0,0 +1,79 @@ > +R