[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app

2016-01-12 Thread Evan McIntire
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS F

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-je

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/28/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1429/console -- https://code.la

[Ubuntu-touch-coreapps-reviewers] [Bug 1533383] Re: undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version

2016-01-12 Thread Raimundo C M Leite
thanks in advance, looking for .click old version one -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1533383 Title:

[Ubuntu-touch-coreapps-reviewers] [Bug 1533383] [NEW] undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version

2016-01-12 Thread Raimundo C M Leite
Public bug reported: filemanager_0.4.501 isn't working on nexus 4(mako) S.O. Ubuntu 14.10(r226) ** Affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribe

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-tests-for-portrait-view into lp:ubuntu-calculator-app

2016-01-12 Thread Nicholas Skaggs
Review: Needs Fixing all the failures I see seem correct. I run the test by hand and it doesn't work as the test says it should. Are you sure the functionality is correct? run3:10: FAIL: ubuntu_calculator_app.tests.test_main.MainTestCase.test_adding_comma_without_number_on_temp_result run3:44:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 -- Your team Ubuntu Calendar

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/27/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1428/console -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/calendar-app-autolanding/12/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1427/console -- https://code.la

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubun

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406 -- Your team Ubuntu Calendar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/26/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1426/console -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/Uitk1_3 into lp:ubuntu-calendar-app

2016-01-12 Thread Alan Pope 
Review: Needs Fixing It still overlaps on long month names. I think we need to switch to the short version of the month name so they fit, or perhaps use a smaller font. http://people.canonical.com/~alan/screenshots/device-2016-01-12-205023.png -- https://code.launchpad.net/~pkunal-parmar/ubunt

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Commit Message changed to: Fix missing commit message. For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubun

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/25/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1425/console -- https://code.la

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Nicholas Skaggs
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/24/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1424/console -- https://code.la

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:623 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/90/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/357/console Click here to trigger a rebuild: https://core-apps-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app

2016-01-12 Thread Kunal Parmar
Review: Needs Information added inline comment Diff comments: > > === modified file 'MonthComponentDateDelegate.qml' > --- MonthComponentDateDelegate.qml2015-09-05 05:30:23 + > +++ MonthComponentDateDelegate.qml2016-01-12 18:02:54 + > @@ -9,20 +9,21 @@ > property bool isTod

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Nicholas Skaggs
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/23/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1423/console -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:623 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/89/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/356/console Click here to trigger a rebuild: https://core-apps-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app

2016-01-12 Thread Renato Araujo Oliveira Filho
Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-calendar-app/optimize into lp:ubuntu-calendar-app. Commit message: Optimize MonthComponent Requested reviews: Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-integration Ubuntu Calendar Develo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun. https://code.launchpad.net/~mcintire-eva

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ub

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 -- Your team Ub

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
Review: Approve Great! Thanks Evan. -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Pos

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun. https://code.launchpad.net/~mcintire-eva

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461 -- Your team Ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

2016-01-12 Thread Stefano Verzegnassi
Replaced ListView with Column+Repeater, in order to delay things a bit. New example: http://paste.ubuntu.com/14479638/ That's the result: https://www.youtube.com/watch?v=CSM62wu8fiY It seems that the issue lives in the UCPageTreeNode component (used by UITK Page) - just my speculation. Replaci

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

2016-01-12 Thread Stefano Verzegnassi
It doesn't seem to be related to something we've done in DocViewer. I wrote a minimal code which reproduces the issue, and there's nothing strange with the ListView usage (the rest of the code comes from the official examples). A first workaround I found is making the ListView not visible as long

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

2016-01-12 Thread Stefano Verzegnassi
On it! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

2016-01-12 Thread Roman Shchekin
Hi, Alan, I've seen video - yes, I can see flickering, we should find out is it SDK bug or ours! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge/+merge/281860 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/uitk-bottom-edge into lp:ubuntu-docviewer-app

2016-01-12 Thread Alan Pope 
Review: Needs Fixing Works well, but I noticed a strange flickering of the content appearing on screen. I made a video showing it which should be available shortly. Not sure if this is a toolkit bug (likely)? https://www.youtube.com/watch?v=2KSWIlJ0Y5c -- https://code.launchpad.net/~verzegnas

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app

2016-01-12 Thread Alan Pope 
Review: Approve Loving this change. It's quite a difference not having the stark blacks. Thanks! -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/night-shader/+merge/282041 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Ma

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app

2016-01-12 Thread Stefano Verzegnassi
It seems to me an HIDPI issue. The only math involved is a conversion from TWIPs to pixels, based on the value of the pixel density of the screen. Except for some rounding issue, but DocViewer should return the same size (in cm or inches) for the same object, as in this picture: https://imgur

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app

2016-01-12 Thread Alan Pope 
Review: Needs Fixing Confirmed with a community member that the MX4 also has the "zoomed out" look. As that's a supported device, I think we should improve that. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ub

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app

2016-01-12 Thread Alan Pope 
(I should add, I quite like the zoomed in level. While the text is very large, it loads fast, and is easy enough to scroll around / zoom in/out). -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom/+merge/281385 Your team Ubuntu Document Vie

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app

2016-01-12 Thread Alan Pope 
Tested on bq e4.5:- http://people.canonical.com/~alan/screenshots/device-2016-01-12-133308.png Tested on OnePlus One:- http://people.canonical.com/~alan/screenshots/device-2016-01-12-133734.png So it looks like we're detecting the screen size / resolution and automatic zoom on larger resolutio

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/lok-new-zoom-modes+spreadsheet-zoom into lp:ubuntu-docviewer-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:254 https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/64/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/355/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app

2016-01-12 Thread Andrew Hayzen
OK, fixed the positionAt issue, if we land trunk into the store before bgplaylists we should include this patch [0] 0 - http://bazaar.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/revision/931 -- https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-r

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~music-app-dev/music-app/media-hub-bg-playlists-rework into lp:music-app

2016-01-12 Thread Andrew Hayzen
1) Is there a reason this length of time was chosen? 48ms is the maximum possible time we can wait without being noticeable to the user (less than 50ms) that is still divisible by 16ms. (note that this worked when set to 16ms on mako to me, I just wanted to give extra time to slower devices) 2

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:148 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~popey/ubu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app

2016-01-12 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:147 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself): https://code.launchpad.net/~popey/ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app

2016-01-12 Thread Alan Pope 
Alan Pope  has proposed merging lp:~popey/ubuntu-terminal-app/add-control into lp:ubuntu-terminal-app. Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Victor Thompson (vthompson) For more details, see: https://code.launchpad.net/~popey/ubuntu-terminal-a