Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-app-welcome-wizard into lp:ubuntu-calculator-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:193 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/115/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/389/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app

2016-01-14 Thread Bartosz Kosiorek
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app has been updated. Description changed to: Fix race condition, which cause wrong alarm caption (LP: #153) For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app/ub

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app

2016-01-14 Thread Bartosz Kosiorek
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app has been updated. Commit Message changed to: Fix race condition, which cause wrong alarm caption (LP: #153) For more details, see: https://code.launchpad.net/~gang65/ubuntu-clock-app

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:436 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/114/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/388/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:261 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/113/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/387/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Alan Pope 
Review: Approve LGTM -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml/+merge/282674 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:262 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/112/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/386/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app. Commit message: added python3-lxml package as dependency Requested reviews: Ubuntu Document Viewer Developers (ubuntu-docviewer-dev) For more details, see: https://

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:261 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/111/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/385/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
Stefano Verzegnassi has proposed merging lp:~verzegnassi-stefano/ubuntu-docviewer-app/python-lxml into lp:ubuntu-docviewer-app. Commit message: added python-lxml as dependency Requested reviews: Ubuntu Document Viewer Developers (ubuntu-docviewer-dev) For more details, see: https://code.laun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:261 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/110/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/384/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:264 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/109/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/383/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:514 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/108/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/382/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Bug 1533383] Re: undefined symbol lookup error: _ZN6QDebugD1Ev on filemanager_0.4.501 version

2016-01-14 Thread Raimundo C M Leite
** Changed in: ubuntu-filemanager-app Status: New => Invalid ** Converted to question: https://answers.launchpad.net/ubuntu-filemanager-app/+question/280994 -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu F

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dtrg21/ubuntu-docviewer-app/add-readmes into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
The proposal to merge lp:~dtrg21/ubuntu-docviewer-app/add-readmes into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~dtrg21/ubuntu-docviewer-app/add-readmes/+merge/281340 -- Your team Ubuntu Document Viewer Deve

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache into lp:ubuntu-docviewer-app

2016-01-14 Thread Roman Shchekin
Roman Shchekin has proposed merging lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-lib-cache into lp:ubuntu-docviewer-app. Commit message: Upstream libs caching. Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Ubuntu Document Viewer Developers (u

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge/280388 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-c

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-je

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. Unapproved changes made after approval. https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/22/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1444/console -- https://code.la

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread noreply
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/28038

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge/280387 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-c

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread noreply
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubuntu Fi

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-fil

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Nicholas Skaggs
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Nicholas Skaggs
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/38/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1441/console -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot. https://core-apps-je

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 Your team Ubuntu File Manager Developers is requested to review the proposed merge of lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-fil

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/filemanager-app-autolanding/18/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1439/console -- https://code

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Nicholas Skaggs
The proposal to merge lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames/+merge/282628 -- Your team Ubu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:514 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/107/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/381/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:243 https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/71/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/380/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/desktop-support into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:241 https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/70/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/379/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:260 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/106/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/378/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:418 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/105/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/377/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/night-shader/+merge/282041 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/37/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1438/console -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:264 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/104/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/376/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app

2016-01-14 Thread Nicholas Skaggs
Nicholas Skaggs has proposed merging lp:~nskaggs/ubuntu-filemanager-app/fix-ap-item-renames into lp:ubuntu-filemanager-app. Commit message: Fix autopilot tests in trunk -- UI element types changed slightly. Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/night-shader into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/night-shader/+merge/282041 -- Your team

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app

2016-01-14 Thread Joey Chan
Joey Chan has proposed merging lp:~qqworini/ubuntu-rssreader-app/reboot-add-opml-support into lp:ubuntu-rssreader-app. Commit message: Add opml support. User now can import their own opml file into Shorts. No export function yet. Requested reviews: Ubuntu Shorts Developers (ubuntu-shorts-dev

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Michael Hall
In theory it does, but in practice it wasn't. I think it might be because the new PageHeader is looking for an AdaptivePageLayout rather than a PageStack. Whatever caused it to not appear, this would force it back. -- https://code.launchpad.net/~mhall119/ubuntu-docviewer-app/pdf-presentations/+m

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
Review: Approve LGTM! Just a last question: I saw you added a back action to Page.header.leadingActionBar.actions. Did you find some issue? In theory, PageStack automatically appends the action when the page is pushed into the stack (at least, that's what I see on rc-proposed and my vivid+over

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:264 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/103/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/375/console Click here to trigger a rebuild: https://core-apps

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mhall119/ubuntu-docviewer-app/pdf-presentations into lp:ubuntu-docviewer-app

2016-01-14 Thread Stefano Verzegnassi
Review: Needs Fixing I found a few things that require a fix: * I'd prefer to use the new PageHeader, instead of the "old" page.head property. e.g. http://paste.ubuntu.com/14495479/ * We'd probably need to display the page number of the current page.[1] In the code I posted above, it w

[Ubuntu-touch-coreapps-reviewers] mpredotka joined ubuntu-clock-dev

2016-01-14 Thread Ubuntu Clock Developers
Hello Ubuntu Core Apps Reviewers, Michal Predotka (mpredotka) has been added as a member of Ubuntu Clock Developers (ubuntu-clock-dev) by Bartosz Kosiorek (gang65). Follow the link below for more details. https://launchpad.net/~ubuntu-clock-dev/+member/mpredotka -- You received this email b

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-label-fix into lp:ubuntu-clock-app

2016-01-14 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:435 https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/102/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/374/console Click here to trigger a rebuild: https://core-apps