Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/week-press-and-hold-create-event into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:761 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/103/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/516/console Click here to trigger a rebuild: https://core-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread noreply
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers is subs

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
Review: Approve -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers i

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
Review: Approve That got it! -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers i

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. Unapproved changes made after approval. https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/828/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1538/console -- https://code.laun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284454 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

2016-02-01 Thread Nicholas Skaggs
Review: Needs Fixing Merging 'lp:ubuntu-docviewer-app/reboot' in to 'build_dir'. Text conflict in po/com.ubuntu.docviewer.pot 1 conflicts encountered. bzr: ERROR: Conflicts from merge -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 Your team U

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

2016-02-01 Thread Alan Pope 
Review: Needs Fixing Text conflict... Building tree. Retrieving 'lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state' to put at 'build_dir'. Merging 'lp:ubuntu-docviewer-app/reboot' in to 'build_dir'. Text conflict in po/com.ubuntu.docviewer.pot 1 conflicts encountered. bzr: ERROR: Conf

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
Review: Needs Fixing Now I'm getting a completely blank screen:- libust[28446/28448]: Error: Error opening shm /lttng-ust-wait-5 (in get_wait_shm() at lttng-ust-comm.c:958) libust[28446/28448]: Error: Error opening shm /lttng-ust-wait-5 (in get_wait_shm() at lttng-ust-comm.c:958) Loading module

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app

2016-02-01 Thread Renato Araujo Oliveira Filho
> Something is messed up here. I am seeing Year/Month/Day/Agenda views, but no > week view. > In some circumstances I see two Year views. Fixed on parent branch, since this is related with the new SDK header. -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/calendar-app-autolanding/226/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1536/console -- https://code.l

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support/+merge/278288 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
http://people.canonical.com/~alan/screenshots/device-2016-02-02-005326.png http://people.canonical.com/~alan/screenshots/device-2016-02-02-005337.png -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscribed

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/optimize-page-load into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
Review: Needs Fixing Something is messed up here. I am seeing Year/Month/Day/Agenda views, but no week view. In some circumstances I see two Year views. -- https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/optimize-page-load/+merge/284456 Your team Ubuntu Calendar Developers is subscri

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/144/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1535/console -- https://code.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/143/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1534/console -- https://code.

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app

2016-02-01 Thread Jenkins Bot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

2016-02-01 Thread Jenkins Bot
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 -- Yo

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector/

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/new-empty-state/+merge/283802 -- Yo

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app

2016-02-01 Thread noreply
The proposal to merge lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/update-colours2/+merge/284345 -- Your team Ubuntu File Manager D

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app

2016-02-01 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~popey/ubuntu-filemanager-app/update-colours2/+merge/284345 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app

2016-02-01 Thread noreply
The proposal to merge lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~fboucault/ubuntu-filemanager-app/migrate_toolkit_13/+merge/282915 -- Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app

2016-02-01 Thread Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~fboucault/ubuntu-filemanager-app/migrate_toolkit_13/+merge/282915 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-rev

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fboucault/ubuntu-filemanager-app/migrate_toolkit_13/+merge/282915 -- Your team U

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Evan McIntire
Yup - I've been able to reproduce it, I almost have a fix ready, just have to fine tune a little bit and we'll be golden! Thanks for the help! -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502 Your team Ubuntu Terminal Developers is requested to review

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284686 -- Your team Ubuntu Calendar Developers i

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Renato Araujo Oliveira Filho
Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app. Commit message: Update to qtquick 2.4 Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Alan Pope  (popey) For more details, see: h

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Renato Araujo Oliveira Filho
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Approved => Superseded For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284454 -- Your team Ubuntu Calendar Developers is

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Stefano Verzegnassi
The bug about the bluetooth keyboard should be easily reproducible on desktop too: just ensure to make the auth dialog visible and type some text with your USB/PS2/... keyboard. Currently the keyboard focus is owned by the terminal widget, that's the reason why it can be typed some command in t

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~popey/ubuntu-filemanager-app/update-colours2 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/update-colours2/+merge/284345 -- Your team Ubuntu File Man

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Evan McIntire
Cool, thanks for the advice! That other bug you linked is pretty nasty so I'll see if I can rework things a little to get them both done :) -- https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/284502 Your team Ubuntu Terminal Developers is requested to review th

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/bottom-edge into lp:ubuntu-calendar-app

2016-02-01 Thread Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:755 https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/88/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/515/console Click here to trigger a rebuild: https://core-apps-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/bottom-edge into lp:ubuntu-calendar-app

2016-02-01 Thread Renato Araujo Oliveira Filho
Renato Araujo Oliveira Filho has proposed merging lp:~renatofilho/ubuntu-calendar-app/bottom-edge into lp:ubuntu-calendar-app with lp:~renatofilho/ubuntu-calendar-app/optimize-page-load as a prerequisite. Requested reviews: Ubuntu Calendar Developers (ubuntu-calendar-dev) For more details, se

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/bottom-edge into lp:ubuntu-calendar-app

2016-02-01 Thread Renato Araujo Oliveira Filho
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/bottom-edge into lp:ubuntu-calendar-app has been updated. Commit Message changed to: Implemented Bottom edge for new event page. For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/bottom-edge/+merge/284622

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/use-scrollview into lp:music-app

2016-02-01 Thread Andrea Bernabei
NOT READY FOR REVIEW: I've just created the MR as I need the build artifacts asap. Will contact Andrew -- https://code.launchpad.net/~ahayzen/music-app/use-scrollview/+merge/284588 Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/use-scrollview in

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth into lp:ubuntu-terminal-app

2016-02-01 Thread Stefano Verzegnassi
Hi Evan! As long as you only need to test the TextField focus, you can force the auth dialog to appear on desktop too. In AuthenticationService.qml, line 33, you can remove the 'if' condition, so that the dialog will be always shown on any platform. http://bazaar.launchpad.net/~ubuntu-terminal-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app

2016-02-01 Thread Alan Pope 
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/sdk-1-3 into lp:ubuntu-calendar-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/sdk-1-3/+merge/284454 -- Your team Ubuntu Calendar Developers i