Review: Approve continuous-integration
PASSED: Continuous integration, rev:168
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1010/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/561/console
Click here to trigger a rebuild:
https://core-apps-jen
As Stefano said[1], I do think we should avoid adding too much to the C++ code.
Whenever we end up redoing the clipboard stuff we could maybe remove this and
the isClipboardEmpty() functions?
There are a few bugs relating to improving the clipboard experience, maybe we
could make a blueprint or
Evan McIntire has proposed merging
lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into lp:ubuntu-terminal-app.
Commit message:
Disable copy if selection is empty
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
For more details, see:
https://code.launchpad.net/~mcintire
https://i.imgur.com/01kJUIB.png Screen of this overlayed with gnome-term with
background transparency
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/window-font-size/+merge/285285
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~mcintire-eva
This was based in part of Nikwen's work in here[1], I still have a bit to do
before I can call this finished, though
I think the " FontUtils.sizeToPixels("medium") * settings.fontSize / 10 "
should be moved into a function so if any changes need to be made to it, we
don't have to hunt down all
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable_paste into
lp:ubuntu-terminal-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
--
Your team Ubuntu Terminal De
Review: Approve continuous-integration
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable_paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
--
Your team Ubuntu Termi
Review: Approve
Ok, great. Let's merge this. :)
I don't know what Launchpad thought when it created the diff for the other MP.
:D
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-
@Stefano: Will Launchpad build the pot file itself in that case or how will it
pick up new translatable strings then?
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
@Stefano: I compared them earlier today due to line 161 of the diff and it
looks like those two colors confused me. However, you're right about the
background color and the red/blue thing also isn't that much of an issue.
Hence, I support renaming the Dark Pastels scheme to the name you suggeste
Review: Approve continuous-integration
PASSED: Continuous integration, rev:166
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1009/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/560/console
Click here to trigger a rebuild:
https://core-apps-jen
I just created a new branch with the changes to avoid the hell we got into
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ub
Evan McIntire has proposed merging
lp:~mcintire-evan/ubuntu-terminal-app/disable_paste into lp:ubuntu-terminal-app.
Commit message:
Disables pasteo option if the clipboard buffer is empty
Requested reviews:
Alan Pope (popey)
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integratio
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
--
Your team Ubuntu Ter
Ooh, the magical world of Launchpad trying to merge a .pot update when the
.pot has been updated in the meantime. :)
P.S. Now you know how a DocViewer developer feels, haha :'D
P.S. #2 We probably should prevent this from happening, by avoiding to
update translations every time the app is built i
Wow, I made it worse. Just a moment, let me re-merge the trunk in and fix all
of this nonsense
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: http
@Niklas: the current "Ubuntu" theme uses exactly the same palette of
"DarkPastels".
The only differences are the background color[1] and the blue color (which in
the Ubuntu theme is shown as red).
We could rename "Dark Pastels" as "Dark Pastels / Ubuntu (old)" (or something
similar), but I don'
Review: Needs Information
The new color scheme is great! Very good job, Stefano!
I was about to merge this, but given that this isn't a minor color change, I'd
love to see the old scheme still being an option to choose in the settings. We
have quite a lot of themes anyway and the old one is pro
Merging 'lp:ubuntu-terminal-app' in to 'build_dir'.
Text conflict in po/com.ubuntu.terminal.pot
1 conflicts encountered.
bzr: ERROR: Conflicts from merge
Looks like the pot file merge conflict we've been talking about. Try the
command I posted above. ;)
--
https://code.launchpad.net/~mcintire-e
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-autolanding/85/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/3390/console
--
https://code.la
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
--
Your team Ubuntu Termi
Review: Approve
Thank you for fixing this, Evan! The MP looks very good. :)
@Stefano: You make a really good point with (1). Let's keep that in mind when
we continue to add features. :)
[Another note regarding pot file conflicts: If you have already committed stuff
which causes a merge conflic
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
--
Your team Ubuntu Termi
The proposal to merge lp:~nikwen/ubuntu-terminal-app/font-size-fix into
lp:ubuntu-terminal-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
--
Your team Ubuntu Terminal Developers is su
Review: Approve continuous-integration
PASSED: Continuous integration, rev:165
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1008/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/559/console
Click here to trigger a rebuild:
https://core-apps-jen
The proposal to merge lp:~nikwen/ubuntu-terminal-app/font-size-fix into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
--
Your team Ubuntu Terminal Developers
Thank you for the quick review again! :)
I changed the default back to 10 and tested it on my phone again. I'll
top-level approve this now to get it merged.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
Your team Ubuntu Terminal Developers is subscribed to
Looking at the Jenkins logs, I don't think the test failures are related to the
changes here. (Please correct me if I'm wrong, though!) Any idea what was
happening?
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar De
Review: Approve
>Here is a comparison of the font sizes with the current default:
>>https://launchpadlibrarian.net/236776246/comparison.png
>
>This shows that the values from the documentation are probably incorrect.
>However, you're right that it looks better on the phone with a ration of 1.0.
The proposal to merge lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme
into lp:ubuntu-terminal-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
--
Your team Ubuntu Ter
The proposal to merge lp:~nikwen/ubuntu-terminal-app/improve-list-item-design
into lp:ubuntu-terminal-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
--
Your team Ubuntu Ter
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:738
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1007/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/558/console
Click here to trigger a rebuild:
https://core-app
So I'll also top-level approve this one. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
lp:ubuntu-te
The proposal to merge lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
--
Your team Ubun
The proposal to merge lp:~nikwen/ubuntu-terminal-app/improve-list-item-design
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
--
Your team Ubun
Then let's do it. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
--
Mailin
I have to say that I am against the 100th, though. In general I tend to change
appearance settings in applications once and afterwards often want to go back
to the default. This is doable with the current 10th but it would be a hassle
to hit exactly 1.0 when we use 100.
Furthermore, I guess that
Thank you for the review! :)
Here is a comparison of the font sizes with the current default:
https://launchpadlibrarian.net/236776246/comparison.png
This shows that the values from the documentation are probably incorrect.
However, you're right that it looks better on the phone with a ration o
Review: Approve
LGTM, the default color scheme is properly set.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/fix-default-color-sche
Yes, +1!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
--
Mailing list: http
Fixed the merge conflicts. Would you mind looking into it again, please? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launch
Thanks for the review, Stefano. :)
Shall we pull the top-level approve trigger?
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improv
Review: Approve
Looks good to me. Thanks!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-ter
Review: Needs Information
The MP looks good, although I'm not sure on the default and the maximum size
for the font.
I've left two inline comments.
Also, it might be nice to handle the font size in terms of 100th in the
settings page (i.e. from 4% to 500% - assuming the current range is ok).
D
So I just learned something new. Thanks, David! :)
(By the way, would it be possible to add an example for that to
https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.i18n/ ?)
Now I just have to sort out the merge conflicts.
--
https://code.launchpad.net/~nikwen/ubuntu-calen
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:737
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/748/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/557/console
Click here to trigger a rebuild:
https://core-apps
Review: Approve continuous-integration
PASSED: Continuous integration, rev:163
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1006/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/556/console
Click here to trigger a rebuild:
https://core-apps-jen
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
Commit message:
Tweak the design of the ListItems in the settings
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Ubuntu Terminal Developers (ubuntu-terminal-
Review: Approve continuous-integration
PASSED: Continuous integration, rev:163
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1005/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/555/console
Click here to trigger a rebuild:
https://core-apps-jen
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
lp:ubuntu-terminal-app.
Commit message:
Fix the color scheme to be set to "Ubuntu" again by default
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Jenkins Bot (ubuntu-core-apps-jenk
Review: Approve continuous-integration
PASSED: Continuous integration, rev:163
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1004/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/554/console
Click here to trigger a rebuild:
https://core-apps-jen
While working on this I found
https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1542668.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchp
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/font-size-fix
into lp:ubuntu-terminal-app.
Commit message:
Make font size relative to "medium" fontSize for Labels
Default font size is set to be the same as that of gnome-terminal on a Unity 7
desktop
Requested reviews:
Stefa
Ok, I found some time for working on this.
I forgot to commit the AppArmor permission for keeping the screen on (as always
the problem exists between the chair and the keyboard :D)
However, it keeps on turning the screen off...
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer
Public bug reported:
I have bq E4.5.
After OTA9 update, I start a Telegram conversation, then I turn to browser and
lock the screen.
In about 10 minutes it sent byself some messages to last conversation on
Telegram, with some random letters.
I tried to send this bug to telegram first, but I have
56 matches
Mail list logo
