Thanks for review, I added few comments.
Will push fixed code soon.
Diff comments:
>
> === modified file 'EventRepetition.qml'
> --- EventRepetition.qml 2016-03-07 17:57:04 +
> +++ EventRepetition.qml 2016-03-15 13:00:49 +
> @@ -19,14 +19,14 @@
> import QtQuick 2.4
> import
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
Review: Approve continuous-integration
PASSED: Continuous integration, rev:319
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/258/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/792/console
Click here to trigger a rebuild:
https://core-apps-jen
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/fix-1373945A into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1373945A/+merge/288955
--
Your team Ubuntu Calendar Develope
The proposal to merge
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1554610 into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1554610/+merge/288969
--
Y
Great work.
I added some small comments but in general the code looks great.
Diff comments:
>
> === modified file 'EventRepetition.qml'
> --- EventRepetition.qml 2016-03-07 17:57:04 +
> +++ EventRepetition.qml 2016-03-15 13:00:49 +
> @@ -19,14 +19,14 @@
> import QtQuick 2
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/bottomEdge into
lp:ubuntu-calendar-app has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/bottomEdge/+merge/241590
--
Your team Ubuntu Calendar Develo
thanks for the work. Unfortunately a new component has landed on SDK. We are
using that for now.
--
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/bottomEdge/+merge/241590
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https:/
The proposal to merge
lp:~renatofilho/ubuntu-calendar-app/fix-add-guest-search-field into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-add-guest-search-field/+merge/284121
--
The proposal to merge
lp:~renatofilho/ubuntu-calendar-app/week-press-and-hold-create-event into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/week-press-and-hold-create-event/+merg
it was merged in another MR.
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-add-guest-search-field/+merge/284121
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~renatofilho/ubuntu-calendar-app/fix-add-guest-search-field into
lp:ubuntu-cal
it was merged in another branch.
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/week-press-and-hold-create-event/+merge/284290
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~renatofilho/ubuntu-calendar-app/week-press-and-hold-create-event int
Review: Disapprove
Let's make this explicit in jenkins instead
--
https://code.launchpad.net/~nskaggs/reminders-app/run-qml-tests-on-build/+merge/289063
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-
Review: Disapprove
Let's make this explicit in jenkins instead
--
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/run-qml-tests-on-build/+merge/289065
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapp
The proposal to merge lp:~nskaggs/reminders-app/run-qml-tests-on-build into
lp:reminders-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~nskaggs/reminders-app/run-qml-tests-on-build/+merge/289063
--
Your team Ubuntu Notes app develop
The proposal to merge lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/run-qml-tests-on-build/+merge/289065
--
Your team Ubuntu Clock De
Nicholas Skaggs has proposed merging
lp:~nskaggs/ubuntu-clock-app/run-qml-tests-on-build into lp:ubuntu-clock-app.
Commit message:
Always run unit tests on build
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clo
Nicholas Skaggs has proposed merging
lp:~nskaggs/reminders-app/run-qml-tests-on-build into lp:reminders-app.
Commit message:
Always run qml tests when building
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
For more details, see:
https://code.launchpad.net/~nskaggs/reminders-a
So do I see this bug, agree with Roman, we need to abandon Tabs
component.
** Changed in: ubuntu-rssreader-app
Status: New => Confirmed
** Changed in: ubuntu-rssreader-app
Importance: Undecided => High
--
You received this bug notification because you are a member of Ubuntu
Shorts Dev
The proposal to merge lp:~nskaggs/ubuntu-docviewer-app/create-cache into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
--
Your team Ubuntu Document Viewer
Review: Approve
--
https://code.launchpad.net/~nskaggs/ubuntu-docviewer-app/create-cache/+merge/288718
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touc
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into
lp:ubuntu-terminal-app.
Commit message:
* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, instead of the QtQui
The proposal to merge
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988
Review: Approve
looks good.
--
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1373945/+merge/288988
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Pos
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-terminal-app/device-detection into
lp:ubuntu-terminal-app.
Commit message:
Added a context property which allows terminal-app to know whether a keyboard
or a mouse is attached to the device.
This is required to workaround
just one small change
Diff comments:
>
> === modified file 'EventListModel.qml'
> --- EventListModel.qml2016-03-04 16:10:56 +
> +++ EventListModel.qml2016-03-14 22:21:27 +
> @@ -110,9 +124,9 @@
> var cals = getCollections();
> for(var i = 0 ; i < cals.l
Szymon Waliczek has proposed merging
lp:~majster-pl/ubuntu-calendar-app/new-event-page into lp:ubuntu-calendar-app.
Requested reviews:
Nekhelesh Ramananthan (nik90): code-review & testing
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Related bugs:
Bug #1383846 in Ubuntu
Review: Approve code-review & testing
LGTM. Awesome work. We can finish of the new design implementation for the
Guests feature when we get design specs for it in another MP.
@renato, You can go ahead test this and top-approve. It fixes the label color
issue that bill pointed out as well.
--
h
Review: Needs Fixing
Almost there, just noticed one minor issue. In the Event reminders page, the
option "No Reminder" is hidden by the page header. I had a quick look at it,
and is quite easy to fix -> http://paste.ubuntu.com/15391380/
--
https://code.launchpad.net/~majster-pl/ubuntu-calendar-
Long event description is clipped even if there is still space on the screen.
check screenshot.http://imgur.com/GTNhwRx
--
https://code.launchpad.net/~nik90/ubuntu-calendar-app/revamp-eventdetails-page/+merge/288492
Your team Ubuntu Calendar Developers is requested to review the proposed merge
o
Review: Needs Fixing
Nice work! It is *almost* ready. Just few minor touch ups to do and then we are
set to land this MP.
1. In the old guest design layout, I notice 3 minor issues ( refer to
http://imgur.com/HC4JAcs )
a) Remove the listitem dividers of the guests listitem
b) set the guest lis
The proposal to merge lp:~nik90/ubuntu-calendar-app/new-event-style into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-calendar-app/new-event-style/+merge/287324
--
Your team Ubuntu Calendar
35 matches
Mail list logo
