[Ubuntu-touch-coreapps-reviewers] [Bug 1552100] Re: Create .snap packages of core apps

2016-10-04 Thread Andrea Bernabei
** Summary changed: - Move to Snappy + Create .snap packages of core apps -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/155210

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/dynamic-load-listview into lp:ubuntu-clock-app

2016-03-03 Thread Andrea Bernabei
Review: Approve all my comments were addressed, looks good to me! thanks! :) -- https://code.launchpad.net/~nik90/ubuntu-clock-app/dynamic-load-listview/+merge/287831 Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/dynamic-load-listview i

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/dynamic-load-listview into lp:ubuntu-clock-app

2016-03-03 Thread Andrea Bernabei
1% cpu is a wonderful world, isn't it :) We should probably start optimizing apps to make sure they behave at some-level-of-decency at 1% cpu :D Thanks, approved! :) -- https://code.launchpad.net/~nik90/ubuntu-clock-app/dynamic-load-listview/+merge/287831 Your team Ubuntu Clock Developers is req

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/dynamic-load-listview into lp:ubuntu-clock-app

2016-03-03 Thread Andrea Bernabei
Thanks Nekhelesh :) about the height, maybe you can try "cpulimit" to slow down your laptop to 1% and then just test that the height is properly updated ;) it's really useful to test how stuff works on less performant platforms :) (although it would be more useful if you could slow down other p

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/dynamic-load-listview into lp:ubuntu-clock-app

2016-03-03 Thread Andrea Bernabei
just a couple of comments, looks very good otherwise ;) thanks! Diff comments: > === modified file 'app/components/ExpandableListItem.qml' > --- app/components/ExpandableListItem.qml 2016-02-25 22:16:54 + > +++ app/components/ExpandableListItem.qml 2016-03-02 18:33:57 + > @@ -33,4

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/use-scrollview into lp:music-app

2016-02-01 Thread Andrea Bernabei
NOT READY FOR REVIEW: I've just created the MR as I need the build artifacts asap. Will contact Andrew -- https://code.launchpad.net/~ahayzen/music-app/use-scrollview/+merge/284588 Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/use-scrollview in

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app

2016-01-25 Thread Andrea Bernabei
lgtm! thanks :) -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument/+merge/283786 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app. -

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app

2016-01-25 Thread Andrea Bernabei
another comment :) Diff comments: > === modified file 'src/app/main.cpp' > --- src/app/main.cpp 2015-03-23 17:46:34 + > +++ src/app/main.cpp 2016-01-25 11:54:32 + > @@ -174,12 +174,20 @@ > qDebug() << "Trying to load QML from:" << path + > "/qml/ubuntu-terminal-app.qml"; >

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp:ubuntu-terminal-app

2016-01-25 Thread Andrea Bernabei
small comment Diff comments: > === modified file 'src/app/main.cpp' > --- src/app/main.cpp 2015-03-23 17:46:34 + > +++ src/app/main.cpp 2016-01-25 11:26:52 + > @@ -174,12 +174,18 @@ > qDebug() << "Trying to load QML from:" << path + > "/qml/ubuntu-terminal-app.qml"; >

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-27 Thread Andrea Bernabei
@Saviq: my question still stands :) -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title: Coordinated migration to UI

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2015-10-24 Thread Andrea Bernabei
Is the plan just to update the imports to 1.3? Or should we adapt the apps to use the new features coming from 1.3? So far all MRs implemented the former, but I haven't seen any using the new 1.3 specific components, hence the question :) -- You received this bug notification because you are a m

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into lp:ubuntu-calendar-app

2015-06-08 Thread Andrea Bernabei
minor comments from me, looks good otherwise, thanks :) Diff comments: > === modified file 'calendar.qml' > --- calendar.qml 2015-01-22 20:07:30 + > +++ calendar.qml 2015-05-28 12:57:38 + > @@ -95,6 +95,21 @@ > footerColor: "#ECECEC" > anchorToKeyboard: true > > +

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into lp:ubuntu-calendar-app

2015-05-14 Thread Andrea Bernabei
Diff comments: > === modified file 'calendar.qml' > --- calendar.qml 2015-01-22 20:07:30 + > +++ calendar.qml 2015-04-05 04:56:25 + > @@ -95,6 +95,21 @@ > footerColor: "#ECECEC" > anchorToKeyboard: true > > +Connections { > +target: UriHandler > +

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into lp:ubuntu-calendar-app

2015-05-14 Thread Andrea Bernabei
code comment added Diff comments: > === modified file 'calendar.qml' > --- calendar.qml 2015-01-22 20:07:30 + > +++ calendar.qml 2015-04-05 04:56:25 + > @@ -95,6 +95,21 @@ > footerColor: "#ECECEC" > anchorToKeyboard: true > > +Connections { > +target: Ur