Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snap-mir-libs into lp:ubuntu-filemanager-app

2017-03-24 Thread Carlos Jose Mazieri
Review: Approve That is OK. -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snap-mir-libs/+merge/320882 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snap-mir into lp:ubuntu-filemanager-app

2017-02-14 Thread Carlos Jose Mazieri
Review: Approve That is OK, thank you. -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snap-mir/+merge/316877 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Po

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app

2017-01-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app. Commit message: FIX the netwotk crash when Localtion::m_info is deleted in the main thread Requested reviews: Ubuntu File Manager Developers (ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app

2017-01-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app. Commit message: It fixes a network crash bug #1609051 when Localtion::m_info is deleted in the main thread. Requested reviews: Ubuntu File Manager

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-26 Thread Carlos Jose Mazieri
Renato, The check in line 61 is necessary. The 'parentItemInfo' keeps the information from the parent, which can be: directory/share/host/workgroup. When the 'mainItemInfo' is root like "smb://" there is no 'parentItemInfo', it can be null. Another reason it might be used in my regression t

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-26 Thread Carlos Jose Mazieri
Renato, Can you please test that proposal of that NetworkListWorker creating its own instance of the parent item? There is a proposal https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app//fix-network-crash-1609051 Also renamed "parent" to "parentItemInfo". -- https://code.la

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-26 Thread Carlos Jose Mazieri
I would remove all the Qt metaprogramming as it is not necessary, Only a small change in the NetworkListWorker as exposed above should solve the problem, NetworkListWorker class can create its own instance by doing a copy. -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/fix-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-25 Thread Carlos Jose Mazieri
Another and easy approach would be if the class NetworkListWorker receive again a const DirItemInfo *parent, but sets m_parent as its own instance using the operator '=', in this case it never gets deleted outside the worker thread. Suppose the code changed: NetworkListWorker::NetworkListWorke

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-25 Thread Carlos Jose Mazieri
Renato, by temporary objects I mean a temporary DirItemInfo created in Location?? classes, example: void Location::refreshInfo() { if (m_info) { DirItemInfo *item = newItemInfo(m_info->absoluteFilePath()); delete m_info; m_info = item; } } Would be changed b

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-25 Thread Carlos Jose Mazieri
Review: Needs Information OK, Let's have a review on it, 1. perhaps the slot onParentDestroyed() on location.h lines 94-96 is not being used. 2. on line 38 from networklistworker.cpp we should check if m_parent != 0, the default value for 'parent' is 0 on networklistworker.h 38: parent-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-25 Thread Carlos Jose Mazieri
Review: Needs Information Does it crash on both phone and desktop or just phone? -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/fix-network-crash/+merge/314870 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: http

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/fix-network-crash into lp:ubuntu-filemanager-app

2017-01-25 Thread Carlos Jose Mazieri
Review: Needs Information Renato, The bug description appears to say that it always crashes. Can you confirm that it always crashes or it happens under some special condition? If it happens under special condition can you describe that scenario? -- https://code.launchpad.net/~renatofilho/ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform into lp:ubuntu-filemanager-app

2016-11-20 Thread Carlos Jose Mazieri
The proposal to merge lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform/+merge/311318 -- Your

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform into lp:ubuntu-filemanager-app

2016-11-20 Thread Carlos Jose Mazieri
Review: Approve Renato, Thanks for the information, that is OK. -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform/+merge/311318 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/ubuntu-app-platform into lp:ubuntu-filemanager-app

2016-11-19 Thread Carlos Jose Mazieri
Review: Needs Information Hello Renato, I am sorry for my lack of knowledge about this, Can you explain what is it for? What does it improve the app? Is it required for others/all core apps? What is/does ubuntu-app-plataform plugin? -- https://code.launc

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ken-vandine/ubuntu-filemanager-app/deb_content-hub_peer_registration into lp:ubuntu-filemanager-app

2016-10-13 Thread Carlos Jose Mazieri
Review: Approve I am OK with this. Thanks. -- https://code.launchpad.net/~ken-vandine/ubuntu-filemanager-app/deb_content-hub_peer_registration/+merge/307223 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubunt

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487 into lp:ubuntu-filemanager-app

2016-08-26 Thread Carlos Jose Mazieri
Hello Arto and Sam, The "apt-get install libsmbclient-dev" used to fail on any armf kit, so it was impossible to generate the click package in the qtcreator. The build on device used to work because "apt-get install libsmbclient-dev" on device used to work. That is the reason why Alan Pope and

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487 into lp:ubuntu-filemanager-app

2016-08-23 Thread Carlos Jose Mazieri
Review: Needs Information Hello Sam, It is OK to me, just a question: Have you tested building for armf on device and building for armf on qtcreator using a sdk like click-ubuntu-sdk-13.10-armhf? This build was done by Alan Pope and Stefano Verzegnassi to prevent a bug that did not allow t

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app

2016-07-16 Thread Carlos Jose Mazieri
Review: Approve Nice, Thanks. -- https://code.launchpad.net/~mzanetti/ubuntu-filemanager-app/share-files/+merge/299821 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/import-contact into lp:ubuntu-filemanager-app

2016-07-16 Thread Carlos Jose Mazieri
Review: Approve The code looks OK to me. Thanks. -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/import-contact/+merge/300087 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-corea

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-15 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2016-01-14 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01/+merge

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2016-01-11 Thread Carlos Jose Mazieri
I will fix that, thanks. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02/+merge/280388 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewer

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-05 into lp:ubuntu-filemanager-app

2015-12-12 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 as a prerequisite. Commit message: class SmbListWorker removed from repostory

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 into lp:ubuntu-filemanager-app

2015-12-12 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 as a prerequisite. Commit message: * Created new and generic classes

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 into lp:ubuntu-filemanager-app

2015-12-12 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-03 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 as a prerequisite. Commit message: ust fixed a typo in some files

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app

2015-12-12 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-02 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 as a prerequisite. Commit message: LocationItemDirIterator descendants classes now

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app

2015-12-12 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/new-protocols-support-01 into lp:ubuntu-filemanager-app. Commit message: Improved DirItemInfo and descendant classes: * added DirItemInfo::setFile(const QString& newUrl) to change the current Item informa

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/QDir-Filter-fix into lp:ubuntu-filemanager-app

2015-12-08 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/QDir-Filter-fix into lp:ubuntu-filemanager-app. Commit message: Just replaced QDir::Filter by QDir::Filters, QDir::Filter was wrongly used. Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot

[Ubuntu-touch-coreapps-reviewers] [Bug 1520959] Re: Impossible to empty clipboard

2015-12-01 Thread Carlos Jose Mazieri
Hello, if you copy a text using another app to the clipboard the filemanager will recognize it as non file url and then understands the clipboard is empty even it is not. Does it help? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is su

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-10 Thread Carlos Jose Mazieri
Hi Tony, The new version will be available soon, when you get that, please test it without your work around. Thank you very much. -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscript

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-09 into lp:ubuntu-filemanager-app

2015-11-08 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-09 into lp:ubuntu-filemanager-app. Commit message: Removed unnecessary variable pathExists from DiskLocation::isThereDiskSpace() Improved log for authenticateCallBacks. Requested reviews

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug into lp:ubuntu-filemanager-app

2015-11-08 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-hostname-bug into lp:ubuntu-filemanager-app. Commit message: Fixed a bug #1508504 related to get the Samba hostname. It used to get the description instead of the name. For some cases the name is the first

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-06 Thread Carlos Jose Mazieri
** Changed in: ubuntu-filemanager-app Status: New => In Progress ** Changed in: ubuntu-filemanager-app Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Match

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-05 Thread Carlos Jose Mazieri
Tony, I will work next weekend to fix the problem related to the "name" of the servers. Regarding to private folders, it should show all folders if you "unlock full access", then when you try to access private folders it should ask for user/password, this behavior was a design decision. Many Th

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-04 Thread Carlos Jose Mazieri
Hello Tony, I am looking for "console ouput" not for screen shots. Are you able to get it? (maybe using logcat) Do you need password to access those servers content? Thanks, Carlos -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subsc

[Ubuntu-touch-coreapps-reviewers] [Bug 1513032] [NEW] downloaded temporary files should be removed after open/close

2015-11-04 Thread Carlos Jose Mazieri
Public bug reported: In order to open remote files, they are first downloaded into a temporary file in "/tmp" directory. They should be removed when the user closes the file in order to save space. ** Affects: ubuntu-filemanager-app Importance: Undecided Status: New -- You receiv

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-04 Thread Carlos Jose Mazieri
Hello, Regarding to "Devices are listed by 'description'" it can be easily fixed. Regarding to it does not show the content of "nasbox", have you first checked "unlock full access" option first? if not, please try do it and try it again. if so or if it does not work after doing it, can you capt

[Ubuntu-touch-coreapps-reviewers] [Bug 1508504] Re: Network doesn't work

2015-11-04 Thread Carlos Jose Mazieri
** Changed in: ubuntu-filemanager-app Assignee: (unassigned) => Carlos Jose Mazieri (carlos-mazieri) -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-08 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-08 into lp:ubuntu-filemanager-app. Commit message: Removed static_cast from SmbLocationItemFile::size() Fixed SmbUtil::getStatInfo() to set "Not exist" for items su

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-04 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-03 as a prerequisite. Commit message: implemented tests for downloading files Requested

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-05 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-04 as a prerequisite. Commit message: UI changed to open remote files Requested reviews

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-02 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-02 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-01 as a prerequisite. Commit message: improved DiskLocation::isThereDiskSpace() to work for

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-03 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-03 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-02 as a prerequisite. Commit message: implemented a set of high level download functions

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-01 into lp:ubuntu-filemanager-app

2015-11-02 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/open-remote-files-01 into lp:ubuntu-filemanager-app. Commit message: added a set of download functions, they are basically a "copy" renaming the destination file. Requested reviews: Ubuntu Fi

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app

2015-10-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-07 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 as a prerequisite. Commit message: improved SmbUtil::findSmBServer() Requested reviews

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-27 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a prerequisite. Commit message: some cleanup in SmbItemInfo::setInfo(), work around

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-21 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a prerequisite. Commit message: some cleanup in SmbItemInfo::setInfo(), work around

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-21 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app. Commit message: changed SmbUtil::getStat() and SmbUtil::getFstat() to return int as they do not handle items from SmbUtil::StatReturn, they are just a

[Ubuntu-touch-coreapps-reviewers] [Bug 1505594] Re: Wrong time of accessed files

2015-10-20 Thread Carlos Jose Mazieri
There was related bug that was fixed some time ago, all items used show the time of the current folder. I think that it is OK now, can you check it again? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manage

[Ubuntu-touch-coreapps-reviewers] [Bug 1472677] Re: Network shares are inaccessable by the application

2015-10-20 Thread Carlos Jose Mazieri
It has been released. ** Changed in: ubuntu-filemanager-app Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmai

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a prerequisite. Commit message: Fixed SmbUtil::changePermissions() improved SmbUtil

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a prerequisite. Commit message: ixed SmbUtil::changePermissions() improved SmbUtil

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04/+merge/275

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04/+merge/273

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
The proposal to merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995 -- Your te

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
The proposal to merge lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957 -- Your team Ubuntu File Manager

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/set-bzr-revno into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
Review: Approve Nice, Thanks. -- https://code.launchpad.net/~popey/ubuntu-filemanager-app/set-bzr-revno/+merge/274957 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

2015-10-20 Thread Carlos Jose Mazieri
Review: Approve OK, Thanks. -- https://code.launchpad.net/~popey/ubuntu-filemanager-app/suppress-predictive-text/+merge/274995 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Pos

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/fix-1507566 into lp:ubuntu-filemanager-app

2015-10-19 Thread Carlos Jose Mazieri
Review: Approve That is OK Thanks. -- https://code.launchpad.net/~popey/ubuntu-filemanager-app/fix-1507566/+merge/274884 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-10-19 Thread Carlos Jose Mazieri
Review: Approve Thanks, I am looking forward to getting the entire Samba stuff in the next release. -- https://code.launchpad.net/~popey/ubuntu-filemanager-app/add-click-deps/+merge/270287 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-06 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a prerequisite. Commit message: changed SmbUtil::getStat() and SmbUtil::getFstat() to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-10-05 Thread Carlos Jose Mazieri
Hello Alan, My attempt was done using the SDK armhf 15-04. I see that you did install 'libsmbclient-dev' (it installs all the samba libraries) which I thought it was going to be downloaded by the proposed solution. I thought that solution would bring all the necessary resources to compile and

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-06 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 as a prerequisite. Commit message: some cleanup in SmbItemInfo::setInfo(), work around

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a prerequisite. Commit message: changed SmbUtil::getStat() and SmbUtil::getFstat() to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a prerequisite. Commit message: changed SmbUtil::getStat() and SmbUtil::getFstat() to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 as a prerequisite. Commit message: changed SmbUtil::getStat() and SmbUtil::getFstat() to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a prerequisite. Commit message: ixed SmbUtil::changePermissions() improved SmbUtil

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 as a prerequisite. Commit message: fixed SmbUtil::changePermissions() improved SmbUtil

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-03 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-02 as a prerequisite. Commit message: Improved SmbUtil::getStatInfo() to not always open

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-02 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-02 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 as a prerequisite. Commit message: After using a such user/password for

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 into lp:ubuntu-filemanager-app

2015-10-04 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-improvements-01 into lp:ubuntu-filemanager-app. Commit message: Improved Authentication saving/using by trying the host only when there is no user/password for a such URL which has path Requested reviews

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/directory-browsing-info into lp:ubuntu-filemanager-app

2015-09-30 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/directory-browsing-info into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash-fix as a prerequisite. Commit message: Show the size of directories: (it is the number of items

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash-fix into lp:ubuntu-filemanager-app

2015-09-30 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash-fix into lp:ubuntu-filemanager-app. Commit message: Fixes Samba browsing crash on he phone related to the "struct stat" addressing files using 32 bits only instead of 64 bits Request

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash into lp:ubuntu-filemanager-app

2015-09-30 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-crash into lp:ubuntu-filemanager-app. Commit message: Fixes the crash in Samba browsing files related to the "struct stat" accessing files using 32 bits only. Requested reviews: Ubuntu Fi

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-26 Thread Carlos Jose Mazieri
Review: Needs Information Hello, I did a first test without removing my Samba libraries. On desktop it downloaded the libraries but on armhf it did not. See some output: -- Setting BZR_SOURCE to lp:ubuntu-filemanager-app Grabbing upstream libs to /home/carlos/ubuntu_work/build-add-click-deps-U

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into lp:ubuntu-filemanager-app

2015-09-19 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-06 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 as a prerequisite. Commit message: Fixed problems in the Authentication and using saved Password Requested

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app

2015-09-14 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05/+merge/270339 -- Your team Ubunt

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app

2015-09-14 Thread Carlos Jose Mazieri
I had to promote a modification to fix a bug about generating the signal which will activate the Authentication dialog. The modification was: if (model.isBrowsable) { 79 -if (model.isReadable && model.isExecutable) { 80 +console.log("browsable path="+mod

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-14 Thread Carlos Jose Mazieri
> It is hard to say something about the crash, if you have the > 'libsmbclient' installed in your phone you can try this click package > which contains 'Network' in Places to start navigating in Samba. > https://www.dropbox.com/s/f6gxiqbav3th8bx/com.ubuntu.filemanager_0.4.latest_ar > mhf.click?dl=0

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 into lp:ubuntu-filemanager-app

2015-09-08 Thread Carlos Jose Mazieri
I agree with your comments and I will modify that according to that. Thanks. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02/+merge/270335 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://laun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-08 Thread Carlos Jose Mazieri
It is hard to say something about the crash, if you have the 'libsmbclient' installed in your phone you can try this click package which contains 'Network' in Places to start navigating in Samba. https://www.dropbox.com/s/f6gxiqbav3th8bx/com.ubuntu.filemanager_0.4.latest_armhf.click?dl=0 Have you

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-08 Thread Carlos Jose Mazieri
Looking at the log you posted, it looks like there is an extra space after "smb": void DirModel::setPath(const QString&, const QString&, const QString&, bool) DirModel_QML_137(0x12ff010) path or url may not exist or cannot be read: "smb ://192.168.1.3/" The correct url must be "smb://192.168.1.3".

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-05 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 as a prerequisite. Commit message: Implemented a dialog for Authentication when remote locations requires

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-04 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03 as a prerequisite. Commit message: forcing Executable/Readable for hosts, it will make them act as folder

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03 into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-03 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 as a prerequisite. Commit message: mproved icon chooser based on the model data added icon for remote places

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-02 into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-01 as a prerequisite. Commit message: 1. Added Samba Location as Network 2. Removed default locations

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-01 into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-ui-01 into lp:ubuntu-filemanager-app. Commit message: Improved "unlock full access" regarding remote locations Requested reviews: Ubuntu File Manager Developers (ubuntu-filemanager-dev) For mo

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-filemanager-app/add-click-deps into lp:ubuntu-filemanager-app

2015-09-07 Thread Carlos Jose Mazieri
> Ok, built a click based on this merge, which builds successfully, and bundles > in all the samba libs. > http://people.canonical.com/~alan/filemanager/com.ubuntu.filemanager_0.4.467_a > rmhf.click > > Tried goto -> smb://nas.local or some other local IP which serves up over SMB > and it failed.

[Ubuntu-touch-coreapps-reviewers] [Bug 1444367] Re: file manager suspected not to listen to unmount events

2015-09-07 Thread Carlos Jose Mazieri
Yes, it looks like a bug in QFileSystemWatcher https://forum.qt.io/topic/8566/qfilesystemwatcher-not-working-with-etc- mtab ** Changed in: ubuntu-filemanager-app Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu File Manager Developers, whic

[Ubuntu-touch-coreapps-reviewers] [Bug 1473669] Re: Properties Dialog shows wrong dates

2015-09-06 Thread Carlos Jose Mazieri
** Changed in: ubuntu-filemanager-app Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpa

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-06 Thread Carlos Jose Mazieri
Review: Approve OK, thanks. -- https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-tou

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-06 Thread Carlos Jose Mazieri
The proposal to merge lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578 -- Your team Ubuntu File Manager Developers is subsc

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes into lp:ubuntu-filemanager-app

2015-09-06 Thread Carlos Jose Mazieri
The proposal to merge lp:~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes/

[Ubuntu-touch-coreapps-reviewers] [Bug 1486808] Re: Cannot view folders in SD card from File manager

2015-09-03 Thread Carlos Jose Mazieri
Have you tried to check "unlock full content" ? if not please give it a try. -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes into lp:ubuntu-filemanager-app

2015-09-03 Thread Carlos Jose Mazieri
Review: Approve This is OK to me. Thanks. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-filemanager-app/fix-1490146-chdoctypes/+merge/269565 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/ubuntu-filemanager-app/ok into lp:ubuntu-filemanager-app

2015-09-03 Thread Carlos Jose Mazieri
Review: Needs Information Have you looked at the entire repository code? It may have any .cpp or .h code using the same, some messages come from c++ code. -- https://code.launchpad.net/~mterry/ubuntu-filemanager-app/ok/+merge/269578 Your team Ubuntu File Manager Developers is subscribed to b

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 into lp:ubuntu-filemanager-app

2015-08-25 Thread Carlos Jose Mazieri
Review: Approve I did a top approve myself as Arto had already done it. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launc

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 into lp:ubuntu-filemanager-app

2015-08-25 Thread Carlos Jose Mazieri
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-14/+merge/265213 -- Your

[Ubuntu-touch-coreapps-reviewers] [Bug 1482666] Re: Hidden files

2015-08-23 Thread Carlos Jose Mazieri
Hello, Maybe you are talking about SD card only. Can you confirm that it is not a file manager bug? -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail

  1   2   >