Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/ubuntu-clock-app/snap-the-clock into lp:ubuntu-clock-app

2016-07-14 Thread Daniel Holbach
Diff comments: > > === added file 'snapcraft.yaml' > --- snapcraft.yaml1970-01-01 00:00:00 + > +++ snapcraft.yaml2016-07-13 13:54:09 + > @@ -0,0 +1,49 @@ > +name: ubuntu-clock-app > +version: 3.6+snap2 Is there a way to auto-complete the version number just like in

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/ubuntu-clock-app/snap-the-clock into lp:ubuntu-clock-app

2016-07-13 Thread Daniel Holbach
The proposal to merge lp:~dholbach/ubuntu-clock-app/snap-the-clock into lp:ubuntu-clock-app has been updated. Commit Message changed to: Add snapcraft.yaml file for the clock app. Simply: "sudo apt install snapcraft; snapcraft" to generate a snap file from within the source. For more

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/ubuntu-clock-app/snap-the-clock into lp:ubuntu-clock-app

2016-07-13 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/ubuntu-clock-app/snap-the-clock into lp:ubuntu-clock-app. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) For more details, see: https://code.launchpad.net/~dholbach/ubuntu-clock-app/snap-the-clock/+merge/299947 -- Your team

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/ubuntu-calculator-app/add-snapcraft.yaml into lp:ubuntu-calculator-app

2016-07-12 Thread Daniel Holbach
The proposal to merge lp:~dholbach/ubuntu-calculator-app/add-snapcraft.yaml into lp:ubuntu-calculator-app has been updated. Commit Message changed to: Add snapcraft.yaml file. For more details, see: https://code.launchpad.net/~dholbach/ubuntu-calculator-app/add-snapcraft.yaml/+merge/299817 --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/ubuntu-calculator-app/add-snapcraft.yaml into lp:ubuntu-calculator-app

2016-07-12 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/ubuntu-calculator-app/add-snapcraft.yaml into lp:ubuntu-calculator-app. Requested reviews: Ubuntu Calculator Developers (ubuntu-calculator-dev) For more details, see: https://code.launchpad.net/~dholbach/ubuntu-calculator-app/add

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~torsten.franz/help-app/help-app into lp:help-app

2015-10-19 Thread Daniel Holbach
Review: Approve Thanks a lot. -- https://code.launchpad.net/~torsten.franz/help-app/help-app/+merge/274746 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~torsten.franz/help-app/help-app into lp:help-app

2015-10-19 Thread Daniel Holbach
The proposal to merge lp:~torsten.franz/help-app/help-app into lp:help-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~torsten.franz/help-app/help-app/+merge/274746 -- Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template-improvements into lp:help-app

2015-07-30 Thread Daniel Holbach
The proposal to merge lp:~nskaggs/help-app/functional-test-template-improvements into lp:help-app has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~nskaggs/help-app/functional-test-template-improvements/+merge/261626 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/music-app/add-authors into lp:music-app

2015-07-06 Thread Daniel Holbach
Review: Approve Good work! -- https://code.launchpad.net/~popey/music-app/add-authors/+merge/263910 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-calculator-app/add-authors into lp:ubuntu-calculator-app

2015-07-06 Thread Daniel Holbach
Review: Approve Good work! -- https://code.launchpad.net/~popey/ubuntu-calculator-app/add-authors/+merge/263913 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template-improvements into lp:help-app

2015-06-15 Thread Daniel Holbach
The import of build_utils seems to work for the functional tests, but not for the unit tests for some reason. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template-improvements/+merge/261626 Your team Ubuntu Help app developers is requested to review the proposed merge of

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/fix-QA-token into lp:help-app

2015-06-05 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/fix-QA-token into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/fix-QA-token/+merge/261177 -- Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433210 into lp:help-app

2015-06-05 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/1433210 into lp:help-app. Commit message: Readd .link-cta-ubuntu so we can use it to more prominently point out call to action links. This will also allow us to add more attr_list (https://pythonhosted.org/Markdown/extensions

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/FLAC into lp:help-app

2015-06-04 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/FLAC into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/FLAC/+merge/261062 -- Your team Ubuntu Help app developers is requested to review the proposed merge of

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1456929 into lp:help-app

2015-06-03 Thread Daniel Holbach
Review: Approve kalikiana dholbach: looking very good now! -- https://code.launchpad.net/~dholbach/help-app/1456929/+merge/260920 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-06-02 Thread Daniel Holbach
We had some code in the unit tests already to perform a 'web' or 'app' build in a tempdir already, so I attempted to make that available for the functional tests too, but it's not quite working yet... do you think you have some free cycles?

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-29 Thread Daniel Holbach
Review: Needs Information How can the two sets of tests (app vs web) be launched separately from each other? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-28 Thread Daniel Holbach
Review: Needs Fixing In the HACKING doc, the cd / command isn't quite right, ie remove the leading '/'. Also: http://pastebin.ubuntu.com/11413858/ Would this also work with launching the 'web' version? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770232 is the way we're going. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Hum... where exactly would you like to move tests to? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Is this going to make anything easier? I had a bit of a hard time moving everything around because of imports and from which path certain scripts needed to be run. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Please note: I'm not rejecting your idea, I'm just trying to understand which problem we're solving. :-) -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Hum... do you know if a newer version of selenium is being put into Ubuntu too? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~nskaggs/help-app/functional-test-template

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Review: Needs Information This generally looks good, we might just want to add selenium to build-deps, etc and run it as part of the build. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/grooveshark-remove into lp:help-app

2015-05-20 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/grooveshark-remove into lp:help-app. Commit message: Remove traces of grooveshark. Requested reviews: Ubuntu Help app developers (help-app-dev) For more details, see: https://code.launchpad.net/~dholbach/help-app/grooveshark-remove

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app

2015-05-13 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/1436316 into lp:help-app. Commit message: Don't sys.exit() if Markdown instatiation fails, catch error in tests and elsewhere. Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1436316 in Ubuntu Help

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1433525 into lp:help-app

2015-05-13 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1433525 into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/1433525/+merge/258866 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app

2015-05-13 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/misc-debug into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011 -- Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/misc-debug into lp:help-app

2015-05-13 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/misc-debug into lp:help-app with lp:~dholbach/help-app/1433525 as a prerequisite. Commit message: Add --inspector arg for ubuntu-html5-app-launcher to DEBUG=1 case in Makefile, document it and pelican's more verbose output. Requested

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1436316 into lp:help-app

2015-05-13 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1436316 into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/1436316/+merge/259007 -- Your team Ubuntu Help app developers is subscribed to branch lp:help-app. --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1446493-pt2 into lp:help-app

2015-05-12 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1446493-pt2 into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/1446493-pt2/+merge/258848 -- Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

2015-03-31 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/1434210 into lp:help-app. Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1434210 in Ubuntu Help App: Build i18n'ed content in build/i18n https://bugs.launchpad.net/help-app/+bug/1434210 For more

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

2015-03-31 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1434210 into lp:help-app has been updated. Commit Message changed to: Separate our build process steps further:  - Edits of our (English) content happen in ./content/  - Translations (from LP) are in ./po/  - 'make translations' generates translated

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

2015-03-31 Thread Daniel Holbach
Reapproving since it was an obvious change in the HACKING doc. -- https://code.launchpad.net/~dholbach/help-app/1434210/+merge/254706 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/new-try-1432710 into lp:help-app

2015-03-30 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/new-try-1432710 into lp:help-app. Commit message: Replace !!T and !!I with !!QA - use new markup Requested reviews: Ubuntu Help app developers (help-app-dev) For more details, see: https://code.launchpad.net/~dholbach/help-app/new

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1432710 into lp:help-app

2015-03-30 Thread Daniel Holbach
In the end we solved it differently. -- https://code.launchpad.net/~dholbach/help-app/1432710/+merge/254278 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1432710 into lp:help-app

2015-03-26 Thread Daniel Holbach
It seems to miss some Q/A pairs for some reason - back to the drawing board. -- https://code.launchpad.net/~dholbach/help-app/1432710/+merge/254278 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1432710 into lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/pep8-fixes into lp:help-app

2015-03-25 Thread Daniel Holbach
Nevermind, I'll merge this directly into ~dholbach/help-app/1434415 -- https://code.launchpad.net/~dholbach/help-app/pep8-fixes/+merge/254013 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/pep8-fixes into lp:help-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app

2015-03-25 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app. Commit message: Run pyflakes3 and pep8 as part of the 'check' target. Requested reviews: Ubuntu Help app developers (help-app-dev) For more details, see: https://code.launchpad.net/~dholbach

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app

2015-03-25 Thread Daniel Holbach
Should pass tests once lp:~dholbach/help-app/1434415 is landed. -- https://code.launchpad.net/~dholbach/help-app/run-pep8-and-pyflakes3/+merge/254059 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app.

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app

2015-03-25 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~dholbach/help-app/run-pep8-and-pyflakes3/+merge/254059 -- Your team Ubuntu Help app developers is

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app

2015-03-25 Thread Daniel Holbach
Approving again, the necessary requirement has landed now. -- https://code.launchpad.net/~dholbach/help-app/run-pep8-and-pyflakes3/+merge/254059 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1435772 into lp:help-app

2015-03-24 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1435772 into lp:help-app has been updated. Commit Message changed to: add test to make sure we don't have markup tags in msgid of .po and .pot files For more details, see: https://code.launchpad.net/~dholbach/help-app/1435772/+merge/253954 -- Your

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1435783 into lp:help-app

2015-03-24 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/1435783 into lp:help-app has been updated. Commit Message changed to: Fixes a path, so that translated markdown is written into the correct directory. Test case in the description of https://bugs.launchpad.net/help-app/+bug/1435783 For more details,

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/pep8-fixes into lp:help-app

2015-03-24 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/pep8-fixes into lp:help-app. Requested reviews: Ubuntu Help app developers (help-app-dev) For more details, see: https://code.launchpad.net/~dholbach/help-app/pep8-fixes/+merge/254013 -- Your team Ubuntu Help app developers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/pep8-fixes into lp:help-app

2015-03-24 Thread Daniel Holbach
The proposal to merge lp:~dholbach/help-app/pep8-fixes into lp:help-app has been updated. Commit Message changed to: daniel@daydream:~/dev/apps/help$ pep8 --repeat --show-source . daniel@daydream:~/dev/apps/help$ For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434125 into lp:help-app

2015-03-23 Thread Daniel Holbach
Ignore the last change. Overwrote the branch with old contents again. -- https://code.launchpad.net/~dholbach/help-app/1434125/+merge/253658 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434415 into lp:help-app

2015-03-23 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/1434415 into lp:help-app. Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1434415 in Ubuntu Help App: Build fails on utopic https://bugs.launchpad.net/help-app/+bug/1434415 For more details, see