[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100 into lp:ubuntu-weather-app

2016-11-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100 into lp:ubuntu-weather-app with lp:~gary-wzl77/ubuntu-weather-app/fix_151 as a prerequisite. Commit message: create snap package by using ubuntu-app-platform plugin. Requested reviews: Ubuntu Weather

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

2016-01-11 Thread Gary.Wang
Looks like Jenkins issue: DEBUG: jenkins job parameter [use_description_for_commit]: not found -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

2016-01-11 Thread Gary.Wang
Looks like Jenkins issue: DEBUG: jenkins job parameter [use_description_for_commit]: not found -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1515722/+merge/278759 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1515722 into lp:ubuntu-calendar-app

2015-12-21 Thread Gary.Wang
leave a comment for Kunal's suggestion. Diff comments: > > === modified file 'TimeLineBase.qml' > --- TimeLineBase.qml 2015-08-20 12:27:59 + > +++ TimeLineBase.qml 2015-11-27 01:49:25 + > @@ -221,28 +221,27 @@ > if (event.endDateTime - day == 0) > return; > >

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app

2015-11-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/lunar_calendar_support into lp:ubuntu-calendar-app with lp:~gary-wzl77/ubuntu-calendar-app/show-week-number as a prerequisite. Commit message: Add lunar calendar support Requested reviews: Yuan-Chen Cheng (ycheng-twn

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/add_prefix into lp:ubuntu-calendar-app

2015-11-08 Thread Gary.Wang
@Alan There is no need to make code change on unity-scope_event. I fix failed test case 2 that Ethan mentioned above in Revno: 719. Please review. Thanks. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/add_prefix/+merge/267317 Your team Ubuntu Calendar Developers is subscribed

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app

2015-08-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/opt_dynamic_creation into lp:ubuntu-calendar-app. Commit message: Performance tunning for page transition. Page Transition between different views will cause dynamic creation(Qt.ResolvedUrl) for qml object back and forth.Using

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app

2015-08-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/optimization_tab_change into lp:ubuntu-calendar-app. Commit message: Tab change will cause dynamic creation(Qt.ResolvedUrl) for qml object back and forth.Using Qt.CreateComponent for dynamic creation for the first time

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-08-07 Thread Gary.Wang
Got feedback from UX-design team that This solution works nicely and I think we should proceed with it. ... -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into lp:ubuntu-calendar-app

2015-08-02 Thread Gary.Wang
Done. Please review the latest MP. Thanks. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into lp:ubuntu-calendar-app

2015-07-11 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into lp:ubuntu-calendar-app. Commit message: Remove recurrence rule for non-repeating event. Requested reviews: Alan Pope  (popey) Related bugs: Bug #1440583 in Ubuntu Calendar App: calendar-app is generating

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-07-10 Thread Gary.Wang
Add screenshots of monthly view with UI-fined based on feedback from UX team. Add setting page in latest repo as well. https://drive.google.com/open?id=0B2H9ECPSSfqIN1AxRGVfMndDYlk https://drive.google.com/open?id=0B2H9ECPSSfqIc0ZqT2lXOEhTX3M --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app

2015-07-08 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/show-week-number into lp:ubuntu-calendar-app. Commit message: Show week number in monthly and yearly view. Requested reviews: Alan Pope  (popey) For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix-1472081 into lp:ubuntu-calendar-app

2015-07-08 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix-1472081 into lp:ubuntu-calendar-app. Commit message: 1.fix display bug for multiple all day events 2.skip event bubble display in case of endDateTime == dd-MM- 12:00 AM Requested reviews: Alan Pope  (popey) For more

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mihirsoni/ubuntu-calendar-app/1466667 into lp:ubuntu-calendar-app

2015-06-24 Thread Gary.Wang
Review: Needs Fixing Personally,I don't think there is a need to introduce new property(eventDuration) in this case,since we have properties startdate and enddate now. Pls take a look at this patch: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_147 --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1466667 into lp:ubuntu-calendar-app

2015-06-23 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix_147 into lp:ubuntu-calendar-app. Commit message: Retain time difference between end and start date when editing Requested reviews: Alan Pope  (popey) For more details, see: https://code.launchpad.net/~gary-wzl77

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1460433_new into lp:ubuntu-calendar-app

2015-06-18 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix_1460433_new into lp:ubuntu-calendar-app. Commit message: 1.Fix multi-day event displayed issue in weeklyview 2.Show end date time for multi-day event in Event details Requested reviews: Alan Pope  (popey) For more details

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/1455377 into lp:ubuntu-calendar-app

2015-06-16 Thread Gary.Wang
Thanks for your reply. I got your point that the wrong end date causes this issue for recurrence Event. But. As u can see in the log. In fact, there is 3 all day event items(items.length) returned from EDS engine.However It shows 6 items in log.The reason for this because we include

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix_1437305_and_1455377 into lp:ubuntu-calendar-app

2015-06-16 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix_1437305_and_1455377 into lp:ubuntu-calendar-app. Requested reviews: Alan Pope  (popey) For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1437305_and_1455377/+merge/262059 Confirmed

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/1455377 into lp:ubuntu-calendar-app

2015-06-16 Thread Gary.Wang
Confirmed by Renato https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1437305/comments/6 We save wrong end date for all day event(end date should be one day later than start date). I submit another patch here and will delete this one if that pass review. Thanks.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036 into lp:ubuntu-calendar-app

2015-06-05 Thread Gary.Wang
Looks good after using Locale.NarrowFormat. Thanks for your good reminder. Pls check the screenshots as following for three different locale. en_UK : https://drive.google.com/open?id=0B2H9ECPSSfqIcFYybldnakdLNEEauthuser=1 zh_CN :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/1455377 into lp:ubuntu-calendar-app

2015-06-04 Thread Gary.Wang
Try to set re-occurrence type(Daily| Monthly| Yearly ) for all day event. Then you can reproduce it. -- https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/1455377/+merge/259207 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036 into lp:ubuntu-calendar-app

2015-06-03 Thread Gary.Wang
In en_GB this is pretty tight on a low resolution display like the bq e4.5. Here's the current calendar app:- http://people.canonical.com/~alan/screenshots/device-2015-06-02-120425.png This is what it looks like with your change:-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036 into lp:ubuntu-calendar-app

2015-06-02 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036 into lp:ubuntu-calendar-app. Requested reviews: Alan Pope  (popey) For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix-1428036/+merge/260804 -- Your team Ubuntu Calendar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/1455377 into lp:ubuntu-calendar-app

2015-05-15 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/1455377 into lp:ubuntu-calendar-app. Requested reviews: Kunal Parmar (pkunal-parmar) For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/1455377/+merge/259207 -- Your team Ubuntu Calendar

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app

2015-05-13 Thread Gary.Wang
Kunal, have u fun with this MR. Still two clear UI bugs has been fixed. Pls approve. BTW: Have u check this one on ur devices? it's marked as FIX COMMITTED. https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1438910 I can see it's still exciting with latest repo on 15.04(r211) --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app

2015-05-06 Thread Gary.Wang
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into lp:ubuntu-calendar-app. Requested reviews: Kunal Parmar (pkunal-parmar) For more details, see: https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge