Review: Approve
Lgtm , Approved
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls/+merge/278228
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Pos
Looks good to me !!
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls/+merge/278228
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into
lp:ubuntu-calendar-app.
-
The proposal to merge
lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls/+merge/278228
--
You
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/SyncSelection into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/SyncSelection/+merge/270237
--
Your team Ubuntu Calen
Review: Approve
Looks good to me !
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/SyncSelection/+merge/270237
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
--
Your team Ubuntu Calendar
Review: Approve
Looks good to me.
Thanks Kunal.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewer
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix-1472081 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix-1472081/+merge/264152
--
Your team Ubuntu Calendar Develo
Review: Approve
Looks good to me !!
Could you please make sure when you commit next time , you revert the pot Files
manually ?
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix-1472081/+merge/264152
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-
Popey,
Any updates from design team regarding this ?
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/show-week-number/+merge/264153
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-r
Review: Needs Fixing
Hi ,
The attached bug code looks , fine it seems you have also added code for
WeekNumber in this MP.
Could you please remove that and push the changes again ?
Diff comments:
>
> === modified file 'MonthComponent.qml'
> --- MonthComponent.qml2015-06-11 14:07:51 +0
Review: Approve
Looks good to me !!
Thanks Kunal
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week/+merge/265889
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-cor
The proposal to merge
lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week/+merge/265889
--
Y
Review: Needs Fixing
it works fine , but there is a small change, it seems we are not using declared
variable , we should remove that if we are not using it.
Diff comments:
> === modified file 'EventListModel.qml'
> --- EventListModel.qml2015-05-14 13:03:02 +
> +++ EventListModel.qm
Review: Approve
looks good to me.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat/+merge/264488
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve
Looks good to me.
Thank you
--
https://code.launchpad.net/~popey/ubuntu-calendar-app/add-authors/+merge/263911
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge lp:~popey/ubuntu-calculator-app/add-authors into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-calculator-app/add-authors/+merge/263913
--
Your team Ubuntu Calculator Develope
Review: Approve
Looks good to me
Thank you.
--
https://code.launchpad.net/~popey/ubuntu-calculator-app/add-authors/+merge/263913
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
The proposal to merge lp:~popey/ubuntu-calendar-app/add-authors into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~popey/ubuntu-calendar-app/add-authors/+merge/263911
--
Your team Ubuntu Calendar Developers is su
Mihir Soni has proposed merging lp:~mihirsoni/ubuntu-calendar-app/1464457 into
lp:ubuntu-calendar-app.
Commit message:
Fixed bug #1464457
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1464457 in Ubuntu Calendar App: "Delete an event from the
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/1464457 into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
Fixed bug #1464457
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1464457/+merge/263185
--
Your team Ubuntu Calendar Develo
Review: Approve
LGTM !!
Thanks.
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_147/+merge/262748
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : u
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_147 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_147/+merge/262748
--
Your team Ubuntu Calendar Develo
Hi Gray,
I understood that , I introduce that to just make code clean and more
understandable.
--
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://laun
Mihir Soni has proposed merging lp:~mihirsoni/ubuntu-calendar-app/147 into
lp:ubuntu-calendar-app.
Commit message:
Fixed bug #147
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #147 in Ubuntu Calendar App: "Changing start date and
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/147 into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
Fixed bug #147
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/147/+merge/262763
--
Your team Ubuntu Calendar Develo
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1460433_new into
lp:ubuntu-calendar-app has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1460433_new/+merge/262357
--
Your team Ubuntu Calendar Deve
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1460433_new into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1460433_new/+merge/262357
--
Your team Ubuntu Calenda
Review: Approve
Hi ,
Thanks for the MP ,It looks good and working as expected.
Thanks,
Mihir Soni
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1460433_new/+merge/262357
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list
Mihir Soni has proposed merging lp:~mihirsoni/ubuntu-calendar-app/fix-1464556
into lp:ubuntu-calendar-app.
Commit message:
Fixed bug #1464556
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/fix-1464556 into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
Fixed bug #1464556
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/fix-1464556/+merge/262248
--
Your team Ubuntu Calenda
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/1438910 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1438910/+merge/255123
--
Your team Ubuntu Calendar Developers is su
Review: Approve
looks good to me
Thanks :)
--
https://code.launchpad.net/~carla-sella/ubuntu-calendar-app/weekview-testing-stubs-completed/+merge/254495
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-c
The proposal to merge
lp:~carla-sella/ubuntu-calendar-app/weekview-testing-stubs-completed into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu-calendar-app/weekview-testing-stubs-completed/+merg
Hi nekhelesh ,
we tried, but we have more options for users after selecting those options.
Like , if you select Daily , then you get list of all days and after that user
provide information to Number of occurrence to be happen.
Would appreciate some designer feedback on same.
--
https://code.
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/MakeEditorVisible
into lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/MakeEditorVisible/+merge/253767
--
Your team Ubun
Review: Approve
Looks good to me good.
Thanks.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/MakeEditorVisible/+merge/253767
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-re
Mihir Soni has proposed merging lp:~mihirsoni/ubuntu-calendar-app/1438910 into
lp:ubuntu-calendar-app.
Commit message:
Fixed bug #1438910
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app
The proposal to merge lp:~mihirsoni/ubuntu-calendar-app/1438910 into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
Fixed bug #1438910
For more details, see:
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1438910/+merge/255123
--
Your team Ubuntu Calendar Develo
Review: Approve
looks good to me !
Tested on desktop works fine.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefDateTime/+merge/253451
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch
40 matches
Mail list logo
