Nekhelesh, would you mind having a look at this again? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-to
Finished merging. Thank you for your patience, Nekhelesh! :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu
Hey Nekhelesh,
I'm sorry for being a bit late.
The reason why I put the i18n.tr() calls in there is because there might be
languages in which it is "2016 April" instead of "April 2016". I'm not sure
about whether there are any such languages, but if we are already fixing
translation issues, I'
No ideas?
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touc
@Stefano: If that is what works, it is what works. ;)
I don't think there is an ideal solution here, but this is what I also came to
my mind when I initially had a look at the issue. So I would support that.
Anyway, the reason why we haven't got any reply might be that Bart doesn't see
when a n
Thanks, Evan!
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-core
@Stefano: If you think that this can be merged, feel free to do so. I don't
think that we need approvals from everyone all the time. ;)
(To be clear: I haven't had a chance to look into it or test it yet.)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/auto-focus-auth/+merge/28
Review: Needs Fixing
Thank you, Evan, for going through the old bugs and trying to fix them!
Here are two screenshots comparing the old and the newer version:
https://drive.google.com/file/d/0B19TeQHX9rTYOVVIT0pPRmU2MW8/view?usp=sharing
https://drive.google.com/file/d/0B19TeQHX9rTYNVRzMW11Qzd6clE
Hi Bart,
In my opinion the patch looks way better than a lot of first-time QML patches.
Congrats on that!
Regarding your questions: I guess we can give you a helping hand here. ;)
I'll try to answer the translation question right now.
Translations are handled by JsonTranslator.qml. It contains
Review: Needs Fixing
I just skimmed through the code and one thing I noticed is that we would
probably want the CTRL key to be translatable, so please remove the "text"
attributes from the keyboard layouts and use the "id" attribute instead.
Furthermore, I'm not sure whether we would want to se
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
--
Your team Ubuntu Termina
Review: Approve
Yes, it is. You'll really come to appreciate QML after a while.
Furthermore, thanks for fixing it. Let's get this merged now. Good job! :)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribe
For my personal projects I also use a different code style but that's what the
terminal app uses. ;)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
I should have made it a bit clearer what I've been referring to with the
semicolons. :D
We do use semicolons for executions of commands, e.g. in JavaScript code blocks
surrounded by {} and in other execution blocks like onTriggered or onClicked
listeners.
We do not use semicolons for QML bindin
Email sent. :)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-core
Oh, and I'll set up an email to Alan regarding the mailing list thing. :)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubun
Review: Needs Fixing
Thank you for the patch! The code looks good to me and I assume Stefano tested
it already.
However, I'm sorry that I am _that_ guy again. :p
For comments we usually put a whitespace after the two leading slashes.
Additionally, we only put semi-colons after QML properties w
The proposal to merge lp:~nikwen/ubuntu-terminal-app/color-scheme-name-mapping
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/color-scheme-name-mapping/+merge/285297
--
Your team Ub
Thanks to both of you for reviewing this. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/color-scheme-name-mapping/+merge/285297
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-revie
Here we go:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/color-scheme-name-mapping/+merge/285297
:)
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/color-scheme-name-mapping into
lp:ubuntu-terminal-app.
Commit message:
Display proper translatable names for color schemes instead of their file names
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Ubuntu
@Stefano: I'm open to that.
However, we need to make sure to still build a new .pot file every once in a
while and with enough time before the next release in order to make sure that
translators have at least a week to get their translations in.
--
https://code.launchpad.net/~mcintire-evan/ubun
Review: Approve
That's ugly...
Ok, so let's merge this now and I'll prepare a "proper" fix for the name.
I guess we can do it much easier by having some sort of mapping which only
changes the displayed name in ColorSchemePage.qml, but doesn't change the file
names. That way we can also make th
The proposal to merge
lp:~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
-
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable_paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
--
Your team Ubuntu Termi
Review: Approve
Ok, great. Let's merge this. :)
I don't know what Launchpad thought when it created the diff for the other MP.
:D
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-
@Stefano: Will Launchpad build the pot file itself in that case or how will it
pick up new translatable strings then?
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
@Stefano: I compared them earlier today due to line 161 of the diff and it
looks like those two colors confused me. However, you're right about the
background color and the red/blue thing also isn't that much of an issue.
Hence, I support renaming the Dark Pastels scheme to the name you suggeste
Review: Needs Information
The new color scheme is great! Very good job, Stefano!
I was about to merge this, but given that this isn't a minor color change, I'd
love to see the old scheme still being an option to choose in the settings. We
have quite a lot of themes anyway and the old one is pro
Merging 'lp:ubuntu-terminal-app' in to 'build_dir'.
Text conflict in po/com.ubuntu.terminal.pot
1 conflicts encountered.
bzr: ERROR: Conflicts from merge
Looks like the pot file merge conflict we've been talking about. Try the
command I posted above. ;)
--
https://code.launchpad.net/~mcintire-e
Review: Approve
Thank you for fixing this, Evan! The MP looks very good. :)
@Stefano: You make a really good point with (1). Let's keep that in mind when
we continue to add features. :)
[Another note regarding pot file conflicts: If you have already committed stuff
which causes a merge conflic
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
--
Your team Ubuntu Termi
The proposal to merge lp:~nikwen/ubuntu-terminal-app/font-size-fix into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
--
Your team Ubuntu Terminal Developers
Thank you for the quick review again! :)
I changed the default back to 10 and tested it on my phone again. I'll
top-level approve this now to get it merged.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
Your team Ubuntu Terminal Developers is subscribed to
Looking at the Jenkins logs, I don't think the test failures are related to the
changes here. (Please correct me if I'm wrong, though!) Any idea what was
happening?
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar De
So I'll also top-level approve this one. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
lp:ubuntu-te
The proposal to merge lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
--
Your team Ubun
The proposal to merge lp:~nikwen/ubuntu-terminal-app/improve-list-item-design
into lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
--
Your team Ubun
Then let's do it. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
--
Mailin
I have to say that I am against the 100th, though. In general I tend to change
appearance settings in applications once and afterwards often want to go back
to the default. This is doable with the current 10th but it would be a hassle
to hit exactly 1.0 when we use 100.
Furthermore, I guess that
Thank you for the review! :)
Here is a comparison of the font sizes with the current default:
https://launchpadlibrarian.net/236776246/comparison.png
This shows that the values from the documentation are probably incorrect.
However, you're right that it looks better on the phone with a ration o
Fixed the merge conflicts. Would you mind looking into it again, please? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launch
Thanks for the review, Stefano. :)
Shall we pull the top-level approve trigger?
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/improve-list-item-design/+merge/285274
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/improv
So I just learned something new. Thanks, David! :)
(By the way, would it be possible to add an example for that to
https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.i18n/ ?)
Now I just have to sort out the merge conflicts.
--
https://code.launchpad.net/~nikwen/ubuntu-calen
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/improve-list-item-design into
lp:ubuntu-terminal-app.
Commit message:
Tweak the design of the ListItems in the settings
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Ubuntu Terminal Developers (ubuntu-terminal
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
lp:ubuntu-terminal-app.
Commit message:
Fix the color scheme to be set to "Ubuntu" again by default
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Jenkins Bot (ubuntu
While working on this I found
https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1542668.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchp
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/font-size-fix
into lp:ubuntu-terminal-app.
Commit message:
Make font size relative to "medium" fontSize for Labels
Default font size is set to be the same as that of gnome-terminal on a Unity 7
desktop
Request
Review: Approve
Thanks for fixing that! I think the reason why nobody came back to you earlier
was that Launchpad doesn't always send notifications for everything.
The best way probably is to either send people a short email (alternatively
ping them on IRC) or to write a small message on the MP
The proposal to merge lp:~mcintire-evan/ubuntu-calendar-app/fix_readme_typo
into lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-calendar-app/fix_readme_typo/+merge/280670
--
Your team Ubuntu C
Looks like there have been a few changes in trunk since you branched off your
tree. Here is how to resolve this:
$ bzr branch lp:~mcintire-evan/ubuntu-terminal-app/disable-paste
$ bzr branch lp:ubuntu-terminal-app trunk
$ cd disable-paste
$ bzr merge ../trunk
$ bzr conflicts
Review: Needs Fixing
Thanks for changing this. :)
However, there are four lines in the pot file which seem to stem from a merge
error. We need to fix this before we can merge the MP. The easiest way to do
that would probably be to just run it once again from the Ubuntu SDK and then
commit the
** Changed in: ubuntu-filemanager-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
https://bugs.launch
Any update on this? Kunal, have you given it a try yet?
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touc
Thank you for looking into this, Alan! :)
I haven't looked at the code myself yet, but please change the commit message
to something that you would want to see in the bazaar history. "Adding commit
message as required by fussy jenkins bot" probably won't tell you two years
down the road what yo
Review: Needs Fixing
Thank you for the patch!
I really see why you want to implement this feature. However, there are some
issues with the code.
What this currently does is the following: it hides the paste option when the
user has selected some text and shows it if there is no selection. So c
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change-auth into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change-auth/+merge/283240
--
Your team Ubuntu Terminal
Review: Approve
I think we need to kick off the landing here. Thank you for the patch and for
fixing the typo. :)
(Sadly, I didn't get any notification that you updated the MP so that's why I
didn't respond earlier ...)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change-au
Thank you for your contribution!
Please see my inline comment. If you fix it, we can happily merge this. ;)
Diff comments:
>
> === modified file 'src/app/qml/AuthenticationDialog.qml'
> --- src/app/qml/AuthenticationDialog.qml 2015-07-13 20:25:21 +
> +++ src/app/qml/AuthenticationDialo
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/bracket-paste-fix/+merge/279368
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubunt
Thank you, Kunal and David, for looking into this.
@David, to clear this up a bit:
qsTr() is responsible only for the format string here. i18n.tr() delivers the
translated format string while qsTr() in combination with the arg() calls then
goes ahead and replaces %1 and %2 with the arguments, i
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into
lp:ubuntu-calendar-app.
Commit message:
Fix bad month translations for some languages, e.g. Polish
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/bracket-paste-fix into
lp:ubuntu-calculator-app.
Commit message:
Fix pasting brackets
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
Bug #1516321 in Ubuntu Calculator App: "Pa
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into
lp:ubuntu-calendar-app.
Commit message:
Remove unnecessary i18n.tr() calls
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https
Thank you for merging then. I hope to fix the other issue soon. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/paste-zero-fix/+merge/276011
Your team Ubuntu Calculator Developers is requested to review the proposed
merge of lp:~nikwen/ubuntu-calculator-app/paste-zero-fix into
lp:
Thank you for your review, Bartosz. I'll fix the brackets thing as soon as
possible.
However, I'm incredibly busy at the moment and it will take at least one and a
half weeks until I have time for that again.
Regarding the autopilot tests: I don't know how to fit them into my schedule at
the m
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgra
Review: Approve
Thank you for the patch, Bartosz! :)
I gave it a try and couldn't manage to find any regressions. :p I can confirm
that the bug this is supposed to fix is indeed fixed and that the autopilot
tests ran fine on my machine.
Looking at math.js's issue list on Github, I can also not
Here's the fix for the zero pasting issue:
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/paste-zero-fix/+merge/276011
Evil one! :D
Regarding the changelog: To me this looks as if it is automatically generated
somehow. Is this true? If it is, how can I generate it from the bzr history?
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/paste-zero-fix into lp:ubuntu-calculator-app.
Commit message:
Fix issue due to which the zero would not be pasted when using Ctrl+V
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details
Hi Bartosz,
Thank you for your review! :)
Given that you merged it before I had the chance to add a changelog entry, I'll
add another MP for that. ;)
The 0.1 struggle is real though! It looks as if pasting 0 fails in general.
I'll have a look at it. :)
Thanks again,
Niklas
--
https://code.lau
Thank you for modifying the test setup. Let's see if it merges now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launch
The proposal to merge
lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909
--
Yo
Arto, thank you for approving this. Sadly, it looks like the tests still run on
utopic. I'll talk to popey to get this fixed somehow.
--
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909
Your team Ubuntu File Manager Developers is subscribed to bran
The proposal to merge
lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into
lp:ubuntu-filemanager-app has been updated.
Description changed to:
Remove popover workaround for LP: #1395118.
This is becoming rather urgent now that the SDK team is creating a new set of
popover/dialog c
Review: Needs Information
Looks good to me. Well done! ;)
See my inline comments for a few remarks. Some of them are questions though as
you might have a reason why you did things differently.
Nevertheless, I'd like someone who is more familiar with the clock app code to
review this as well. Ho
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-core
Fixed now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-revi
Oh no! I found a bug!
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-corea
I resolved the conflicts. Should be ready for merging now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-re
I'll get to them. Thank you for reviewing this one as well. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-r
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-core
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layouts-click-full-width/+merge/27
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubun
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
No problem. ;)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-to
Thanks for approving. Can we merge it? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-re
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width into
lp:ubuntu-terminal-app.
Commit message:
Allow triggering the layout enabled switch by clicking anywhere on the ListItem
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
For
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update
into lp:ubuntu-terminal-app.
Commit message:
Update to the new UI Toolkit
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
Bug #1474114 in Ubuntu Terminal App: "Upgrade the U
Should be ready for merging now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app.
--
Mailing list: http
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
--
Your team Ubuntu Terminal Develo
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Description changed to:
Update to the new UI Toolkit
I decided not to switch to the new ListItem component this time as it does not
seem to be ready yet. (Check out this thread:
http
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update
into lp:ubuntu-terminal-app.
Commit message:
Update to the new UI Toolkit
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
Bug #1474114 in Ubuntu Terminal App: "Upgrade the U
Hi, I'm sorry for the late reply. Thanks a lot for reviewing this. :)
I have now split the MP as requested:
1)
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
2)
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/desktop-paste-support/+merg
The proposal to merge
lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into
lp:ubuntu-calculator-app has been updated.
Description changed to:
Fix physical delete and backspace keys, implement proper copy support for the
desktop
(This is one of two MPs resulting from splitting
http
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into
lp:ubuntu-calculator-app with
lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix as a prerequisite.
Commit message:
Add proper paste support on the desktop
Requested reviews:
Ubuntu
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into
lp:ubuntu-calculator-app.
Commit message:
Fix physical delete and backspace keys, implement proper copy support for the
desktop
Requested reviews:
Ubuntu Calculator Developers (ubuntu
Thanks a lot for the clarification, Zsombor!
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1124071
Title:
[tabs] Cannot add
The proposal to merge lp:~snwh/ubuntu-terminal-app/updated-icon into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~snwh/ubuntu-terminal-app/updated-icon/+merge/264633
--
Your team Ubuntu Terminal Developers is su
The proposal to merge lp:~snwh/ubuntu-terminal-app/updated-icon into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~snwh/ubuntu-terminal-app/updated-icon/+merge/264633
--
Your team Ubuntu Terminal Developers is su
Review: Approve
@Alan: Yes, I've seen Sam create icons since the very first days when I got in
touch with Ubuntu on my Nexus 4. I've always admired them! (By the way, thank
you for your fast answer.)
Since there do not seem to be any issues with regards to the design team, we
should get this m
1 - 100 of 197 matches
Mail list logo
