The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03/+merge/265194
--
Your team
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03/+merge/265194
--
Your
Thanks for looking at this, for sure I agree, I just was not paying attention
on this.
I will change that in the samba-actions-04 as it changes again
DirModel::canReadDir(), I think that is possible to generate a merge conflict
changing it here.
--
https://code.launchpad.net/~carlos-mazieri/ub
Review: Approve
Several places that this comment applies to:
Why don't you use d(setParentIfRelative(folderName)); here also?
My understanding of C++ is that is more efficient than using assignment to
created object. With assignment the object is first created, and then it's
operator=() called
Review: Approve continuous-integration
PASSED: Continuous integration, rev:433
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/507/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3091
deb:
http://91.189.93.70:8080/job/generic-mediumtests-ut
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-02 as a prerequisite.
Commit message:
Removed some QFileInfo dependency because it will not work for re
6 matches
Mail list logo
