The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into
lp:ubuntu-filemanager-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11/+merge/252982
--
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/202/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2876/console
FAILURE:
Review: Approve
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11/+merge/252982
Your team Ubuntu File Manager Developers is subscribed to branch
lp:ubuntu-filemanager-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11/+merge/252982
--
Review: Approve continuous-integration
PASSED: Continuous integration, rev:402
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/493/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2748
deb:
Thanks, I will work on this.
--
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11/+merge/252982
Your team Ubuntu File Manager Developers is requested to review the proposed
merge of lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into
Some comments:
107 + shares = smb.lisShares();
listShares() ?
138 +m_thread-wait();
This could block forever. Should a reasonable timeout instead be used?
151 +emit working(true);
152 +m_sharesList = smb.lisShares();
153 +emit working(false);
I don't
Review: Approve continuous-integration
PASSED: Continuous integration, rev:398
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/484/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2356
deb:
Carlos Jose Mazieri has proposed merging
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into
lp:ubuntu-filemanager-app with
lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-10 as a prerequisite.
Commit message:
* SmbPlaces which provides shares list to used in the places
9 matches
Mail list logo
