Review: Approve
Looks good!
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
--
Your team Ubuntu Calendar
The proposal to merge lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583 into
lp:ubuntu-calendar-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
--
Your team Ubuntu Calendar Developers
Review: Approve continuous-integration
PASSED: Continuous integration, rev:707
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1222/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/219
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:695
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1221/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/218/console
Click here to trigger a rebuild:
Done.
Please review the latest MP.
Thanks.
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/fix_1440583/+merge/264487
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
Review: Needs Fixing
Hi ,
The attached bug code looks , fine it seems you have also added code for
WeekNumber in this MP.
Could you please remove that and push the changes again ?
Diff comments:
=== modified file 'MonthComponent.qml'
--- MonthComponent.qml2015-06-11 14:07:51
Gary.Wang has proposed merging lp:~gary-wzl77/ubuntu-calendar-app/fix_1440583
into lp:ubuntu-calendar-app.
Commit message:
Remove recurrence rule for non-repeating event.
Requested reviews:
Alan Pope (popey)
Related bugs:
Bug #1440583 in Ubuntu Calendar App: calendar-app is generating
Review: Approve continuous-integration
PASSED: Continuous integration, rev:693
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1211/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3068
deb:
9 matches
Mail list logo
