The proposal to merge
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into
lp:ubuntu-docviewer-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final/+merge/278248
--
The proposal to merge
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final/+merge/27824
Review: Approve
Great! Looks good so far!
--
https://code.launchpad.net/~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final/+merge/278248
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-
Anyway, and that's for sure, the work on zooming is not completed by this MP.
We still have three relevant things to do:
1) Add the double-tap-to-(un)zoom gesture.
2) Properly define the zoom behaviour (minimum zoom, maximum zoom, default
value) for the following three form factors:
- T
> One thing I noticed though is the zoom dropdown is always fixed on "Automatic
> (Fit width)" even if you choose another zoom level, or zoom in or out with the
> buttons. This means if you change the zoom level, you can never re-choose "Fit
> Width) because it thinks it's already ticked.
Honestly
Review: Needs Fixing
This is looking great.
One thing I noticed though is the zoom dropdown is always fixed on "Automatic
(Fit width)" even if you choose another zoom level, or zoom in or out with the
buttons. This means if you change the zoom level, you can never re-choose "Fit
Width) because
Review: Approve
I left 4 diff comments.
They are just a few small notes, your changes look good to me.
Tested on desktop, with both Ubuntu.Layouts modes. I didn't see any regression
(cannot test touch events on my PC though).
Tested on the BQ, and works greatly as expected!
Nice work, Roman!
Review: Approve continuous-integration
PASSED: Continuous integration, rev:200
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/25/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/168/console
Click here to trigger a rebuild:
https://core-apps-jenk
Roman Shchekin has proposed merging
lp:~mrqtros/ubuntu-docviewer-app/ubuntu-docviewer-app-zoom-final into
lp:ubuntu-docviewer-app.
Commit message:
Zoom in LO.
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Document Viewer Developers (ubuntu-docv
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:199
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/24/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/167/console
Click here to trigger a rebuild:
https://core-apps
10 matches
Mail list logo
