[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-06-03 Thread noreply
The proposal to merge lp:~nskaggs/help-app/functional-test-template into lp:help-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 -- Your team Ubuntu Help app developers is subscribed

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-06-02 Thread Daniel Holbach
We had some code in the unit tests already to perform a 'web' or 'app' build in a tempdir already, so I attempted to make that available for the functional tests too, but it's not quite working yet... do you think you have some free cycles?

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-29 Thread Daniel Holbach
Review: Needs Information How can the two sets of tests (app vs web) be launched separately from each other? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-29 Thread Nicholas Skaggs
Yes, you can launch just app or web if you wish. autopilot3 run help_app.tests.test_app_launch.LaunchTestApp autopilot3 run help_app.tests.test_app_launch.LaunchTestWeb However, this doesn't let you do autopilot3 run help_app.tests.test_app autopilot3 run help_app.tests.test_web For that we

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-28 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:149 http://91.189.93.70:8080/job/help-app-ci/37/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/37 SUCCESS: http://91.189.93.70:8080/job/help-app-vivid-amd64-ci/39 Click here to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-28 Thread Daniel Holbach
Review: Needs Fixing In the HACKING doc, the cd / command isn't quite right, ie remove the leading '/'. Also: http://pastebin.ubuntu.com/11413858/ Would this also work with launching the 'web' version? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770232 is the way we're going. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Nicholas Skaggs
Yes, the QA folks are trying to get properly updated packages into the archive so the ppa isn't needed. I agree on running it as part of the build, and I'd also like to put the current tests into a 'unit' testing folder perhaps? --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Hum... where exactly would you like to move tests to? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Nicholas Skaggs
internals/tests/*.py - internals/tests/unit -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Is this going to make anything easier? I had a bit of a hard time moving everything around because of imports and from which path certain scripts needed to be run. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Please note: I'm not rejecting your idea, I'm just trying to understand which problem we're solving. :-) -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Nicholas Skaggs
Yes, not in this MP regardless, lol. I guess I'll stop talking. This MP has everything in it I'd like to merge at the moment :-) -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Hum... do you know if a newer version of selenium is being put into Ubuntu too? -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~nskaggs/help-app/functional-test-template

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-27 Thread Daniel Holbach
Review: Needs Information This generally looks good, we might just want to add selenium to build-deps, etc and run it as part of the build. -- https://code.launchpad.net/~nskaggs/help-app/functional-test-template/+merge/260206 Your team Ubuntu Help app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-26 Thread Nicholas Skaggs
Nicholas Skaggs has proposed merging lp:~nskaggs/help-app/functional-test-template into lp:help-app. Commit message: Add basic skeleton structure for adding functional tests Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1456924 in Ubuntu Help App: Add

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nskaggs/help-app/functional-test-template into lp:help-app

2015-05-26 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:144 http://91.189.93.70:8080/job/help-app-ci/35/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/35/console FAILURE: