The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406
--
Your team Ubuntu Calendar Develo
Review: Approve continuous-integration
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app.
--
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406
--
Your team Ubuntu Calendar
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/28/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1429/console
--
https://code.la
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406
--
Your team Ubuntu Calendar
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/27/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1428/console
--
https://code.la
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280406
--
Your team Ubuntu Calendar
Review: Approve continuous-integration
PASSED: Continuous integration, rev:699
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/28/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/256/console
Click here to trigger a rebuild:
https://core-apps-jenki
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1476032
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: "[Calendar] New event
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Rejected => Needs review
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280405
--
Your team Ubuntu Calendar
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280405
--
Your team Ubuntu Calendar
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: "[Calendar] New event defaults to
"Personal" calendar even i
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
--
Your team Ubuntu Calendar Develo
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
--
Your team Ubuntu Calendar
Review: Approve
Looks good to me.
Thanks Kunal.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewer
Thanks, I updated the MR
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-t
Review: Needs Fixing
it works fine , but there is a small change, it seems we are not using declared
variable , we should remove that if we are not using it.
Diff comments:
> === modified file 'EventListModel.qml'
> --- EventListModel.qml2015-05-14 13:03:02 +
> +++ EventListModel.qm
Review: Approve continuous-integration
PASSED: Continuous integration, rev:695
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1214/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/3085
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utop
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1369543
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: "[Calendar] New event
19 matches
Mail list logo
