[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Len Ovens
Applied patch, Thank you. Found that "array-based execution" did not work. The filename was not passed to the executable. So it was changed back to the working "string-based execution". Yes I am running on the latest LTS (18.04) and yes it should work there as well as the current cycle. See line 41

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
Note also when I ran this through a test with mixed-indentation like was used in some places there were some indentation complaints in code testers. This patch is *large* because it avoids those Indentation errors that can cause headaches in some cases. -- You received this bug notification beca

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
** Patch added: "Refactor_rm_cp_and_subproccess_calls,_PEP8_style.patch" https://bugs.launchpad.net/ubuntustudio-menu-add/+bug/1831154/+attachment/5271493/+files/Refactor_rm_cp_and_subproccess_calls%2C_PEP8_style.patch -- You received this bug notification because you are a member of Ubuntu S

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
The following is a patch containing proposed possible changes. Note that while the patch LOOKS huge that's because I got rid of tab indentation with PEP8 dictated 4-spaces indents. There's some other refactoring done here in order to behave properly with the new calls for things, replacing 'cmd'

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Seth Arnold
Consider it a goal to remove all the uses of subprocess except exo- desktop-item-edit, and to replace the string-based execution there with an array-based execution as seen in the documentation: https://docs.python.org/3/library/subprocess.html#subprocess.run For the rm and cp commands: https://d

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
I had sponsored this, but when digging deeper into the code with Security Team and Seth Arnold we found some nasty approaches here that are better handled with Python in-built functions rather than subprocess wrappers. I've asked the Archive Admins to reject the upload, and Seth Arnold has made so

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
Hello. I went through this with a fine-toothed comb and some additional Lintian flags against the built binaries. Only lintian warning was about a missing manpage, but I'm ignoring that because of the plethora of packages in Ubuntu that don't have manpages. I didn't notice any major issues with

[Ubuntustudio-bugs] [Bug 1831154] Re: [needs-packaging] ubuntustudio-menu-add

2019-06-18 Thread Thomas Ward
I took a look at the package. As I indicated in #ubuntustudio-devel, this has a few things that need fixed. The BUGS and ROADMAP files are identical. Was this intentional? Changelog as-is can't be accepted - UNRELEASED is not a valid changelog target, but I'm probably just being overly pedantic

[Ubuntustudio-bugs] [Bug 1832651] Re: jackdbus fails to start: cannot allocate memory

2019-06-18 Thread Brian Murray
** Tags added: rls-ee-incoming ** Changed in: systemd (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Studio Bugs, which is subscribed to jackd2 in Ubuntu. Matching subscriptions: ubuntustudio-bugs: jackd2 https://bugs.launchpad.

[Ubuntustudio-bugs] [Bug 1833272] [NEW] Gimp crashes while adding text

2019-06-18 Thread Stefan Hüller
Public bug reported: GIMP opened normally, but chrashed down while clicking on the text-Tool. Please see debugging-info below: GNU Image Manipulation Program version 2.10.12 git-describe: GIMP_2_10_10-209-g3d8535b55f C compiler: Using built-in specs. COLLECT_GCC=gcc COLLE