Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: On Saturday 05 September 2009 23:55, Mike Frysinger wrote: On Saturday 05 September 2009 17:55:26 Denys Vlasenko wrote: On Saturday 05 September 2009 16:04:36 Denys Vlasenko wrote: +#ifndef O_CLOEXEC +# define O_CLOEXEC 0

Re: Compilation of syscall.c fails on ARM device

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 01:07:05 Ron wrote: Unless your Samsung unit is some sort of freak without thumb instructions EABI should work on it just fine. The main users I know of that got burned by the EABI switch were some of the strongarm chips, which are actually armv4, but afaik no-one

Re: we have #define MAXHOSTNAMELEN 64, but #define NI_MAXHOST 1025

2009-09-06 Thread Mike Frysinger
On Saturday 05 September 2009 18:45:41 Denys Vlasenko wrote: include/rpc/types.h declares #ifndef MAXHOSTNAMELEN #defineMAXHOSTNAMELEN 64 #endif while include/netdb.h declares # define NI_MAXHOST 1025 (1) It probably would be better if we have internally consistent idea how

Re: [git commit master] math.h: fix trivial typo (missing !): !defined __NO_LONG_DOUBLE_MATH

2009-09-06 Thread Mike Frysinger
On Saturday 05 September 2009 18:12:08 Denys Vlasenko wrote: On Saturday 05 September 2009 23:57, Mike Frysinger wrote: - fcntl(LogFile, F_SETFD, 1); /* 1 == FD_CLOEXEC */ + fcntl(LogFile, F_SETFD, FD_CLOEXEC); /*

Re: Compilation of syscall.c fails on ARM device

2009-09-06 Thread Khem Raj
On Wed, Aug 19, 2009 at 12:22 PM, Mike Frysingervap...@gentoo.org wrote: On Wednesday 19 August 2009 15:02:18 Khem Raj wrote: On Tue, Aug 18, 2009 at 4:23 PM, Mike Frysingervap...@gentoo.org wrote: On Tuesday 18 August 2009 18:42:36 Khem Raj wrote: If we need to revive OABI then we might

Re: Compilation of syscall.c fails on ARM device

2009-09-06 Thread Ron
On Sun, Sep 06, 2009 at 02:20:20AM -0400, Mike Frysinger wrote: On Sunday 06 September 2009 01:07:05 Ron wrote: Unless your Samsung unit is some sort of freak without thumb instructions EABI should work on it just fine. The main users I know of that got burned by the EABI switch were some

Re: we have #define MAXHOSTNAMELEN 64, but #define NI_MAXHOST 1025

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 08:26, Mike Frysinger wrote: On Saturday 05 September 2009 18:45:41 Denys Vlasenko wrote: include/rpc/types.h declares #ifndef MAXHOSTNAMELEN #defineMAXHOSTNAMELEN 64 #endif while include/netdb.h declares # define NI_MAXHOST 1025 (1) It

Re: Commit 6625518cd6 broke cross compiling?

2009-09-06 Thread Bernhard Reutner-Fischer
2009/9/5 Mike Frysinger vap...@gentoo.org: On Saturday 05 September 2009 14:14:40 Bernhard Reutner-Fischer wrote: On Sat, Sep 05, 2009 at 08:12:48AM -0400, Mike Frysinger wrote: leveraging $(ARCH) makes sense in my mind and aligns it with the build systems we are copying from ... Ok, i'll

Re: Commit 6625518cd6 broke cross compiling?

2009-09-06 Thread Bernhard Reutner-Fischer
2009/9/5 Denys Vlasenko vda.li...@googlemail.com: On Saturday 05 September 2009 00:23, Khem Raj wrote: use make ARCH=your arch specifying ARCH is needed now on makefile commandline. Why? This information is available from .config file. And it was working without before. Previously when you

Re: we have #define MAXHOSTNAMELEN 64, but #define NI_MAXHOST 1025

2009-09-06 Thread Bernhard Reutner-Fischer
2009/9/6 Denys Vlasenko vda.li...@googlemail.com: On Sunday 06 September 2009 08:26, Mike Frysinger wrote: On Saturday 05 September 2009 18:45:41 Denys Vlasenko wrote: include/rpc/types.h declares #ifndef MAXHOSTNAMELEN #define        MAXHOSTNAMELEN  64 #endif while include/netdb.h

Re: Commit 6625518cd6 broke cross compiling?

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 14:22, Bernhard Reutner-Fischer wrote: 2009/9/5 Mike Frysinger vap...@gentoo.org: On Saturday 05 September 2009 14:14:40 Bernhard Reutner-Fischer wrote: On Sat, Sep 05, 2009 at 08:12:48AM -0400, Mike Frysinger wrote: leveraging $(ARCH) makes sense in my mind and

fstatat is broke

2009-09-06 Thread Timo Teräs
Hi all, I'm using the *at stuff and noticed that fstatat is broke. fstatat is a bit different since that syscall is not really available. Glibc makes fstatat do fstatat64 syscall and converts the struct kernel_stat64 to struct stat. I think that is what was also intended in uclibc case, but

Re: Compilation of syscall.c fails on ARM device

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 04:08:14 Khem Raj wrote: On Wed, Aug 19, 2009 at 12:22 PM, Mike Frysingervap...@gentoo.org wrote: On Wednesday 19 August 2009 15:02:18 Khem Raj wrote: On Tue, Aug 18, 2009 at 4:23 PM, Mike Frysingervap...@gentoo.org wrote: On Tuesday 18 August 2009 18:42:36 Khem

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 06:07:04 Denys Vlasenko wrote: On Sunday 06 September 2009 08:18, Mike Frysinger wrote: On Saturday 05 September 2009 18:05:32 Denys Vlasenko wrote: On Saturday 05 September 2009 23:55, Mike Frysinger wrote: On Saturday 05 September 2009 17:55:26 Denys

Re: we have #define MAXHOSTNAMELEN 64, but #define NI_MAXHOST 1025

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 07:11:53 Denys Vlasenko wrote: On Sunday 06 September 2009 08:26, Mike Frysinger wrote: On Saturday 05 September 2009 18:45:41 Denys Vlasenko wrote: include/rpc/types.h declares #ifndef MAXHOSTNAMELEN #defineMAXHOSTNAMELEN 64 #endif while

Re: fstatat is broke

2009-09-06 Thread Mike Frysinger
On Sunday 06 September 2009 09:40:00 Timo Teräs wrote: I'm using the *at stuff and noticed that fstatat is broke. fstatat is a bit different since that syscall is not really available. Glibc makes fstatat do fstatat64 syscall and converts the struct kernel_stat64 to struct stat. I think that

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 17:27, Mike Frysinger wrote: +#ifndef O_CLOEXEC +# define O_CLOEXEC 0 +#endif it should be defined by the C library headers. if it isnt, then the port needs updating and the build should fail. so please

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Mike Frysinger
On Sun, Sep 6, 2009 at 3:56 PM, Denys Vlasenko wrote: Then I do not understand what exactly you are saying. i'll break it down. these things need to happen: - revert all this #ifndef O_CLOEXEC - import __ASSUME_O_CLOEXEC from glibc into our kernel-features.h - remove the #if 0 in all the

Re: [git commit master] CLOEXEC: use open(CLOEXEC) if exist; do not check fcntl(FD_CLOEXEC) failure

2009-09-06 Thread Denys Vlasenko
On Sunday 06 September 2009 23:43, Mike Frysinger wrote: On Sun, Sep 6, 2009 at 3:56 PM, Denys Vlasenko wrote: Then I do not understand what exactly you are saying. i'll break it down. these things need to happen: - revert all this #ifndef O_CLOEXEC - import __ASSUME_O_CLOEXEC from

Re: Commit 6625518cd6 broke cross compiling?

2009-09-06 Thread Rob Landley
On Sunday 06 September 2009 07:22:56 Bernhard Reutner-Fischer wrote: 2009/9/5 Mike Frysinger vap...@gentoo.org: On Saturday 05 September 2009 14:14:40 Bernhard Reutner-Fischer wrote: On Sat, Sep 05, 2009 at 08:12:48AM -0400, Mike Frysinger wrote: leveraging $(ARCH) makes sense in my mind