[patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Timo Teräs
I semi-accidentally added include for libc-lock.h because the intention was to use locking macroes from there. However, we ended up using using the weak alias stuff. This is additionally good since now this can result in compile errors like: In file included from

Re: [patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Carmelo AMOROSO
On 4/20/2010 10:59 AM, Timo Teräs wrote: I semi-accidentally added include for libc-lock.h because the intention was to use locking macroes from there. However, we ended up using using the weak alias stuff. This is additionally good since now this can result in compile errors like: In file

Re: [patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Timo Teräs
Carmelo AMOROSO wrote: On 4/20/2010 10:59 AM, Timo Teräs wrote: Remove the unneeded include causing breakage. -#include bits/libc-lock.h I guess this is required for STDIO_FUTEXES, or am I wrong ? Not needed. If STDIO_FUTEXES is defined, the file includes later on bits/stdio-lock.h which

Re: [patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Carmelo AMOROSO
On 4/20/2010 11:40 AM, Timo Teräs wrote: Carmelo AMOROSO wrote: On 4/20/2010 10:59 AM, Timo Teräs wrote: Remove the unneeded include causing breakage. -#include bits/libc-lock.h I guess this is required for STDIO_FUTEXES, or am I wrong ? Not needed. If STDIO_FUTEXES is defined, the file

Re: [patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Laurent Bercot
-#include bits/libc-lock.h I guess this is required for STDIO_FUTEXES, or am I wrong ? Not needed. If STDIO_FUTEXES is defined, the file includes later on bits/stdio-lock.h which ends up including the libc-lock.h. ok, that's fine. Not wanting to interfere, but shouldn't including an

Re: [patch] nptl: remove unneeded libc-lock.h include

2010-04-20 Thread Timo Teräs
Laurent Bercot wrote: -#include bits/libc-lock.h I guess this is required for STDIO_FUTEXES, or am I wrong ? Not needed. If STDIO_FUTEXES is defined, the file includes later on bits/stdio-lock.h which ends up including the libc-lock.h. ok, that's fine. Not wanting to interfere, but