Re: Cancellation changes

2011-05-07 Thread Khem Raj
On (22/04/11 01:58), Peter Mazinger wrote: > Hello, > > I have committed changes to future branch to generalize cancellation in > C code along with some examples. > Do you consider such change acceptable after release? We will look through future branch and pull patches into master after the rel

[PATCH/RFC future] nptl: reinstate SIGCANCEL/SIGSETXID safeguards

2011-05-07 Thread Kevin Cernekee
Commit 8ab3145f (remove sigaction, sigprocmask, and sigfillset from libpthread) removed duplicated implementations of the three aforementioned functions from libpthread. However, as Rich Felker pointed out, the libc and libpthread versions are not always 100% identical. A closer examination of th

Re: [PATCH/RFC future] nptl: reinstate SIGCANCEL/SIGSETXID safeguards

2011-05-07 Thread Rich Felker
On Sat, May 07, 2011 at 07:12:23PM -0700, Kevin Cernekee wrote: > functions from libpthread. However, as Rich Felker pointed out, the > libc and libpthread versions are not always 100% identical. A closer > examination of the pre-8ab3145f disassemblies showed the following: > > libc sigfillset()

Re: [PATCH/RFC future] nptl: reinstate SIGCANCEL/SIGSETXID safeguards

2011-05-07 Thread Kevin Cernekee
On Sat, May 7, 2011 at 7:16 PM, Rich Felker wrote: >> libc sigfillset() returns a full set: all 128 bits are set.  libpthread >> sigfillset() sets only 126 bits: everything except SIGCANCEL/SIGSETXID. > > I fail to see how having sigfillset/sigaddset do the blocking of these > signals makes sense.